Bug #2789
closedIE 8 Profile Overlay Issue
0%
Description
A member just reported not being able to dismiss the "You Profile Page Had Changed" message on IE7 (screenshot attached). She said that she kept clicking the X but nothing happened. She was able to download Chrome and dismiss the message from that web browser.
Files
Updated by Matt Gold over 10 years ago
- Priority name changed from Immediate to Urgent
Thanks for the report, Sarah. Just FYI, to my mind, the "Immediate" priority is to be saved for a serious hack to the Commons that needs to be addressed absolutely absolutely absolutely immediately.
Updated by Sarah Morgano over 10 years ago
Thanks for the clarification, Matt. I usually don't assign and set the priority/severity for tickets when I report them, but I thought this was important. Would it be more helpful to leave these fields blank in the future or just use my discretion?
Updated by Matt Gold over 10 years ago
I think that leaving blank is best if you don't mind. Thanks.
Updated by Matt Gold over 10 years ago
Sarah, have we been able to replicate this issue on IE7? Can you find out more about what OS she was using?
Updated by Sarah Morgano over 10 years ago
Since I've already logged in and dismissed the message I can't replicate the issue. I will reach out to Lindsey and update the ticket with her OS/browser when I hear back from her.
Updated by Matt Gold over 10 years ago
Okay. If you are at a computer with a similar OS/browser, I suppose you could follow the instructions here to test: http://redmine.gc.cuny.edu/issues/2786#note-3 (comment #3)
Updated by Sarah Morgano over 10 years ago
- File export.pdf export.pdf added
According to another member who sent along their computer specs (attached), she was using IE8 on Windows 7. So far, 4 members have reported this issue.
Updated by Boone Gorges over 10 years ago
- Status changed from New to Assigned
- Assignee changed from Boone Gorges to Raymond Hoh
Ray, will you please have a look at this?
Updated by Raymond Hoh over 10 years ago
Hmm, I tested IE10 in IE7-compat mode and I was able to clear the "Your Profile Page Has Changed" overlay, but not the "New CUNY Academic Commons Profiles" notice when you're on your profile page.
Are the reports concerning the "Your Profile Page Has Changed" overlay or the "New CUNY Academic Commons Profiles" notice?
Updated by Sarah Morgano over 10 years ago
- Subject changed from IE 7 Profile Overlay Issue to IE 8 Profile Overlay Issue
Another user has reported this issue: http://feedback.commons.gc.cuny.edu/forums/35103-general/suggestions/4447460-can-t-remove-the-announcement-box.
Also, based on the information provided by one of our members who experienced this, I've updated the ticket from IE 7 8.
Updated by Matt Gold over 10 years ago
Hi All --
Reiterating the urgent nature of this ticket
Updated by Boone Gorges over 10 years ago
- Status changed from Assigned to Testing Required
I've spent some time and made a few updates to the JS, and it appears to fix the problem in IE8 and IE7 for me. Can I ask someone with access to these browsers to check? Be sure to do a hard refresh - it's important that the relevant JS files are cleared from your browser cache. (You can check either on the live site or on cdev. Go to your own profile when logged in, and add ?show_overlay=1 to the URL to see the overlay.)
Updated by Matt Gold over 10 years ago
- File support-details.pdf support-details.pdf added
- File profile-viewing.png profile-viewing.png added
- File profile-editing.png profile-editing.png added
- File ie-login-buttons.png ie-login-buttons.png added
Hi Boone --
I just tested on a computer at the GC, on IE10, I think, and things were a mess:
-- couldn't dismiss the profile changed message even though I clicked on the x
-- layout was messed up on the homepage (login button, etc., out of place)
-- layout messed up on the profile editing screen
-- layout messed up on the profile viewing screen
Please see screenshots and details of the testing environment attached.
Updated by Raymond Hoh over 10 years ago
The production version of CAC appears to be on the master branch.
In the master branch of cacap-profiles-overlay.php, there was a `console.log()` call that threw a JS error in IE7 when attempting to close the overlay. This always prevented the overlay from closing.
I've just pushed a commit that removes this call. This needs to be pulled on cdev or production for testing.
Matt's issues appear to be from IE10 being in compatibility view (IE7) mode. We should force the bp-nelo theme to use the newer browser mode so the site will render properly.
Updated by Boone Gorges over 10 years ago
- Status changed from Testing Required to Assigned
Thanks, Ray. So, I was using IE's developer toolbar to try to detect problems, which meant that console.log() was defined, which is why I wasn't able to reproduce the issue. On the other hand, if I were able to reproduce the issue, the only way to know about it would be to activate a console, in which case the issue would go away. Conclusion: IE7 is a terrible browser. I'm glad you know more about it than I do :)
I've pulled the changes to the production site.
The production version of CAC appears to be on the master branch.
Yes, this is intentional, in part so I can cherry-pick over urgent fixes like this one. I don't know how the console call ended up in the master branch but not the 1.5.x branch. I guess I did something wrong somewhere.
We should force the bp-nelo theme to use the newer browser mode so the site will render properly.
Yes. I thought I was doing that with the doctype at the top of each profile page. But maybe I've done it wrong, or there's more I have to do? Can you help with this, Ray?
Updated by Raymond Hoh over 10 years ago
I've pulled the changes to the production site.
Conclusion: IE7 is a terrible browser. I'm glad you know more about it than I do :)
Confirmed that this fixed the IE7 overlay bug. Doesn't fix the fact that the site looks like it was hit with the ugly stick in IE7 though ;) IE7 really does suck as you can't even debug javascript natively!
Yes. I thought I was doing that with the doctype at the top of each profile page. But maybe I've done it wrong, or there's more I have to do? Can you help with this, Ray?
Just pushed a commit to the 1.5.x branch to address this.
Updated by Boone Gorges over 10 years ago
- Status changed from Assigned to Testing Required
Awesome. I have pulled these changes to the master branch and then to the production site as a hotfix. Matt, would you please test in the AM whether they've solved the relevant issues for you? Also, anyone else with access to an older version of IE. (I've tested on 7, 8, and 10, and it's working for me, but as we've seen there are some shit quirks in debugging this stuff.)
Updated by Matt Gold over 10 years ago
Awesome -- huge, huge thanks to you both. Yes, I'll check in the morning.
Updated by Matt Gold over 10 years ago
Matt, would you please test in the AM whether they've solved the relevant issues for you?
Just tested again on that environment and can confirm that clicking on either the x in the corner and the text "close window" closed the window as expected. Nice work!
Updated by Boone Gorges over 10 years ago
- Status changed from Testing Required to Resolved
Thanks for testing. And Ray, thanks for the advice and help.