CUNY Graduate Center - Project Tracking System: Issueshttps://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2024-03-11T22:29:12ZCUNY Graduate Center - Project Tracking System
Redmine CUNY Academic Commons - Bug #19944 (New): Dealing with BuddyPress 12.x upgrade, pt. 2https://redmine.gc.cuny.edu/issues/199442024-03-11T22:29:12ZRaymond Hoh
<p>Follow-up to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Dealing with BuddyPress 12.x upgrade (Resolved)" href="https://redmine.gc.cuny.edu/issues/19493">#19493</a>. Just wanted to make sure my comments in <a class="external" href="https://redmine.gc.cuny.edu/issues/19493#note-10">https://redmine.gc.cuny.edu/issues/19493#note-10</a> are brought forward to a future release:</p>
<blockquote>
<p>For more pronounced changes, I created a new branch -- <a href="https://github.com/cuny-academic-commons/cac/compare/bp12...bp12-part2" class="external">bp12-part2</a> -- that namely switches out all BuddyPress 12 deprecated function calls. We can roll that out in a later maintenance release.</p>
<p>I've been testing <code>bp12-part2</code> with BP Classic <em>deactivated</em> and with <code>BP_IGNORE_DEPRECATED</code> set to <code>true</code> and these are some issues I encountered:</p>
<ul>
<li>BP Event Organiser needs some minor adjustments to account for group subnav registration: <a class="external" href="https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d">https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d</a></li>
<li>bbPress does <a href="https://github.com/bbpress/bbPress/blob/4178cbf665674c128c928fabdc0322badacad06b/src/includes/extend/buddypress/groups.php#L140-L157" class="external">some conditional checks</a> that needs to be delayed to the <code>'bp_parse_query'</code> hook. This fixes an issue with the bbPress stylesheet not loading on group forum pages I mentioned above in <a href="https://redmine.gc.cuny.edu/issues/19493#note-4" class="external">comment 4</a> amongst other permission-related cap overrides for the current user.</li>
<li>I need Git permissions to the <code>tapor-client</code> repo so I can push changes and pin a new version for our <code>cac</code> repo.</li>
</ul>
<p>About the bbPress load order issue:</p>
<blockquote>
<p>Furthermore, when running bp-classic, I had to do some additional work to ensure that bbPress's BP compatibility layer is loaded in time, and is loaded only once. Like the approach above, it's pretty hacky (requiring a static variable to prevent double-loading) but it basically works. Here's the full patch: <a class="external" href="https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0">https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0</a></p>
</blockquote>
<p>I tackled this a little differently in my bbPress commit. See <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039">https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039</a> and the constructor and includes() portion of <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a">https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a</a> . I think the constructor changes might fix your double load order issue. Can you do some tests and see if this works for you, Boone?</p>
</blockquote>
<p>This doesn't need to go in tomorrow's 2.3.4 release. Let's put this in 2.3.5 or later.</p> CUNY Academic Commons - Bug #19928 (New): Forum Topic by Email Statshttps://redmine.gc.cuny.edu/issues/199282024-03-08T17:41:09ZRaymond Hoh
<p>Matt wanted to know the number of topics created by email vs. total number of topics.</p>
<p>Here are the stats:</p>
<p>2024 - 192/515 (so far)<br />2023 - 964/3260<br />2022 - 1058/3272<br />2021 - 1333/4010<br />2020 - 1284/4225<br />2019 - 801/2604<br />2018 - 405/2868<br />2017 - 104/1540<br />2016 - 116/1430<br />2015 - 65/1414<br />2014 - 12/1305</p> CUNY Academic Commons - Bug #18496 (New): PHP 8+ Compatibilityhttps://redmine.gc.cuny.edu/issues/184962023-07-21T22:45:40ZRaymond Hoh
<p>We're currently running PHP 7.4 in our PHPCS set up and on the GC server, but some of us are using PHP 8+ in our development environments. (For example, <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: bp-email-type doesn't properly deal with 'to' arrays (Resolved)" href="https://redmine.gc.cuny.edu/issues/16948">#16948</a>.)</p>
<p>This will be a catch-all ticket to address deprecated notices, fatal errors and the like.</p>
<p>Also, just to note that PHP 7.4 reached end-of-life back in November 2022. Upgrading to PHP 8.2 is probably good to think about when we decide to move hosts. PHP 8.2 is supported until December 2025, while PHP 8.0 will reach end-of-life in November 2023.</p> CUNY Academic Commons - Bug #18235 (Hold): Lots of failed Cavalcade tasks as of 2023-05-13https://redmine.gc.cuny.edu/issues/182352023-05-16T16:22:18ZRaymond Hoh
<p>Was just checking the failed Cavalcade tasks log and noticed something peculiar. As of 2023-05-13 17:33:05 GMT and on, we've had a consistent stream of failed tasks.</p>
<p>Run the following MySQL query to view all results:</p>
<pre>
select * from wp_cavalcade_jobs where timestamp > '2023-05-13 17:32:00' and status = 'failed' order by id desc;
</pre>
<p>As the time of posting, the total number of failed jobs since about three days ago is greater than 15,000. Usually, the number is only a couple failed tasks a day.</p>
<p>I haven't done any further investigation yet, but just wanted to post this issue for now.</p> CUNY Academic Commons - Bug #17712 (New): Event Directory issueshttps://redmine.gc.cuny.edu/issues/177122023-02-22T22:05:04ZRaymond Hoh
<p>Just salvaging a few things brought up by Laurie and Colin in a recently-deleted ticket.</p>
<hr />
<p>Laurie wrote:</p>
<blockquote>
<p>I created a text event in a private group but my "all upcoming" events tab reads zero "0" , see screenshot. Shouldn't the # counts described the following:</p>
<p>"all upcoming" = # of public + events you created in private groups on the commons</p>
<p>"My upcoming" = # of events in private and public groups you are a part of, and events you created</p>
</blockquote>
<hr />
<p>Confirmed about the "All Upcoming" count not including private events that the user authored. Will look into this.</p>
<hr />
<p>Colin wrote:</p>
<blockquote>
<p>Speaking of... there are no upcoming or visible events on the /events/ page, so anything we can do to encourage more event creation (including publishing more ourselves) would help to make that top level page more vibrant.</p>
</blockquote>
<hr />
<p>Maybe we can add a message when there are no upcoming events.</p>
<p>For logged-in users:</p>
<blockquote>
<p>There are no upcoming events. Feel free to [add your upcoming event to the calendar](LINK). You can also view prior events [here](LINK TO PREVIOUS MONTH'S EVENTS).</p>
</blockquote>
<p>For logged-out users:</p>
<blockquote>
<p>There are no public, upcoming events. You can view prior events [here](LINK TO PREVIOUS MONTH's EVENTS).</p>
</blockquote> CUNY Academic Commons - Bug #17587 (New): Recurring event issueshttps://redmine.gc.cuny.edu/issues/175872023-01-31T07:16:53ZRaymond Hoh
<p>I came across a few bugs while testing events:</p>
<ul>
<li>Dates for recurring events are not displayed correctly in list view. The first event date is shown instead of the actual recurring event's date.</li>
<li>Recurring date info is missing on single event pages. For a point of reference, a recurring event page looks like this in Event Organiser: <a class="external" href="http://demo.wp-event-organiser.com/events/event/fortnightly-event/">http://demo.wp-event-organiser.com/events/event/fortnightly-event/</a>. Do we want to port over the <code>"This event is running from X until Y. It is next occurring on Z"</code> line or the "Upcoming Dates" section? (Also, venue map is missing on our single event page as well.)</li>
</ul>
<p>Will add a fix for the former, but could use some feedback on the latter.</p> CUNY Academic Commons - Bug #17542 (New): Ninja Forms plugin can write many "_wp_session" entries...https://redmine.gc.cuny.edu/issues/175422023-01-24T01:02:58ZRaymond Hoh
<p>While looking a bit into <a class="issue tracker-2 status-8 priority-4 priority-default closed" title="Feature: Strategies for reducing database size (Duplicate)" href="https://redmine.gc.cuny.edu/issues/17522">#17522</a>, I looked at the options database table for the <a href="https://iletc.commons.gc.cuny.edu" class="external">ILETC</a> site and found 51,000 entries for options beginning with <code>"_wp_session"</code>:</p>
<pre>
mysql> select count(*) from wp_1185_options where option_name like '_wp_session%';
+----------+
| count(*) |
+----------+
| 51084 |
+----------+
1 row in set (0.02 sec)
</pre>
<p>I searched through our plugins to see what might be causing this and the options comes from the <a href="https://wordpress.org/plugins/ninja-forms/" class="external">Ninja Forms</a> plugin. Specifically, the use of the <code>WP_Session</code> library: <a class="external" href="https://github.com/cuny-academic-commons/cac/blob/master/wp-content/plugins/ninja-forms/includes/Session.php">https://github.com/cuny-academic-commons/cac/blob/master/wp-content/plugins/ninja-forms/includes/Session.php</a>. Sometime in the past, Ninja Forms was activated on the ILETC site, but it isn't currently active.</p>
<p>Next, I decided to look through current sites with Ninja Forms active. Out of the current sites with Ninja Forms active, I came across the <a href="https://digitalfellows.commons.gc.cuny.edu/" class="external">GC Digital Fellows</a> website, which had ~150,000 <code>"_wp_session"</code> options:</p>
<pre>
mysql> select count(*) from wp_1120_options where option_name like '_wp_session%';
+----------+
| count(*) |
+----------+
| 154139 |
+----------+
1 row in set (0.35 sec)
</pre>
<p>The other sites with Ninja Forms active did not have this issue. I just deleted the <code>"_wp_session"</code> options for both ILETC and GC Digital Fellows and cleared the options object cache for both sites.</p>
<p>Perhaps this is an older bug in Ninja Forms that might have been fixed in a more, recent version, but thought it would be worth documenting in a ticket.</p> CUNY Academic Commons - Bug #16255 (New): Need to define 'MULTISITE' constant in wp-config.phphttps://redmine.gc.cuny.edu/issues/162552022-06-18T01:19:20ZRaymond Hoh
<p>While debugging the WebAuthn plugin database prefix problem in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Save Button missing on WordPress Profile page (Resolved)" href="https://redmine.gc.cuny.edu/issues/16245">#16245</a>, I found out that we have never set the following line in our <code>wp-config.php</code> file:</p>
<pre>
define( 'MULTISITE', true );
</pre>
<p>This explains why our main site's database tables are prefixed with <code>wp_1_</code> rather than just <code>wp_</code>. See <a class="external" href="https://github.com/WordPress/WordPress/blob/c70a5c547f187e3a8c58779ae18155874cb412df/wp-includes/wp-db.php#L1065-L1069">https://github.com/WordPress/WordPress/blob/c70a5c547f187e3a8c58779ae18155874cb412df/wp-includes/wp-db.php#L1065-L1069</a>.</p>
<p>I just did a SQL query to see how many DB tables are affected and this is the result:</p>
<pre>
mysql> show tables like 'wp\_1\_%';
+---------------------------------+
| wp_1_2fa_webauthn_credentials |
| wp_1_2fa_webauthn_users |
| wp_1_ak_twitter |
| wp_1_avhec_category_groups |
| wp_1_bdprss_errors_v3 |
| wp_1_bdprss_items_v3 |
| wp_1_bdprss_lists_v3 |
| wp_1_bdprss_sites_v3 |
| wp_1_cac_invites |
| wp_1_cac_library_items |
| wp_1_commentmeta |
| wp_1_comments |
| wp_1_contact_form_7 |
| wp_1_eo_events |
| wp_1_eo_venuemeta |
| wp_1_flickr_post |
| wp_1_links |
| wp_1_ngg_album |
| wp_1_ngg_gallery |
| wp_1_ngg_pictures |
| wp_1_now_reading |
| wp_1_now_reading_books2tags |
| wp_1_now_reading_meta |
| wp_1_now_reading_tags |
| wp_1_options |
| wp_1_podpress_statcounts |
| wp_1_podpress_stats |
| wp_1_pollsa |
| wp_1_pollsip |
| wp_1_pollsq |
| wp_1_postmeta |
| wp_1_posts |
| wp_1_quotescollection |
| wp_1_ratings |
| wp_1_redirection_404 |
| wp_1_redirection_groups |
| wp_1_redirection_items |
| wp_1_redirection_logs |
| wp_1_redirection_modules |
| wp_1_rg_form |
| wp_1_rg_form_meta |
| wp_1_rg_form_view |
| wp_1_rg_incomplete_submissions |
| wp_1_rg_lead |
| wp_1_rg_lead_detail |
| wp_1_rg_lead_detail_long |
| wp_1_rg_lead_meta |
| wp_1_rg_lead_notes |
| wp_1_subscribe2 |
| wp_1_term_relationships |
| wp_1_term_taxonomy |
| wp_1_termmeta |
| wp_1_terms |
| wp_1_wordtube |
| wp_1_wordtube_med2play |
| wp_1_wordtube_playlist |
| wp_1_wpo_campaign |
| wp_1_wpo_campaign_category |
| wp_1_wpo_campaign_feed |
| wp_1_wpo_campaign_post |
| wp_1_wpo_campaign_word |
| wp_1_wpo_log |
| wp_1_wysija_bounce |
| wp_1_wysija_campaign |
| wp_1_wysija_campaign_list |
| wp_1_wysija_custom_field |
| wp_1_wysija_email |
| wp_1_wysija_email_user_stat |
| wp_1_wysija_email_user_url |
| wp_1_wysija_form |
| wp_1_wysija_list |
| wp_1_wysija_queue |
| wp_1_wysija_url |
| wp_1_wysija_url_mail |
| wp_1_wysija_user |
| wp_1_wysija_user_field |
| wp_1_wysija_user_history |
| wp_1_wysija_user_list |
+---------------------------------+
78 rows in set (0.27 sec)
</pre>
<p>Most of these tables are for plugins we do not use on the main site anymore, so we can safely delete and ignore them. But before we add in the <code>define( 'MULTISITE', true )</code> line to <code>wp-config.php</code>, we'd have to copy the affected DB tables to use the <code>wp_</code> prefix first.</p>
<p>This is not really urgent to address (we've gone this long without the MULTISITE constant!), so we can look at this when Boone is back from vacation.</p> CUNY Academic Commons - Bug #16177 (New): Switch to Inbound mode for RBEhttps://redmine.gc.cuny.edu/issues/161772022-05-30T20:32:45ZRaymond Hoh
<p>For the reply-by-email plugin, we use IMAP mode, which relies on connecting to a GMail account to check for new replies and posting items to the Commons.</p>
<p>This isn't the best for performance because IMAP mode uses a long-running process to do the new email checks. RBE also has another mode called Inbound mode, which works on a per-email basis. This mode is already being used to create new forum topics with a custom, group email address (<code>GROUP@groups.commons.gc.cuny.edu</code>), but we haven't fully switched over to using Inbound for replies and private messages because IMAP was already in use.</p>
<p>Some things-to-do before switching:</p>
<p>1. Since we already have set up the <code>GROUP@groups.commons.gc.cuny.edu</code> email address for new forum topics, would it be okay to keep using this email domain for replies as well? (Regular reply email addresses would look something like <code>fb2da051ba2b7220193cca6ada@groups.commons.gc.cuny.edu</code>). The alternative is to set up another email address domain like <code>X@reply.commons.gc.cuny.edu</code>, but RBE hasn't been tested with two different email domains yet. Some background info here: <a class="external" href="https://redmine.gc.cuny.edu/issues/2880#note-24">https://redmine.gc.cuny.edu/issues/2880#note-24</a>. I'd say for now, we should keep using the same email domain unless anyone has any objections.</p>
<p>2. Once we switch to Inbound mode exclusively, replying to older items with the <code>cunyacademiccommons+IDENTIFIER@gmail.com</code> GMail address would no longer work. I was thinking we can set up an auto-replier in GMail, so if a new email matches the body of the RBE format, an auto-reply with the following message could be sent:</p>
<pre>
Hi,
You attempted to reply to our older reply-by-email address that is no longer in service. We have transitioned to a new email address.
If you would like to try emailing your reply with the new email address, please copy the IDENTIFIER portion of the "To" email address in the format of:
cunyacademiccommons+IDENTIFIER@gmail.com
to:
IDENTIFIER@groups.commons.gc.cuny.edu
And resend your previous email using this new email address.
You can always login to the CUNY Academic Commons to view your thread and make your reply there as well.
If you have any questions, please contact us at support@cunycommons.zendesk.com.
</pre> CUNY Academic Commons - Bug #14496 (New): Mapped domain SSO uses third-party cookieshttps://redmine.gc.cuny.edu/issues/144962021-05-24T20:03:23ZRaymond Hoh
<p>Currently, our mapped domain plugin, Mercator, uses third-party cookies in order to automatically sign-on logged-in Commons users to mapped domains.</p>
<p>The problem with this is third-party cookies are increasingly being blocked by default and there are plans in Chrome to scrap third-party cookies entirely <a href="https://blog.chromium.org/2020/01/building-more-private-web-path-towards.html" class="external">in the next few years</a>.</p>
<p>This ticket is to track what we should do.</p>
<p>Some approaches include:</p>
<p>- Redirecting logged-in users to the Commons subdomain instead of the mapped domain<br />- Remove SSO entirely. Meaning that users will have to login again on the mapped domain even if they are already logged into the Commons.<br />- Find another sign-on approach that doesn't use third-party cookies. Could rely on a set of redirects, but has the potential to be error-prone.</p> NYCDH Community Site - Maintenance #12827 (Resolved): Events Calendar Pro and Filter Bar plugin u...https://redmine.gc.cuny.edu/issues/128272020-05-19T16:56:23ZRaymond Hoh
<p>Hi Jesse,</p>
<p>I just upgraded the regular Events Calendar plugin due to my regular updates and now the The Events Calendar is asking to update its Pro plugin to 5.1.0+ and the Filter Bar plugin to 4.10.0+ in the dashboard.</p>
<p>Can you provide the ZIP files for these plugins to me? Also, for future updates, would you prefer I hold off from updating Events Calendar until a later date or to continue asking for the latest versions as needed?</p>
<p>Thanks!</p> CUNY Academic Commons - Bug #11243 (New): Audit bp-custom.phphttps://redmine.gc.cuny.edu/issues/112432019-03-20T04:10:58ZRaymond Hoh
<p>Over the years, we've added a lot of code to our BuddyPress custom code file - <code>bp-custom.php</code>.</p>
<p>Some of that code is no longer applicable to the Commons today. It's time to trim the fat for 1.15!</p> NYCDH Community Site - Bug #11013 (Resolved): Convert subdomain install to subdirectory installhttps://redmine.gc.cuny.edu/issues/110132019-01-25T03:02:01ZRaymond Hoh
<p>NYCDH does not have a wildcard SSL certificate, so we cannot enforce HTTPS across the entire NYCDH multisite install due to our multisite configuration using a subdomain set up.</p>
<p>Converting our multisite install from a subdomain configuration to a subdirectory one would allow us to enforce HTTPS.</p>
<p>I'll look into making this conversion some time after DH Week is completed so we won't disrupt anything.</p> CUNY Academic Commons - Bug #3939 (Hold): Activity stream support for Co-Authors Plus pluginhttps://redmine.gc.cuny.edu/issues/39392015-03-21T17:12:13ZRaymond Hoh
<p>Stemming from <a class="issue tracker-1 status-5 priority-5 priority-high4 closed" title="Bug: Post erroneously ascribed to wrong author in activity feed (Resolved)" href="https://redmine.gc.cuny.edu/issues/3853#note-6">#3853-6</a>, perhaps we should add activity stream support when the Co-Authors Plus plugin is used.</p>
<p>Here are some quotes from <a class="issue tracker-1 status-5 priority-5 priority-high4 closed" title="Bug: Post erroneously ascribed to wrong author in activity feed (Resolved)" href="https://redmine.gc.cuny.edu/issues/3853#note-6">#3853-6</a>:</p>
<blockquote>
<p>About Co-Authors Plus, do we want to do something to support multiple authors? Create a new activity stream item for each author?</p>
</blockquote>
<blockquote>
<p>I'd say this is not worth the effort for our purposes. Though this suggestion, and others on this tracker and elsewhere (<a class="issue tracker-15 status-5 priority-4 priority-default closed" title="Design/UX: Create ability to repost forums posts to other forums (Resolved)" href="https://redmine.gc.cuny.edu/issues/3178">#3178</a>), make me wonder whether BP's activity table should have an 'alias_of' column or something like that, which we could use instead of 'hide_sitewide' for hiding near-dupes. Hmmmmm....</p>
</blockquote>
<p>Currently, it's only being used on three sites so it's not widely used across the Commons. I've marked the status of this ticket to "Hold", but feel free to close.</p> CUNY Academic Commons - Bug #3691 (New): WPMU Domain Mapping Debugging on cdevhttps://redmine.gc.cuny.edu/issues/36912014-12-02T17:23:21ZRaymond Hoh
<p>As per the 1.7.5 release, there was a redirect issue with the WPMU Domain Mapping plugin during upgrade to v0.5.5 that forced us to rollback to the previous version (v0.5.4.3).</p>
<p>Boone has suggested that we help debug the latest release on cdev so we can send a patch back to the authors.</p>
<p>Can you let us know when you've set up a domain for mapping on cdev and whether you require any help in debugging?</p>
<p>Thanks!</p>