CUNY Graduate Center - Project Tracking System: Issueshttps://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2023-11-15T22:33:22ZCUNY Graduate Center - Project Tracking System
Redmine CUNY Academic Commons - Feature #19278 (Resolved): "Account Settings > Edit Profile" screen and "...https://redmine.gc.cuny.edu/issues/192782023-11-15T22:33:22ZRaymond Hoh
<p>I decided to create a new ticket from <a class="issue tracker-2 status-5 priority-4 priority-default closed child" title="Feature: Account Settings Tab (Resolved)" href="https://redmine.gc.cuny.edu/issues/17769">#17769</a>.</p>
<p>Here are Sara's mockups for the "Account Settings > Edit Profile" screen:</p>
<p><img src="https://redmine.gc.cuny.edu/attachments/download/26231/Screen%20Shot%202023-09-05%20at%2011.27.19%20AM.png" alt="" /></p>
<p><img src="https://redmine.gc.cuny.edu/attachments/download/26841/Screenshot%202023-11-14%20at%2011.58.16%20AM.png" alt="" /></p>
<hr />
<p>There was a bit of talk in the dev chat about keeping the CV data and the Commons Profile header data separate. I'm wondering whether we can just use the CV's data as the main source of data. By that I mean, if a user has filled in their CV's name, pronouns, one-line bio, social links, etc, we will display that same data in the Commons Profile header and we will not show the "Account Settings > Edit Profile" screen at all. I've already got some code for this ready to go. The code uses the <code>parse_blocks()</code> function and thanks to the placeholders in those blocks, it is possible to extract data for specific blocks from the CV.</p>
<p>If a user has not filled in their CV, for the header, we will fall back to the data that the user inputted previously during account signup or for their Public Portfolio. For these users, the "Account Settings > Edit Profile" screen will be available so that data can be edited.</p>
<p>I think this would limit the confusion of having two separate pieces of profile data. On the contrary, would users be surprised to see some of their CV data in their Commons Profile header? What does everyone think?</p> CUNY Academic Commons - Bug #19166 (Resolved): "Author" option is missing in Quick Edithttps://redmine.gc.cuny.edu/issues/191662023-10-31T22:43:27ZRaymond Hoh
<p>As reported in <a href="https://redmine.gc.cuny.edu/issues/19114#note-5" class="external">#19114</a>, the "Author" dropdown menu does not show up when clicking on the "Quick Edit" link in the WP admin dashboard.</p>
<p>Steps to reproduce:<br />1. Navigate to the "Posts" or "Pages" admin dashboard page<br />2. In the table, hover over a post or page to edit and click on the "Quick Edit" link<br />3. The "Author" option is missing</p>
<p>It appears that WordPress put a restriction in place to omit the "Author" dropdown if the entire network's user count is greater than 10,000: <a class="external" href="https://github.com/WordPress/WordPress/blob/798991a0ff4684363c11bb7c2598dcef203b85e1/wp-admin/includes/class-wp-posts-list-table.php#L1722-L1759">https://github.com/WordPress/WordPress/blob/798991a0ff4684363c11bb7c2598dcef203b85e1/wp-admin/includes/class-wp-posts-list-table.php#L1722-L1759</a>. The user count on the Commons exceeds 10,000, so the Author dropdown option is omitted.</p>
<p>We can bypass this restriction with the following snippet:</p>
<pre>
add_action( 'admin_enqueue_scripts', function( $hook_suffix ) {
// Bail if not on a post type's dashboard page.
if ( 'edit.php' !== $hook_suffix ) {
return;
}
// Bypass user count check.
add_filter( 'wp_is_large_user_count', '__return_false' );
} );
</pre>
<p>However, I want to know why WordPress put in this restriction in the first place. Boone / Jeremy, is this because the <code>get_users()</code> DB query on <code>'wp_usermeta'</code> is taxing when there is a large user database? Wouldn't it make more sense for the restriction to count the site's users with <code>count_users()</code> rather than the entire network's user base with <code>wp_is_large_user_count()</code>?</p> CUNY Academic Commons - Bug #16313 (Resolved): "My Papers" admin nav should be removed for users ...https://redmine.gc.cuny.edu/issues/163132022-06-28T21:47:45ZRaymond Hoh
<p>Reported in <a class="external" href="https://redmine.gc.cuny.edu/issues/10580#note-13">https://redmine.gc.cuny.edu/issues/10580#note-13</a> by Sara.</p>
<p>Fix coming shortly.</p> CUNY Academic Commons - Bug #16296 (Resolved): "Visit Profile" link on Member Directory page does...https://redmine.gc.cuny.edu/issues/162962022-06-24T23:53:24ZRaymond Hoh
<p>On the Member Directory page, the "Visit Profile" link located at the bottom of each member's card is incorrect.</p>
<p>It currently links to the Member Directory page instead of the member's profile URL.</p> CUNY Academic Commons - Feature #15700 (Resolved): Add leave site functionality to "Dashboard > M...https://redmine.gc.cuny.edu/issues/157002022-03-23T01:26:37ZRaymond Hoh
<p>In <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Users should be able to remove themselves from multi-author sites (Resolved)" href="https://redmine.gc.cuny.edu/issues/8292">#8292</a>, we implemented a "Leave site" feature when you're on your profile's "My Sites" page.</p>
<p>This ticket is to supplement (or supplant) this functionality with another way to leave sites. WordPress already has an internal page that shows which sites you are a member of on the "Dashboard > My Sites" page in the admin area.</p>
<p>We can add some functionality to this page to leave selected sites. Here's an implementation I did for another project:</p>
<p><img src="https://user-images.githubusercontent.com/505921/130160353-2bffbb27-6900-44f2-a917-5c62fc328965.png" alt="" /></p>
<p>The notable changes are:<br />- Adding a "Leave" checkbox. This checkbox only displays if you are not an administrator of the site<br />- Adding a line to display your role(s) for each site if you are not an administrator of the site</p>
<p>The Commons has a few things we have to keep into consideration such as ensuring the Membership Removal site option is respected (see <a class="external" href="https://redmine.gc.cuny.edu/issues/8292#note-11">https://redmine.gc.cuny.edu/issues/8292#note-11</a>), but this should be trivial to add.</p>
<p>Let me know if anyone has any questions or things we need to think about before implementing this.</p> CUNY Academic Commons - Design/UX #15369 (Resolved): "Add Site Icon" overlay on Sites Directory ...https://redmine.gc.cuny.edu/issues/153692022-02-16T22:09:36ZRaymond Hoh
<p>I was thinking of an easy way to encourage site owners to add a new site icon.</p>
<p>What about adding an "Add Site Icon" overlay on the Sites Directory page for sites without a custom site icon? This overlay would only show if the current user is an administrator for the site and if the site is not connected to a group. Clicking on this icon would link directly to the site's Customizer's page to add the icon: <code>/wp-admin/customize.php?autofocus[section=title_tagline</code></p>
<p>Here's a quick mockup:</p>
<p><img src="https://i.postimg.cc/vBWcc3pp/2022-02-16-140516.png" alt="" /></p>
<p>I think this could easily go into a maintenance release. What does everyone think?</p> CUNY Academic Commons - Bug #15175 (Resolved): "Load More" button not working correctly on a user...https://redmine.gc.cuny.edu/issues/151752022-01-11T09:06:53ZRaymond Hoh
<p>While looking into <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: padding missing on Commons Profile (Resolved)" href="https://redmine.gc.cuny.edu/issues/15152">#15152</a>, I discovered that the "Load More" button was not working correctly when on a user's "Commons Profile > Activity" page. The problem is the pagination could be using the wrong page offset and the loading GIF was not showing up when clicking on the button.</p>
<p>The problem is in our bp-nelo theme, the JS selectors for the News / My Commons page and a user's "Commons Profile > Activity" page are different. We need to ensure that the selectors are the same for both pages. As for the pagination bug, we have to port the following fix over from the BuddyPress bp-legacy template pack: <a class="external" href="https://buddypress.trac.wordpress.org/changeset/12181">https://buddypress.trac.wordpress.org/changeset/12181</a>.</p>
<p>Fix coming shortly.</p> CUNY Academic Commons - Bug #14749 (Resolved): "Digital Research Tools" adminbar item should not ...https://redmine.gc.cuny.edu/issues/147492021-09-03T20:48:32ZRaymond Hoh
<p>Was fixed in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Digital Research Tools showing up in top nav for logged out users (Resolved)" href="https://redmine.gc.cuny.edu/issues/13669">#13669</a>, but wasn't backported to the Commons.</p>
<p>Going to address this now.</p> CUNY Academic Commons - Bug #14704 (Resolved): Additional bbPress fixeshttps://redmine.gc.cuny.edu/issues/147042021-08-09T20:03:50ZRaymond Hoh
<p>While working on the latest CBOX release, I found a few additional bugs with bbPress:</p>
<ul>
<li>Trashing a forum topic and later restoring it is not possible as of WordPress 5.6.0. See <a class="external" href="https://bbpress.trac.wordpress.org/ticket/3433">https://bbpress.trac.wordpress.org/ticket/3433</a></li>
</ul>
<ul>
<li>Fix description when topic is marked as 'spam' or 'trash'. See <a class="external" href="https://bbpress.trac.wordpress.org/ticket/3432">https://bbpress.trac.wordpress.org/ticket/3432</a></li>
</ul>
<ul>
<li>Fix pending, trashed and spammed group topic permalinks - If a group topic is unapproved, trashed or spammed, a group moderator cannot view the content of the topic again</li>
</ul>
<ul>
<li>Unapproving a group topic and reapproving it will send another email to the group. See <a class="external" href="https://github.com/boonebgorges/buddypress-group-email-subscription/issues/214">https://github.com/boonebgorges/buddypress-group-email-subscription/issues/214</a></li>
</ul>
<p>Will commit fixes for these items shortly.</p> CUNY Academic Commons - Bug #13332 (Resolved): 'Reply-To' email header can be corrupted in WordPr...https://redmine.gc.cuny.edu/issues/133322020-09-15T16:51:07ZRaymond Hoh
<p>See <a class="external" href="https://github.com/r-a-y/bp-reply-by-email/issues/123">https://github.com/r-a-y/bp-reply-by-email/issues/123</a>.</p>
<p>Basically, PHPMailer was upgraded from v5.2.27 to v6.1.6 in WP 5.5 and this caused an issue with how RBE was working around how a long reply-to email address could be silently discarded. This technique can now corrupt the 'Reply-To' email header, making it impossible to reply to the correct BuddyPress item by email.</p>
<p>I will backport the fix for the next maintenance release.</p> CUNY Academic Commons - Bug #11855 (Resolved): "More Privacy Options" message not showing on logi...https://redmine.gc.cuny.edu/issues/118552019-09-13T16:35:02ZRaymond Hoh
<p>In <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Ability to change error page for non-approved users? (Resolved)" href="https://redmine.gc.cuny.edu/issues/9907">#9907</a>, we implemented a custom message that gets displayed on the login page when someone tries to navigate to a site that has a custom privacy setting (anything that is not public).</p>
<p>Somewhere between then and now, that message no longer shows up.</p>
<p>Going to implement a fix for this.</p> CUNY Academic Commons - Bug #11335 (Resolved): Add mobile responsive styles for Creative Commons ...https://redmine.gc.cuny.edu/issues/113352019-04-16T17:06:09ZRaymond Hoh
<p>Reported by Scott here: <a class="external" href="https://commons.gc.cuny.edu/?p=75786">https://commons.gc.cuny.edu/?p=75786</a></p>
<p>The "Choose a License" modal is not responsive on devices with small screen widths.</p> CUNY Academic Commons - Bug #11083 (Resolved): "My Settings > Export Data" page is blankhttps://redmine.gc.cuny.edu/issues/110832019-02-11T23:39:34ZRaymond Hoh
<p>BuddyPress introduced functionality in v4.0.0 to allow users to export their WordPress data.</p>
<p>If you navigate to "My Settings > Export Data", you should see a page that resembles this:<br /><a class="external" href="https://buddypress.org/wp-content/uploads/1/2018/11/data-export.png">https://buddypress.org/wp-content/uploads/1/2018/11/data-export.png</a></p>
<p>However, it's currently blank as our bp-nelo theme uses an older BuddyPress format. I'll add support for bp-nelo, but do we want to disable this functionality on the Commons?</p>
<p>Marking for 1.14.6 so I can add this functionality to bp-nelo, but we can bump to 1.14.7 if we need to disable this.</p> CUNY Academic Commons - Bug #3939 (Hold): Activity stream support for Co-Authors Plus pluginhttps://redmine.gc.cuny.edu/issues/39392015-03-21T17:12:13ZRaymond Hoh
<p>Stemming from <a class="issue tracker-1 status-5 priority-5 priority-high4 closed" title="Bug: Post erroneously ascribed to wrong author in activity feed (Resolved)" href="https://redmine.gc.cuny.edu/issues/3853#note-6">#3853-6</a>, perhaps we should add activity stream support when the Co-Authors Plus plugin is used.</p>
<p>Here are some quotes from <a class="issue tracker-1 status-5 priority-5 priority-high4 closed" title="Bug: Post erroneously ascribed to wrong author in activity feed (Resolved)" href="https://redmine.gc.cuny.edu/issues/3853#note-6">#3853-6</a>:</p>
<blockquote>
<p>About Co-Authors Plus, do we want to do something to support multiple authors? Create a new activity stream item for each author?</p>
</blockquote>
<blockquote>
<p>I'd say this is not worth the effort for our purposes. Though this suggestion, and others on this tracker and elsewhere (<a class="issue tracker-15 status-5 priority-4 priority-default closed" title="Design/UX: Create ability to repost forums posts to other forums (Resolved)" href="https://redmine.gc.cuny.edu/issues/3178">#3178</a>), make me wonder whether BP's activity table should have an 'alias_of' column or something like that, which we could use instead of 'hide_sitewide' for hiding near-dupes. Hmmmmm....</p>
</blockquote>
<p>Currently, it's only being used on three sites so it's not widely used across the Commons. I've marked the status of this ticket to "Hold", but feel free to close.</p> CUNY Academic Commons - Bug #1856 (Resolved): .htpasswd on cdev conflicting with WP cronhttps://redmine.gc.cuny.edu/issues/18562012-04-24T18:46:13ZRaymond Hoh
<p>Since we added .htpasswd on cdev, I've noticed that Reply By Email has stopped working.</p>
<p>I believe this has something to do with how WordPress needs to use wp_remote_post() to ping the site and spawn cron. Since wp_remote_post() cannot access the site without authentication, I'll probably have to write a small override filter to bypass the arguments in wp_remote_post().</p>
<p>Boone: I've added you as a watcher. Feel free to unwatch!</p>