CUNY Graduate Center - Project Tracking System: Issueshttps://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2024-03-11T22:29:12ZCUNY Graduate Center - Project Tracking System
Redmine CUNY Academic Commons - Bug #19944 (New): Dealing with BuddyPress 12.x upgrade, pt. 2https://redmine.gc.cuny.edu/issues/199442024-03-11T22:29:12ZRaymond Hoh
<p>Follow-up to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Dealing with BuddyPress 12.x upgrade (Resolved)" href="https://redmine.gc.cuny.edu/issues/19493">#19493</a>. Just wanted to make sure my comments in <a class="external" href="https://redmine.gc.cuny.edu/issues/19493#note-10">https://redmine.gc.cuny.edu/issues/19493#note-10</a> are brought forward to a future release:</p>
<blockquote>
<p>For more pronounced changes, I created a new branch -- <a href="https://github.com/cuny-academic-commons/cac/compare/bp12...bp12-part2" class="external">bp12-part2</a> -- that namely switches out all BuddyPress 12 deprecated function calls. We can roll that out in a later maintenance release.</p>
<p>I've been testing <code>bp12-part2</code> with BP Classic <em>deactivated</em> and with <code>BP_IGNORE_DEPRECATED</code> set to <code>true</code> and these are some issues I encountered:</p>
<ul>
<li>BP Event Organiser needs some minor adjustments to account for group subnav registration: <a class="external" href="https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d">https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d</a></li>
<li>bbPress does <a href="https://github.com/bbpress/bbPress/blob/4178cbf665674c128c928fabdc0322badacad06b/src/includes/extend/buddypress/groups.php#L140-L157" class="external">some conditional checks</a> that needs to be delayed to the <code>'bp_parse_query'</code> hook. This fixes an issue with the bbPress stylesheet not loading on group forum pages I mentioned above in <a href="https://redmine.gc.cuny.edu/issues/19493#note-4" class="external">comment 4</a> amongst other permission-related cap overrides for the current user.</li>
<li>I need Git permissions to the <code>tapor-client</code> repo so I can push changes and pin a new version for our <code>cac</code> repo.</li>
</ul>
<p>About the bbPress load order issue:</p>
<blockquote>
<p>Furthermore, when running bp-classic, I had to do some additional work to ensure that bbPress's BP compatibility layer is loaded in time, and is loaded only once. Like the approach above, it's pretty hacky (requiring a static variable to prevent double-loading) but it basically works. Here's the full patch: <a class="external" href="https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0">https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0</a></p>
</blockquote>
<p>I tackled this a little differently in my bbPress commit. See <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039">https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039</a> and the constructor and includes() portion of <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a">https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a</a> . I think the constructor changes might fix your double load order issue. Can you do some tests and see if this works for you, Boone?</p>
</blockquote>
<p>This doesn't need to go in tomorrow's 2.3.4 release. Let's put this in 2.3.5 or later.</p> CUNY Academic Commons - Bug #19928 (New): Forum Topic by Email Statshttps://redmine.gc.cuny.edu/issues/199282024-03-08T17:41:09ZRaymond Hoh
<p>Matt wanted to know the number of topics created by email vs. total number of topics.</p>
<p>Here are the stats:</p>
<p>2024 - 192/515 (so far)<br />2023 - 964/3260<br />2022 - 1058/3272<br />2021 - 1333/4010<br />2020 - 1284/4225<br />2019 - 801/2604<br />2018 - 405/2868<br />2017 - 104/1540<br />2016 - 116/1430<br />2015 - 65/1414<br />2014 - 12/1305</p> CUNY Academic Commons - Feature #19278 (Resolved): "Account Settings > Edit Profile" screen and "...https://redmine.gc.cuny.edu/issues/192782023-11-15T22:33:22ZRaymond Hoh
<p>I decided to create a new ticket from <a class="issue tracker-2 status-5 priority-4 priority-default closed child" title="Feature: Account Settings Tab (Resolved)" href="https://redmine.gc.cuny.edu/issues/17769">#17769</a>.</p>
<p>Here are Sara's mockups for the "Account Settings > Edit Profile" screen:</p>
<p><img src="https://redmine.gc.cuny.edu/attachments/download/26231/Screen%20Shot%202023-09-05%20at%2011.27.19%20AM.png" alt="" /></p>
<p><img src="https://redmine.gc.cuny.edu/attachments/download/26841/Screenshot%202023-11-14%20at%2011.58.16%20AM.png" alt="" /></p>
<hr />
<p>There was a bit of talk in the dev chat about keeping the CV data and the Commons Profile header data separate. I'm wondering whether we can just use the CV's data as the main source of data. By that I mean, if a user has filled in their CV's name, pronouns, one-line bio, social links, etc, we will display that same data in the Commons Profile header and we will not show the "Account Settings > Edit Profile" screen at all. I've already got some code for this ready to go. The code uses the <code>parse_blocks()</code> function and thanks to the placeholders in those blocks, it is possible to extract data for specific blocks from the CV.</p>
<p>If a user has not filled in their CV, for the header, we will fall back to the data that the user inputted previously during account signup or for their Public Portfolio. For these users, the "Account Settings > Edit Profile" screen will be available so that data can be edited.</p>
<p>I think this would limit the confusion of having two separate pieces of profile data. On the contrary, would users be surprised to see some of their CV data in their Commons Profile header? What does everyone think?</p> CUNY Academic Commons - Bug #18622 (Resolved): Unread forum reply notification URL links to the w...https://redmine.gc.cuny.edu/issues/186222023-08-17T23:18:53ZRaymond Hoh
<p>While working on the new notifications page (<a class="issue tracker-2 status-5 priority-4 priority-default closed child" title="Feature: Account Settings Tab (Resolved)" href="https://redmine.gc.cuny.edu/issues/17769">#17769</a>). I encountered a bug with unread forum replies.</p>
<p>In <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Forum design improvements (Resolved)" href="https://redmine.gc.cuny.edu/issues/14018">#14018</a>, we implemented an unread forum post feature utilizing the existing BuddyPress notification system. Clicking on the notification link would take you to the first unread post in a forum thread. However, this link doesn't work correctly in bbPress v2.6.7 as v2.6.7 changed how their notification action is saved from<br /><code>'bbp_new_reply'</code> to <code>'bbp_new_reply_{TOPIC_ID}</code>. (See <a class="external" href="https://github.com/bbpress/bbPress/commit/6278a1053d69d1df684b66296147b3b67f4c9966">https://github.com/bbpress/bbPress/commit/6278a1053d69d1df684b66296147b3b67f4c9966</a> .) As a result, the link would take you to the wrong post in the thread.</p>
<p>Some adjustments need to be made to fix this. Fix forthcoming.</p> CUNY Academic Commons - Bug #18495 (Resolved): bp-nelo Accessibility Fixeshttps://redmine.gc.cuny.edu/issues/184952023-07-20T23:06:53ZRaymond Hoh
<p>Previously we did a few accessibility fixes for the homepage in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Homepage accessibility enhancements (Resolved)" href="https://redmine.gc.cuny.edu/issues/15127">#15127</a>. I'm going to do another accessibility audit across our main directory and registration pages using the WAVE acessibility tool: <a class="external" href="https://wave.webaim.org/">https://wave.webaim.org/</a></p>
<p>We have a few things to fix up.</p> CUNY Academic Commons - Bug #18118 (Resolved): Two Factor v0.8 breaks our BP Two Factor frontend ...https://redmine.gc.cuny.edu/issues/181182023-04-26T04:45:08ZRaymond Hoh
<p>I <a href="https://github.com/r-a-y/bp-two-factor/issues/1" class="external">received a report</a> that our BP Two Factor plugin is broken due to changes in the latest, major version of the core Two Factor plugin -- v0.8.0. In v0.8.0, the Two Factor plugin switched to using the WP REST API to do various save routines and removed some previous code that our BP Two Factor plugin was referencing.</p>
<p>What this means is if you go to <code>/members/USERNAME/settings/</code>, you will get a fatal error. I have <a href="https://github.com/r-a-y/bp-two-factor/compare/5b751d0...5b9a8de" class="external">committed some fixes</a> in my repo and have added them to production without committing so the user settings page will still be functioning. However, there are still some usability things I want to sort out before committing such as ensuring the TOTP checkbox is checked after successful TOTP setup and ensuring some of our custom verbiage is used. I'm looking into this.</p> CUNY Academic Commons - Bug #17126 (Resolved): Removing or deprecating activity favoriting featurehttps://redmine.gc.cuny.edu/issues/171262022-10-31T23:45:55ZRaymond Hoh
<p><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Fix activity favoriting and bulk-deleting private message threads (Resolved)" href="https://redmine.gc.cuny.edu/issues/17050">#17050</a> outlined how the activity favoriting feature has not worked for the past five years.</p>
<p>To remind everyone how the activity favorite feature works, you can click on the "Favorite" link in the activity stream to favorite an item. See attached GIF. On the Commons, the places where you can favorite an activity item would be on the current News page or on any user's Commons Profile Activity page. To find out which activity items you have favorited in the past, you can visit your Commons Profile's "Activity > Favorites" page.</p>
<hr />
<p>On a previous dev call, we mentioned removing the activity favoriting feature due to limited usage.</p>
<p>I ran some numbers with the following database query before the fix in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Fix activity favoriting and bulk-deleting private message threads (Resolved)" href="https://redmine.gc.cuny.edu/issues/17050">#17050</a> was deployed:</p>
<pre>
select user_id,meta_value from wp_usermeta where meta_key = 'bp_favorite_activities' and meta_value != 'a:0:{}' and meta_value > '' order by char_length(meta_value) desc;
</pre>
And found that between when the activity favoriting feature was introduced in 2010 until when it stopped working in 2017:
<ul>
<li>305 users favorited 1+ items</li>
<li>83 users favorited 2+ items</li>
<li>42 users favorited 3+ items</li>
<li>24 users favorited 4+ items</li>
<li>21 users favorited 5+ items</li>
<li>7 users favorited 8+ items</li>
<li>4 users favorited 20+ items</li>
<li>1 user favorited 60+ items</li>
</ul>
<p>I ran the same DB query just now and one new user favorited something over the past week. Take that as you will.</p>
<p>To remove the activity favoriting feature, we can remove the Favorite button from the activity stream. Should we also remove the "Activity > Favorites" page from a user's Commons Profile altogether? Or keep it for the 306 users that have favorited something?</p>
<p>Another alternative is leaving the activity favoriting feature alone and perhaps re-introducing it with some documentation and better repositioning. For example, we can add a "Favorites" tab to the redesigned Activity page (<a class="issue tracker-15 status-5 priority-4 priority-default closed" title="Design/UX: News Page Re-Skin (Resolved)" href="https://redmine.gc.cuny.edu/issues/16535">#16535</a>) and perhaps renaming the tab to something more palatable like "Bookmarks"?</p> CUNY Academic Commons - Bug #17050 (Resolved): Fix activity favoriting and bulk-deleting private ...https://redmine.gc.cuny.edu/issues/170502022-10-17T20:01:55ZRaymond Hoh
<p>So I was testing the activity favoriting feature on the current News page and on a user profile's Activity page, and it appears that this feature has been broken for quite some time.</p>
<p>Awhile ago, the older bp-default theme added some security nonce protections when favoriting or unfavoriting an activity item: <a class="external" href="https://github.com/buddypress/BP-Default/commit/151005117e9948e1fc6748f7c618d0f0845538b6#diff-6e0730515a036b567ef8d69beee278d6167d6c99997824a0d31e784fd212b5cb">https://github.com/buddypress/BP-Default/commit/151005117e9948e1fc6748f7c618d0f0845538b6#diff-6e0730515a036b567ef8d69beee278d6167d6c99997824a0d31e784fd212b5cb</a>. However, we did not port the javascript portion of this code to our bp-nelo theme, meaning that activity favoriting (as well as bulk-deleting private message threads) has not worked for five years (!). Looks like no one really missed this feature as we didn't receive a bug report about it...</p>
<p>Fix coming shortly.</p> CUNY Academic Commons - Bug #15408 (Resolved): Pagination broken on Sites Directoryhttps://redmine.gc.cuny.edu/issues/154082022-02-22T17:40:54ZRaymond Hoh
<p>See <a class="external" href="https://buddypress.trac.wordpress.org/ticket/8633">https://buddypress.trac.wordpress.org/ticket/8633</a>.</p>
<p>During the refactoring of BP_Blogs_Blog::get() to use an array as a function argument, this broke pagination due to the parameters not being the same.</p>
<p>I'll add the patch as a hotfix.</p> CUNY Academic Commons - Design/UX #15369 (Resolved): "Add Site Icon" overlay on Sites Directory ...https://redmine.gc.cuny.edu/issues/153692022-02-16T22:09:36ZRaymond Hoh
<p>I was thinking of an easy way to encourage site owners to add a new site icon.</p>
<p>What about adding an "Add Site Icon" overlay on the Sites Directory page for sites without a custom site icon? This overlay would only show if the current user is an administrator for the site and if the site is not connected to a group. Clicking on this icon would link directly to the site's Customizer's page to add the icon: <code>/wp-admin/customize.php?autofocus[section=title_tagline</code></p>
<p>Here's a quick mockup:</p>
<p><img src="https://i.postimg.cc/vBWcc3pp/2022-02-16-140516.png" alt="" /></p>
<p>I think this could easily go into a maintenance release. What does everyone think?</p> CUNY Academic Commons - Bug #15127 (Resolved): Homepage accessibility enhancementshttps://redmine.gc.cuny.edu/issues/151272022-01-04T02:29:15ZRaymond Hoh
<p>Matt noted in a forum post about whether the new homepage is WCAG 2.1 compatible.</p>
<p>I just did an accessibility audit and found a couple of issues:</p>
<ol>
<li>On desktop, it is not possible to use keyboard navigation to view the main nav's nested menu items. (Try using the <code>Tab</code> key to navigate under the "About" item for the main nav.)</li>
<li>We are missing some <code>role</code> and <code>aria</code> attributes for our HTML markup to make things visually and structurally better for screen readers.</li>
</ol>
<p>I've pushed some updates to a new <code>homepage-accessibility</code> branch to address these issues. (See <a class="external" href="https://github.com/cuny-academic-commons/cac/compare/3b4f0a3...1a5c9a0.">https://github.com/cuny-academic-commons/cac/compare/3b4f0a3...1a5c9a0.</a>) I've slated this for the next 1.19.1 maintenance release.</p>
<p>Other than the WP admin bar, which has some <code>tabindex</code> issues that are out of our control, we are WCAG 2.1 compatible after these changes.</p>
<p>We could do a few things better with CSS to better outline when an element is in focus, but that's not imperative.</p> NYCDH Community Site - Maintenance #13614 (Duplicate): New version of Avadahttps://redmine.gc.cuny.edu/issues/136142020-11-24T01:40:09ZRaymond Hoh
<p>The DHWeek site on NYCDH is currently running Avada 6.1. The latest version is 7.1.</p>
<p>Just wanted to know if we have access to the latest version. If so, can someone provide me with the latest version of the theme? The theme also requires the Avada Core and Avada Builder plugins, which should come bundled with the theme or in a separate download.</p>
<p>Before upgrading, here's a list of major changes from Avada 6.2 and up:<br /><a class="external" href="https://theme-fusion.com/documentation/avada/installation-maintenance/important-update-information-archive/">https://theme-fusion.com/documentation/avada/installation-maintenance/important-update-information-archive/</a></p>
<p>This might be useful just in case anything breaks (layout-wise) and will require some attention.</p>
<p>Could hold off the upgrade until closer to DHWeek as well.</p> CUNY Academic Commons - Feature #13000 (Resolved): New accessible email subscriptions panelhttps://redmine.gc.cuny.edu/issues/130002020-06-29T23:54:13ZRaymond Hoh
<p>I was working on the subscriptions panel for the main Group Email Subscription plugin and thought it would be a nice enhancement for 1.17.</p>
<p>To summarize, the main changes are:<br />- Subscriptions panel is now accessible via keyboard and the options can be navigated by tabbing through each option. The older panel could only be accessed via a mouse click or touchscreen tap.<br />- New minimal styling.</p>
<p>Here's a GIF of the new subscriptions panel in action when navigating by keyboard:</p>
<p><img src="https://user-images.githubusercontent.com/505921/85660412-1e27b800-b6a5-11ea-9c64-34bf3a472c2b.gif" alt="" /></p>
<p>Boone, just a FYI that I'm going to add the <code>4.0.x</code> branch of the Group Email Subscription plugin to <code>1.17.x</code> branch. This means we will roll in whatever other fixes and enhancements we have for GES 4.0.x to the Commons. Let me know what you think before I merge it in. Or we can bump to another release.</p> NYCDH Community Site - Maintenance #12827 (Resolved): Events Calendar Pro and Filter Bar plugin u...https://redmine.gc.cuny.edu/issues/128272020-05-19T16:56:23ZRaymond Hoh
<p>Hi Jesse,</p>
<p>I just upgraded the regular Events Calendar plugin due to my regular updates and now the The Events Calendar is asking to update its Pro plugin to 5.1.0+ and the Filter Bar plugin to 4.10.0+ in the dashboard.</p>
<p>Can you provide the ZIP files for these plugins to me? Also, for future updates, would you prefer I hold off from updating Events Calendar until a later date or to continue asking for the latest versions as needed?</p>
<p>Thanks!</p> NYCDH Community Site - Bug #11013 (Resolved): Convert subdomain install to subdirectory installhttps://redmine.gc.cuny.edu/issues/110132019-01-25T03:02:01ZRaymond Hoh
<p>NYCDH does not have a wildcard SSL certificate, so we cannot enforce HTTPS across the entire NYCDH multisite install due to our multisite configuration using a subdomain set up.</p>
<p>Converting our multisite install from a subdomain configuration to a subdirectory one would allow us to enforce HTTPS.</p>
<p>I'll look into making this conversion some time after DH Week is completed so we won't disrupt anything.</p>