CUNY Graduate Center - Project Tracking System: Issueshttps://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2024-03-11T22:29:12ZCUNY Graduate Center - Project Tracking System
Redmine CUNY Academic Commons - Bug #19944 (New): Dealing with BuddyPress 12.x upgrade, pt. 2https://redmine.gc.cuny.edu/issues/199442024-03-11T22:29:12ZRaymond Hoh
<p>Follow-up to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Dealing with BuddyPress 12.x upgrade (Resolved)" href="https://redmine.gc.cuny.edu/issues/19493">#19493</a>. Just wanted to make sure my comments in <a class="external" href="https://redmine.gc.cuny.edu/issues/19493#note-10">https://redmine.gc.cuny.edu/issues/19493#note-10</a> are brought forward to a future release:</p>
<blockquote>
<p>For more pronounced changes, I created a new branch -- <a href="https://github.com/cuny-academic-commons/cac/compare/bp12...bp12-part2" class="external">bp12-part2</a> -- that namely switches out all BuddyPress 12 deprecated function calls. We can roll that out in a later maintenance release.</p>
<p>I've been testing <code>bp12-part2</code> with BP Classic <em>deactivated</em> and with <code>BP_IGNORE_DEPRECATED</code> set to <code>true</code> and these are some issues I encountered:</p>
<ul>
<li>BP Event Organiser needs some minor adjustments to account for group subnav registration: <a class="external" href="https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d">https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d</a></li>
<li>bbPress does <a href="https://github.com/bbpress/bbPress/blob/4178cbf665674c128c928fabdc0322badacad06b/src/includes/extend/buddypress/groups.php#L140-L157" class="external">some conditional checks</a> that needs to be delayed to the <code>'bp_parse_query'</code> hook. This fixes an issue with the bbPress stylesheet not loading on group forum pages I mentioned above in <a href="https://redmine.gc.cuny.edu/issues/19493#note-4" class="external">comment 4</a> amongst other permission-related cap overrides for the current user.</li>
<li>I need Git permissions to the <code>tapor-client</code> repo so I can push changes and pin a new version for our <code>cac</code> repo.</li>
</ul>
<p>About the bbPress load order issue:</p>
<blockquote>
<p>Furthermore, when running bp-classic, I had to do some additional work to ensure that bbPress's BP compatibility layer is loaded in time, and is loaded only once. Like the approach above, it's pretty hacky (requiring a static variable to prevent double-loading) but it basically works. Here's the full patch: <a class="external" href="https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0">https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0</a></p>
</blockquote>
<p>I tackled this a little differently in my bbPress commit. See <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039">https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039</a> and the constructor and includes() portion of <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a">https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a</a> . I think the constructor changes might fix your double load order issue. Can you do some tests and see if this works for you, Boone?</p>
</blockquote>
<p>This doesn't need to go in tomorrow's 2.3.4 release. Let's put this in 2.3.5 or later.</p> CUNY Academic Commons - Bug #19436 (Resolved): Doc nav displays twice on a group doc pagehttps://redmine.gc.cuny.edu/issues/194362023-12-19T03:00:06ZRaymond Hoh
<p>Came across a bug while looking into <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Audit usage of custom en_CAC locale (Resolved)" href="https://redmine.gc.cuny.edu/issues/19415">#19415</a> where the doc nav was displaying directly below the main navigation, but before the main group interface. Here's an example doc on production with this problem: <a class="external" href="https://commons.gc.cuny.edu/groups/bikecuny/docs/bike-shops/">https://commons.gc.cuny.edu/groups/bikecuny/docs/bike-shops/</a> .</p>
<p>Bug is due to using <code>bp_buffer_template_part()</code> without setting the <code>$echo</code> parameter to <code>false</code> in BuddyPress Docs: <a class="external" href="https://github.com/buddypress/buddypress/blob/39bba862906314d48eeea11ffc127fc8b8fff8c0/src/bp-core/bp-core-template-loader.php#L401">https://github.com/buddypress/buddypress/blob/39bba862906314d48eeea11ffc127fc8b8fff8c0/src/bp-core/bp-core-template-loader.php#L401</a></p>
<p>I've opened a PR for BP Docs here: <a class="external" href="https://github.com/boonebgorges/buddypress-docs/pull/740">https://github.com/boonebgorges/buddypress-docs/pull/740</a>.</p>
<p>Boone, can you review when you have the chance?</p> CUNY Academic Commons - Bug #19204 (Resolved): Github 'cac' repo access rightshttps://redmine.gc.cuny.edu/issues/192042023-11-03T18:51:46ZRaymond Hoh
<p>I'm about to push a fix for <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: New AI Assistant? (Resolved)" href="https://redmine.gc.cuny.edu/issues/19192">#19192</a>, but it seems like my access to <code>cuny-academic-commons/cac/</code> Github repo has been removed.</p>
<p>Boone, can you check my permission access to the <code>cac</code> Github repo?</p> CUNY Academic Commons - System Upgrade #19144 (Resolved): Set 'bp-nelo' as template in developer ...https://redmine.gc.cuny.edu/issues/191442023-10-30T22:37:07ZRaymond Hoh
<p>This is just a message for Boone and Jeremy.</p>
<p>If you are running the latest version of <code>2.2.x</code> branch in your development environment, please make sure to set your <code>'template'</code> option to <code>'bp-nelo'</code>. Can do so with WP-CLI:</p>
<pre>
wp option update template bp-nelo
</pre>
<p>Previously, <code>'bp-nelo'</code> was a child theme of the <code>'bp-default'</code> theme, but in <code>2.2.x</code>, bp-nelo is now its own theme, so the template is now <code>'bp-nelo'</code>. I previously enforced the <code>'template'</code> option to <code>'bp-nelo'</code> with a filter, but that filter is now removed as of <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/2582798911a1e990c07fe7194132438c08b696ee">https://github.com/cuny-academic-commons/cac/commit/2582798911a1e990c07fe7194132438c08b696ee</a> .</p>
<p>So this is a just a FYI.</p> CUNY Academic Commons - Bug #18496 (New): PHP 8+ Compatibilityhttps://redmine.gc.cuny.edu/issues/184962023-07-21T22:45:40ZRaymond Hoh
<p>We're currently running PHP 7.4 in our PHPCS set up and on the GC server, but some of us are using PHP 8+ in our development environments. (For example, <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: bp-email-type doesn't properly deal with 'to' arrays (Resolved)" href="https://redmine.gc.cuny.edu/issues/16948">#16948</a>.)</p>
<p>This will be a catch-all ticket to address deprecated notices, fatal errors and the like.</p>
<p>Also, just to note that PHP 7.4 reached end-of-life back in November 2022. Upgrading to PHP 8.2 is probably good to think about when we decide to move hosts. PHP 8.2 is supported until December 2025, while PHP 8.0 will reach end-of-life in November 2023.</p> CUNY Academic Commons - Support #18128 (Resolved): Question about Jetpack on news.commons.gc.cuny...https://redmine.gc.cuny.edu/issues/181282023-04-27T17:04:08ZRaymond Hoh
<p>I was looking at our Cavalcade logs for failed scheduled tasks and most of the recent, failed tasks come from the Jetpack plugin on <code>news.commons.gc.cuny.edu</code>. In an attempt to fix this, I have reset all Jetpack options on <code>news.commons.gc.cuny.edu</code>.</p>
<p>I'm adding Scott and Colin as watchers to this ticket. Do we use Jetpack extensively on <code>news.commons.gc.cuny.edu</code>? If so, can either one of you re-enable and reconfigure the Jetpack modules that were being used on the site? Here's a direct link to the Jetpack modules page: <a class="external" href="https://news.commons.gc.cuny.edu/wp-admin/admin.php?page=jetpack_modules">https://news.commons.gc.cuny.edu/wp-admin/admin.php?page=jetpack_modules</a> .</p>
<p>If Jetpack is not vital for <code>news.commons.gc.cuny.edu</code>, it maybe worthwhile to disable the Jetpack plugin entirely.</p> CUNY Academic Commons - Bug #17651 (Resolved): Remove ability to create Docs for Usershttps://redmine.gc.cuny.edu/issues/176512023-02-10T18:48:01ZRaymond Hoh
<p>Luke stumbled upon this issue on the call today.</p>
<p>If you are logged in and hover over the admin bar sticky menu on the top-right corner, the "My Docs > Create New Doc" menu item is available. If clicked, this allows users to create new docs, however we only want to allow doc creation through an individual group.</p>
<p>Let's remove this menu item.</p> CUNY Academic Commons - Bug #17578 (Resolved): Deactivate Advanced Post Cache pluginhttps://redmine.gc.cuny.edu/issues/175782023-01-27T21:19:37ZRaymond Hoh
<p>According to <a href="https://github.com/Automattic/advanced-post-cache/issues/28" class="external">this Github issue</a>, WordPress 6.1 already has some improvements to deal with caching post IDs that might make the Advanced Post Cache plugin redundant.</p>
<p>The Advanced Post Cache plugin has some oddities that we've run up against with <a href="https://redmine.gc.cuny.edu/issues/13341#note-11" class="external">bbPress</a>, our <a href="https://redmine.gc.cuny.edu/issues/14457#note-21" class="external">cac_course</a> post type and most recently, <a href="https://redmine.gc.cuny.edu/issues/17551#note-2" class="external">Event Organiser</a>. So it's an opportune time to look at retiring it.</p> CUNY Academic Commons - Bug #16351 (Resolved): No new Redmine emails since Sunday?https://redmine.gc.cuny.edu/issues/163512022-07-12T04:27:42ZRaymond Hoh
<p>Has anyone received any new emails from Redmine since the new Redmine update was deployed during the maintenance window on Sunday?</p>
<p>I just manually checked Redmine to find some new comments, but I did not receive the emails to those comments like I usually do.</p> CUNY Academic Commons - Bug #15408 (Resolved): Pagination broken on Sites Directoryhttps://redmine.gc.cuny.edu/issues/154082022-02-22T17:40:54ZRaymond Hoh
<p>See <a class="external" href="https://buddypress.trac.wordpress.org/ticket/8633">https://buddypress.trac.wordpress.org/ticket/8633</a>.</p>
<p>During the refactoring of BP_Blogs_Blog::get() to use an array as a function argument, this broke pagination due to the parameters not being the same.</p>
<p>I'll add the patch as a hotfix.</p> CUNY Academic Commons - Bug #13966 (Resolved): Replying by email to a trashed or spammed forum to...https://redmine.gc.cuny.edu/issues/139662021-02-09T19:05:35ZRaymond Hoh
<p>So on the dev call, I thought that there was a timeout issue when parsing the RBE inbox check.</p>
<p>Turns out the problem was simpler than that! A user was replying to a trashed forum topic and that caused a fatal error due to the way RBE handles replies when a forum topic was trashed or marked as spammed.</p>
<p>Full details here: <a class="external" href="https://github.com/r-a-y/bp-reply-by-email/issues/125">https://github.com/r-a-y/bp-reply-by-email/issues/125</a></p>
<p>I initially copied the reply logic from bbPress and they also recently addressed the issue in bbPress 2.6.5: <a class="external" href="https://bbpress.trac.wordpress.org/ticket/3409">https://bbpress.trac.wordpress.org/ticket/3409</a></p> CUNY Academic Commons - Bug #12551 (Resolved): Preparing for PHP 7.4https://redmine.gc.cuny.edu/issues/125512020-03-16T22:28:26ZRaymond Hoh
<p>Previously: <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: PHP 7.2 Incompatibility Problems (Resolved)" href="https://redmine.gc.cuny.edu/issues/10564">#10564</a> for PHP 7.2.</p>
<p>This is a master ticket to gather fixes related to PHP 7.4, which will be applied to the production server in a few months from now.</p> CUNY Academic Commons - Bug #7825 (Rejected): WP Cron fails to spawn on productionhttps://redmine.gc.cuny.edu/issues/78252017-03-22T17:31:27ZRaymond Hoh
<p>I was checking to see if a scheduled task that I added to WP cron was there or not and it appears that WP cron doesn't appear to be working.</p>
<p>I used the following wp-cli command to see if WP cron was functioning correctly:<br /><code>wp cron test</code></p>
<p>And that throws back the following error:</p>
<p><code>Error: WP-Cron spawn failed with error: cURL error 28: Operation timed out after 3001 milliseconds with 0 out<br />of -1 bytes received</code></p>
<p>I then checked the cron schedule with:</p>
<p><code>wp cron event list</code></p>
<p>And there are a bunch of older cron events dating as far back as March 7th that haven't run. This might be the cause of other issues such as #7346. Also, I'm guessing that no one has received a daily digest since March 7th.</p>
<p>I did some brief research to see what might be causing the problem and a Github user notes that <code>commons.gc.cuny.edu</code> might not be in the HOSTS file during the cURL lookup:<br /><a class="external" href="https://github.com/Automattic/vip-quickstart/issues/421#issuecomment-91355870">https://github.com/Automattic/vip-quickstart/issues/421#issuecomment-91355870</a></p>
<p>We'd have to confirm with Lihua if that is the case or not.</p>
<p>I also just tested WP cron on the development server and it appears to be working there though.</p> CUNY Academic Commons - Bug #5313 (Resolved): Migrate over to BuddyPress 2.5 Emailshttps://redmine.gc.cuny.edu/issues/53132016-03-10T15:08:48ZRaymond Hoh
<p>Since we're scheduled to roll BuddyPress 2.5 onto the Commons on the 21st, we need to decide whether we want to keep using our existing email system (a hodgepodge of various email plugins - WP Better Emails, WP Better Emails for BuddyPress, BP Group Email Subscription, etc.) or migrate over to BuddyPress 2.5's email system.</p>
<p>For the 1.9.x milestone, we should probably just continue to use what we currently have.</p>
<p>Sometime down the road (probably the 2.0 milestone), we should migrate over to BP's email system.</p>
<p>Migrating over to BuddyPress 2.5 presents a few things that we'll need to address.</p>
<p>Here are the notables (these notes are mostly for Boone to glean over.):</p>
<ul>
<li>Making modifications to BP Group Email Subscription (GES) to support BP 2.5's email system. (I recently did something similar for the Genchem platform, so I'm a little familiar with this.). Should we also use BP's email system for GES digests?</li>
<li>Making modifications to Reply By Email to support BP 2.5's email system. (Work is pretty much completed here.)</li>
<li>Ensuring that HTML content in emails shows up (blockquotes, bold, italics, links, etc). I'm mostly only concerned with group forum emails here. If time permits, I'll also work on activity updates and private messages (these will require BP core changes).</li>
<li>Ensuring that HTML content in plain-text emails degrades well for accessibility reasons (converting over links, text emphasis, etc.)</li>
<li>Ensuring that the HTML email option under a user's "Settings > Email" page is respected. (This is a feature of the WP Better Emails for BuddyPress plugin.) Will need to do some research here.</li>
<li>Deactivate and remove WP Better Emails for BuddyPress.</li>
<li>Deactivate WP Better Emails.</li>
<li>Investigate what needs to be done with our custom "WP Better Emails for BP Groupblog" plugin (<a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: new_groupblog_post emails not being sent as HTML (Resolved)" href="https://redmine.gc.cuny.edu/issues/3219">#3219</a>). (This might not be required after modifications to GES are made.)</li>
<li>Make a decision as to whether we should use BP's default email template or use the same template we use with WP Better Emails. If we use the default BP template, we should remove the "unsubscribe" link located in the email footer.</li>
</ul>
<p>I'm probably forgetting some things, but these are the main items.</p>
<p>Placing this in the 2.0 milestone for now.</p> CUNY Academic Commons - Bug #3546 (Resolved): My Commons - New user sees all site activity for "E...https://redmine.gc.cuny.edu/issues/35462014-10-10T18:29:55ZRaymond Hoh
<p>When a new user joins the site, this user has not joined any groups, followed any sites or created any friendships.</p>
<p>Currently, on the "My Commons" page, this user sees the "Everything" and "My Sites" tabs. If the user clicks on one of these tabs, they see all site activity instead of nothing.</p>
<p>I'm going to fix this so no activity is shown and will override the default empty message to state something like:</p>
<p>"It looks like you're new here. To see some activity here, join a group (link to groups directory) , add a friend (link to members directory) or follow a site (link to sites directory)."</p>
<p>Let me know what you think.</p>