CUNY Graduate Center - Project Tracking System: Issueshttps://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2024-03-11T22:29:12ZCUNY Graduate Center - Project Tracking System
Redmine CUNY Academic Commons - Bug #19944 (New): Dealing with BuddyPress 12.x upgrade, pt. 2https://redmine.gc.cuny.edu/issues/199442024-03-11T22:29:12ZRaymond Hoh
<p>Follow-up to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Dealing with BuddyPress 12.x upgrade (Resolved)" href="https://redmine.gc.cuny.edu/issues/19493">#19493</a>. Just wanted to make sure my comments in <a class="external" href="https://redmine.gc.cuny.edu/issues/19493#note-10">https://redmine.gc.cuny.edu/issues/19493#note-10</a> are brought forward to a future release:</p>
<blockquote>
<p>For more pronounced changes, I created a new branch -- <a href="https://github.com/cuny-academic-commons/cac/compare/bp12...bp12-part2" class="external">bp12-part2</a> -- that namely switches out all BuddyPress 12 deprecated function calls. We can roll that out in a later maintenance release.</p>
<p>I've been testing <code>bp12-part2</code> with BP Classic <em>deactivated</em> and with <code>BP_IGNORE_DEPRECATED</code> set to <code>true</code> and these are some issues I encountered:</p>
<ul>
<li>BP Event Organiser needs some minor adjustments to account for group subnav registration: <a class="external" href="https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d">https://github.com/cuny-academic-commons/bp-event-organiser/compare/1.2.x...bp12#diff-b0397cc71e95a79af968e8dadb7b8e525085f462c5a88ac11c8bdb86ecd7173d</a></li>
<li>bbPress does <a href="https://github.com/bbpress/bbPress/blob/4178cbf665674c128c928fabdc0322badacad06b/src/includes/extend/buddypress/groups.php#L140-L157" class="external">some conditional checks</a> that needs to be delayed to the <code>'bp_parse_query'</code> hook. This fixes an issue with the bbPress stylesheet not loading on group forum pages I mentioned above in <a href="https://redmine.gc.cuny.edu/issues/19493#note-4" class="external">comment 4</a> amongst other permission-related cap overrides for the current user.</li>
<li>I need Git permissions to the <code>tapor-client</code> repo so I can push changes and pin a new version for our <code>cac</code> repo.</li>
</ul>
<p>About the bbPress load order issue:</p>
<blockquote>
<p>Furthermore, when running bp-classic, I had to do some additional work to ensure that bbPress's BP compatibility layer is loaded in time, and is loaded only once. Like the approach above, it's pretty hacky (requiring a static variable to prevent double-loading) but it basically works. Here's the full patch: <a class="external" href="https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0">https://github.com/openlab-at-city-tech/openlab/commit/27f2a68354550295d85f0f3c5aaafc55004268f0</a></p>
</blockquote>
<p>I tackled this a little differently in my bbPress commit. See <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039">https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-0f345898d2c7666be77acc95ec88e90e98a407644a4ce5431b3fb96d06749039</a> and the constructor and includes() portion of <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a">https://github.com/cuny-academic-commons/cac/commit/e2145f2462d3d2cbe2f16de914e7875c48b6e1cc#diff-a8d1ad6e40805411d0e557ee641e9d47c6cc3d0f17ef107f22ac729255439a5a</a> . I think the constructor changes might fix your double load order issue. Can you do some tests and see if this works for you, Boone?</p>
</blockquote>
<p>This doesn't need to go in tomorrow's 2.3.4 release. Let's put this in 2.3.5 or later.</p> CUNY Academic Commons - Bug #19928 (New): Forum Topic by Email Statshttps://redmine.gc.cuny.edu/issues/199282024-03-08T17:41:09ZRaymond Hoh
<p>Matt wanted to know the number of topics created by email vs. total number of topics.</p>
<p>Here are the stats:</p>
<p>2024 - 192/515 (so far)<br />2023 - 964/3260<br />2022 - 1058/3272<br />2021 - 1333/4010<br />2020 - 1284/4225<br />2019 - 801/2604<br />2018 - 405/2868<br />2017 - 104/1540<br />2016 - 116/1430<br />2015 - 65/1414<br />2014 - 12/1305</p> CUNY Academic Commons - Bug #18622 (Resolved): Unread forum reply notification URL links to the w...https://redmine.gc.cuny.edu/issues/186222023-08-17T23:18:53ZRaymond Hoh
<p>While working on the new notifications page (<a class="issue tracker-2 status-5 priority-4 priority-default closed child" title="Feature: Account Settings Tab (Resolved)" href="https://redmine.gc.cuny.edu/issues/17769">#17769</a>). I encountered a bug with unread forum replies.</p>
<p>In <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Forum design improvements (Resolved)" href="https://redmine.gc.cuny.edu/issues/14018">#14018</a>, we implemented an unread forum post feature utilizing the existing BuddyPress notification system. Clicking on the notification link would take you to the first unread post in a forum thread. However, this link doesn't work correctly in bbPress v2.6.7 as v2.6.7 changed how their notification action is saved from<br /><code>'bbp_new_reply'</code> to <code>'bbp_new_reply_{TOPIC_ID}</code>. (See <a class="external" href="https://github.com/bbpress/bbPress/commit/6278a1053d69d1df684b66296147b3b67f4c9966">https://github.com/bbpress/bbPress/commit/6278a1053d69d1df684b66296147b3b67f4c9966</a> .) As a result, the link would take you to the wrong post in the thread.</p>
<p>Some adjustments need to be made to fix this. Fix forthcoming.</p> CUNY Academic Commons - Bug #18495 (Resolved): bp-nelo Accessibility Fixeshttps://redmine.gc.cuny.edu/issues/184952023-07-20T23:06:53ZRaymond Hoh
<p>Previously we did a few accessibility fixes for the homepage in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Homepage accessibility enhancements (Resolved)" href="https://redmine.gc.cuny.edu/issues/15127">#15127</a>. I'm going to do another accessibility audit across our main directory and registration pages using the WAVE acessibility tool: <a class="external" href="https://wave.webaim.org/">https://wave.webaim.org/</a></p>
<p>We have a few things to fix up.</p> CUNY Academic Commons - Bug #18118 (Resolved): Two Factor v0.8 breaks our BP Two Factor frontend ...https://redmine.gc.cuny.edu/issues/181182023-04-26T04:45:08ZRaymond Hoh
<p>I <a href="https://github.com/r-a-y/bp-two-factor/issues/1" class="external">received a report</a> that our BP Two Factor plugin is broken due to changes in the latest, major version of the core Two Factor plugin -- v0.8.0. In v0.8.0, the Two Factor plugin switched to using the WP REST API to do various save routines and removed some previous code that our BP Two Factor plugin was referencing.</p>
<p>What this means is if you go to <code>/members/USERNAME/settings/</code>, you will get a fatal error. I have <a href="https://github.com/r-a-y/bp-two-factor/compare/5b751d0...5b9a8de" class="external">committed some fixes</a> in my repo and have added them to production without committing so the user settings page will still be functioning. However, there are still some usability things I want to sort out before committing such as ensuring the TOTP checkbox is checked after successful TOTP setup and ensuring some of our custom verbiage is used. I'm looking into this.</p> CUNY Academic Commons - Bug #17126 (Resolved): Removing or deprecating activity favoriting featurehttps://redmine.gc.cuny.edu/issues/171262022-10-31T23:45:55ZRaymond Hoh
<p><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Fix activity favoriting and bulk-deleting private message threads (Resolved)" href="https://redmine.gc.cuny.edu/issues/17050">#17050</a> outlined how the activity favoriting feature has not worked for the past five years.</p>
<p>To remind everyone how the activity favorite feature works, you can click on the "Favorite" link in the activity stream to favorite an item. See attached GIF. On the Commons, the places where you can favorite an activity item would be on the current News page or on any user's Commons Profile Activity page. To find out which activity items you have favorited in the past, you can visit your Commons Profile's "Activity > Favorites" page.</p>
<hr />
<p>On a previous dev call, we mentioned removing the activity favoriting feature due to limited usage.</p>
<p>I ran some numbers with the following database query before the fix in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Fix activity favoriting and bulk-deleting private message threads (Resolved)" href="https://redmine.gc.cuny.edu/issues/17050">#17050</a> was deployed:</p>
<pre>
select user_id,meta_value from wp_usermeta where meta_key = 'bp_favorite_activities' and meta_value != 'a:0:{}' and meta_value > '' order by char_length(meta_value) desc;
</pre>
And found that between when the activity favoriting feature was introduced in 2010 until when it stopped working in 2017:
<ul>
<li>305 users favorited 1+ items</li>
<li>83 users favorited 2+ items</li>
<li>42 users favorited 3+ items</li>
<li>24 users favorited 4+ items</li>
<li>21 users favorited 5+ items</li>
<li>7 users favorited 8+ items</li>
<li>4 users favorited 20+ items</li>
<li>1 user favorited 60+ items</li>
</ul>
<p>I ran the same DB query just now and one new user favorited something over the past week. Take that as you will.</p>
<p>To remove the activity favoriting feature, we can remove the Favorite button from the activity stream. Should we also remove the "Activity > Favorites" page from a user's Commons Profile altogether? Or keep it for the 306 users that have favorited something?</p>
<p>Another alternative is leaving the activity favoriting feature alone and perhaps re-introducing it with some documentation and better repositioning. For example, we can add a "Favorites" tab to the redesigned Activity page (<a class="issue tracker-15 status-5 priority-4 priority-default closed" title="Design/UX: News Page Re-Skin (Resolved)" href="https://redmine.gc.cuny.edu/issues/16535">#16535</a>) and perhaps renaming the tab to something more palatable like "Bookmarks"?</p> CUNY Academic Commons - Bug #17050 (Resolved): Fix activity favoriting and bulk-deleting private ...https://redmine.gc.cuny.edu/issues/170502022-10-17T20:01:55ZRaymond Hoh
<p>So I was testing the activity favoriting feature on the current News page and on a user profile's Activity page, and it appears that this feature has been broken for quite some time.</p>
<p>Awhile ago, the older bp-default theme added some security nonce protections when favoriting or unfavoriting an activity item: <a class="external" href="https://github.com/buddypress/BP-Default/commit/151005117e9948e1fc6748f7c618d0f0845538b6#diff-6e0730515a036b567ef8d69beee278d6167d6c99997824a0d31e784fd212b5cb">https://github.com/buddypress/BP-Default/commit/151005117e9948e1fc6748f7c618d0f0845538b6#diff-6e0730515a036b567ef8d69beee278d6167d6c99997824a0d31e784fd212b5cb</a>. However, we did not port the javascript portion of this code to our bp-nelo theme, meaning that activity favoriting (as well as bulk-deleting private message threads) has not worked for five years (!). Looks like no one really missed this feature as we didn't receive a bug report about it...</p>
<p>Fix coming shortly.</p> CUNY Academic Commons - Bug #15677 (Resolved): Duplicate email template posts are being created d...https://redmine.gc.cuny.edu/issues/156772022-03-19T21:16:49ZRaymond Hoh
<p>See <a class="external" href="https://redmine.gc.cuny.edu/issues/15675#note-3">https://redmine.gc.cuny.edu/issues/15675#note-3</a>.</p>
<p>Duplicate email templates are being created whenever a BuddyPress DB update is required (I'm guessing).</p>
<p>The Group Email Subscription plugin has some logic to determine whether a new email template should be created or not: <a class="external" href="https://github.com/boonebgorges/buddypress-group-email-subscription/blob/d322c0bfb053b9ee23d1e25a250717d1e506313a/admin.php#L398">https://github.com/boonebgorges/buddypress-group-email-subscription/blob/d322c0bfb053b9ee23d1e25a250717d1e506313a/admin.php#L398</a>. But judging by the other duplicate BuddyPress email templates that were also created, it's probably caused by something else.</p> CUNY Academic Commons - Bug #15408 (Resolved): Pagination broken on Sites Directoryhttps://redmine.gc.cuny.edu/issues/154082022-02-22T17:40:54ZRaymond Hoh
<p>See <a class="external" href="https://buddypress.trac.wordpress.org/ticket/8633">https://buddypress.trac.wordpress.org/ticket/8633</a>.</p>
<p>During the refactoring of BP_Blogs_Blog::get() to use an array as a function argument, this broke pagination due to the parameters not being the same.</p>
<p>I'll add the patch as a hotfix.</p> CUNY Academic Commons - Bug #15216 (Resolved): Blog posts and comments from private sites shouldn...https://redmine.gc.cuny.edu/issues/152162022-01-25T01:42:33ZRaymond Hoh
<p>Follow-up to <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Broken site image/icon (Resolved)" href="https://redmine.gc.cuny.edu/issues/15134">#15134</a> and <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Non-public site visibility change should update all related site activity visibility to hidden (Resolved)" href="https://redmine.gc.cuny.edu/issues/14223">#14223</a>.</p>
<p>If a site has set their privacy setting to either "I would like my site to be visible only to registered users of the CUNY Academic Commons", "I would like my site to be visible only to users I add to it" or "I would like my site to be visible only to its Admins", BuddyPress will record blog post and comment activity items for this site as public.</p>
<p>Fix coming shortly.</p> CUNY Academic Commons - Bug #15215 (Resolved): bbPress adds 'no-js' body CSS class, but doesn't r...https://redmine.gc.cuny.edu/issues/152152022-01-24T23:42:35ZRaymond Hoh
<p>See <a class="external" href="https://bbpress.trac.wordpress.org/ticket/3445#comment:2">https://bbpress.trac.wordpress.org/ticket/3445#comment:2</a>.</p>
<p>For us, this interferes with the "My Settings > Security" page by showing the "Generate Password" block instead of hiding by default and hiding the "Generate Recovery Codes" button instead of displaying it by default for the Two Factor Authentication section.</p>
<p>BuddyPress already addressed this in their template packs a long time ago: <a class="external" href="https://buddypress.trac.wordpress.org/ticket/4890">https://buddypress.trac.wordpress.org/ticket/4890</a>. I'll port the JS over to our bp-nelo theme to address this.</p> CUNY Academic Commons - Bug #15175 (Resolved): "Load More" button not working correctly on a user...https://redmine.gc.cuny.edu/issues/151752022-01-11T09:06:53ZRaymond Hoh
<p>While looking into <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: padding missing on Commons Profile (Resolved)" href="https://redmine.gc.cuny.edu/issues/15152">#15152</a>, I discovered that the "Load More" button was not working correctly when on a user's "Commons Profile > Activity" page. The problem is the pagination could be using the wrong page offset and the loading GIF was not showing up when clicking on the button.</p>
<p>The problem is in our bp-nelo theme, the JS selectors for the News / My Commons page and a user's "Commons Profile > Activity" page are different. We need to ensure that the selectors are the same for both pages. As for the pagination bug, we have to port the following fix over from the BuddyPress bp-legacy template pack: <a class="external" href="https://buddypress.trac.wordpress.org/changeset/12181">https://buddypress.trac.wordpress.org/changeset/12181</a>.</p>
<p>Fix coming shortly.</p> CUNY Academic Commons - Bug #15127 (Resolved): Homepage accessibility enhancementshttps://redmine.gc.cuny.edu/issues/151272022-01-04T02:29:15ZRaymond Hoh
<p>Matt noted in a forum post about whether the new homepage is WCAG 2.1 compatible.</p>
<p>I just did an accessibility audit and found a couple of issues:</p>
<ol>
<li>On desktop, it is not possible to use keyboard navigation to view the main nav's nested menu items. (Try using the <code>Tab</code> key to navigate under the "About" item for the main nav.)</li>
<li>We are missing some <code>role</code> and <code>aria</code> attributes for our HTML markup to make things visually and structurally better for screen readers.</li>
</ol>
<p>I've pushed some updates to a new <code>homepage-accessibility</code> branch to address these issues. (See <a class="external" href="https://github.com/cuny-academic-commons/cac/compare/3b4f0a3...1a5c9a0.">https://github.com/cuny-academic-commons/cac/compare/3b4f0a3...1a5c9a0.</a>) I've slated this for the next 1.19.1 maintenance release.</p>
<p>Other than the WP admin bar, which has some <code>tabindex</code> issues that are out of our control, we are WCAG 2.1 compatible after these changes.</p>
<p>We could do a few things better with CSS to better outline when an element is in focus, but that's not imperative.</p> CUNY Academic Commons - Bug #14223 (Resolved): Non-public site visibility change should update al...https://redmine.gc.cuny.edu/issues/142232021-03-23T17:23:35ZRaymond Hoh
<p>If a Commons site changes their site visibility from public to a non-public option (under "Settings > Reading" in the admin dashboard), we should update all related activity data for blog posts and comments so they are hidden sitewide as well.</p>
<p>Should also write a script to handle existing blog activity to see which ones might need to be hidden. This might take awhile to run. A quick count query for blog post activity across all subdomain sites is ~65,000. For blog comments, that number is ~39,000.</p>
<p>Related: #14209.</p> NYCDH Community Site - Bug #11013 (Resolved): Convert subdomain install to subdirectory installhttps://redmine.gc.cuny.edu/issues/110132019-01-25T03:02:01ZRaymond Hoh
<p>NYCDH does not have a wildcard SSL certificate, so we cannot enforce HTTPS across the entire NYCDH multisite install due to our multisite configuration using a subdomain set up.</p>
<p>Converting our multisite install from a subdomain configuration to a subdirectory one would allow us to enforce HTTPS.</p>
<p>I'll look into making this conversion some time after DH Week is completed so we won't disrupt anything.</p>