https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2011-11-03T02:12:09ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Bug #1316: Buddy Press Docs - comments going to email, but not to the Dochttps://redmine.gc.cuny.edu/issues/1316?journal_id=48982011-11-03T02:12:09Zscott vothscott.voth@verizon.net
<ul></ul><p>Hi - I also noticed that Sarah commented on this doc - and I got an email - but it didn't get recorded in the doc.</p> CUNY Academic Commons - Bug #1316: Buddy Press Docs - comments going to email, but not to the Dochttps://redmine.gc.cuny.edu/issues/1316?journal_id=49152011-11-04T12:04:24ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>Boone Gorges</i></li><li><strong>Target version</strong> set to <i>1.2.5</i></li></ul> CUNY Academic Commons - Bug #1316: Buddy Press Docs - comments going to email, but not to the Dochttps://redmine.gc.cuny.edu/issues/1316?journal_id=49162011-11-04T12:12:39ZBoone Gorgesboone@gorg.es
<ul></ul><p>I've done a bit of poking, and it looks like the "To view or reply..." links at the bottom of the emails, and some of the links in the activity stream, are going to the incorrect Docs. That is, the comments are appearing in the places where they're intended to appear, but you're getting the wrong links. Looking into it.</p> CUNY Academic Commons - Bug #1316: Buddy Press Docs - comments going to email, but not to the Dochttps://redmine.gc.cuny.edu/issues/1316?journal_id=49182011-11-04T14:17:08ZBoone Gorgesboone@gorg.es
<ul></ul><p>OK, I've narrowed it down a bit more. It appears to have something to do with parent and child Doc hierarchy. More specifically, parent Docs appear to be showing the comments of their youngest child.</p>
<p>I can't tell at a glance whether this bug is the fault of BuddyPress Docs or of WordPress itself - the technique I use for pulling up child docs is a technique that I've found to be buggy in WP before. I'll do some more exploration. Opened a BP Docs ticket here if anyone cares: <a class="external" href="https://github.com/boonebgorges/buddypress-docs/issues/149">https://github.com/boonebgorges/buddypress-docs/issues/149</a></p>
<p>For the moment, I have disabled the display of the "Children" display underneath a Doc content. Comments are now appearing where they ought to appear.</p> CUNY Academic Commons - Bug #1316: Buddy Press Docs - comments going to email, but not to the Dochttps://redmine.gc.cuny.edu/issues/1316?journal_id=49212011-11-04T16:37:40ZBoone Gorgesboone@gorg.es
<ul></ul><p>Fixed in BP Docs <a class="external" href="https://github.com/boonebgorges/buddypress-docs/commit/47d7f1488e3d140524be303aff8db28ccfc1834d">https://github.com/boonebgorges/buddypress-docs/commit/47d7f1488e3d140524be303aff8db28ccfc1834d</a></p> CUNY Academic Commons - Bug #1316: Buddy Press Docs - comments going to email, but not to the Dochttps://redmine.gc.cuny.edu/issues/1316?journal_id=49222011-11-04T16:53:07ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Resolved</i></li></ul><p>Fixed on the Commons in <a class="external" href="https://github.com/castiron/cac/commit/b3a14164ed0a88fd1bfe11a6dc3c1d49ae505722">https://github.com/castiron/cac/commit/b3a14164ed0a88fd1bfe11a6dc3c1d49ae505722</a></p>