https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2020-12-07T16:01:29ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=568422020-12-07T16:01:29ZBoone Gorgesboone@gorg.es
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-5 priority-high4 closed" href="/issues/13656">Bug #13656</a>: site down</i> added</li></ul> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=568442020-12-07T16:01:38ZBoone Gorgesboone@gorg.es
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-1 priority-4 priority-default" href="/issues/12573">Bug #12573</a>: CommentPress Core Issues</i> added</li></ul> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=568452020-12-07T16:02:12ZBoone Gorgesboone@gorg.es
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/56845/diff?detail_id=51530">diff</a>)</li></ul> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=571642020-12-17T16:43:22ZBoone Gorgesboone@gorg.es
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-5 priority-high4 closed" href="/issues/13715">Bug #13715</a>: https://ulysses.commons.gc.cuny.edu down</i> added</li></ul> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=571792020-12-17T20:11:36ZRaymond Hoh
<ul></ul><p>The likely scenario here is a site admin was browsing through the "Appearance > Themes" list and the admin activated one of the CommentPress themes without having the CommentPress Core plugin activated.</p>
I think we should do the following:
<ul>
<li>Network-disable the <code>commentpress-default</code> and <code>commentpress-modern</code> themes so these themes are no longer allowed to be shown in the "Appearance > Themes" screen since they only work with the <code>commentpress-core</code> plugin. (I've just done this, so no need to do it.)</li>
<li>Remove the <code>commentpress-theme</code> and <code>commentpress-modern</code> themes from <code>/wp-content/themes/</code>. WordPress only stores the theme slug in the database, not the absolute path to the theme directory, so we should be safe. (I haven't done this yet. Wanted to get some confirmation before doing this.)</li>
</ul>
<p>Sites that have either <code>commentpress-theme</code> or <code>commentpress-modern</code> should have the <code>commentpress-core</code> plugin already activated. It's not possible to activate just those themes without receiving a fatal error as evidenced in the last few tickets (<a class="issue tracker-1 status-5 priority-5 priority-high4 closed" title="Bug: https://ulysses.commons.gc.cuny.edu down (Resolved)" href="https://redmine.gc.cuny.edu/issues/13715">#13715</a>, <a class="issue tracker-1 status-5 priority-5 priority-high4 closed" title="Bug: site down (Resolved)" href="https://redmine.gc.cuny.edu/issues/13656">#13656</a>).</p>
<p>To be sure, I ran a WP-CLI command to see where both themes are active:</p>
<pre>
Sites where commentpress-modern is active:
+---------+---------------------------------------------+
| blog_id | url |
+---------+---------------------------------------------+
| 1603 | https://disswrkshpf13.commons.gc.cuny.edu/ |
| 1682 | https://cunyfemtech.commons.gc.cuny.edu/ |
| 1800 | https://sicelidas.commons.gc.cuny.edu/ |
| 1921 | https://jk82.commons.gc.cuny.edu/ |
| 2241 | https://techlitfrench.commons.gc.cuny.edu/ |
| 2273 | https://jitpcomments.commons.gc.cuny.edu/ |
| 2309 | https://fragments.commons.gc.cuny.edu/ |
| 2314 | https://techniques.commons.gc.cuny.edu/ |
| 2358 | https://wgs10016.commons.gc.cuny.edu/ |
| 2748 | https://malswrites.commons.gc.cuny.edu/ |
| 3944 | https://ivanhoetest.commons.gc.cuny.edu/ |
| 4004 | https://tristengoodwin.commons.gc.cuny.edu/ |
| 4332 | https://stefanomorello.commons.gc.cuny.edu/ |
+---------+---------------------------------------------+
</pre>
<pre>
Sites where commentpress-theme is active:
+---------+--------------------------------------------------+
| blog_id | url |
+---------+--------------------------------------------------+
| 1063 | https://promockup2.commons.gc.cuny.edu/ |
| 1271 | https://deathofthetermpaper.commons.gc.cuny.edu/ |
| 1313 | https://amstprosemsp13.commons.gc.cuny.edu/ |
| 1394 | https://thesocialpaper.commons.gc.cuny.edu/ |
| 1491 | https://librarians.commons.gc.cuny.edu/ |
| 1506 | https://eshtestcac.commons.gc.cuny.edu/ |
+---------+--------------------------------------------------+
</pre>
<p>All sites have the <code>commentpress-core</code> plugin activated. (<code>eshtestcac.commons.gc.cuny.edu</code> has another unrelated error, but that site is marked as deleted so I'm not going to spend time debugging that site.)</p>
<hr />
<p>One other thing I encountered is if a site has the <code>commentpress-core</code> plugin activated, the other bundled themes for CommentPress (<code>commentpress-theme</code> and <code>commentpress-flat</code>) are not visible under the "Appearance > Themes" screen. I've just added a commit that will allow these themes to be activated if the <code>commentpress-core</code> plugin is active: <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/1e1ef9c7da7f13b6e75574d6261280434bf018c3">https://github.com/cuny-academic-commons/cac/commit/1e1ef9c7da7f13b6e75574d6261280434bf018c3</a>. This should properly solve <a class="issue tracker-1 status-1 priority-4 priority-default" title="Bug: CommentPress Core Issues (New)" href="https://redmine.gc.cuny.edu/issues/12573">#12573</a>. I've also reported this issue to Christian (who maintains CommentPress) <a href="https://github.com/IFBook/commentpress-core/issues/89" class="external">here</a>.</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=571842020-12-17T21:19:22ZBoone Gorgesboone@gorg.es
<ul></ul><blockquote>
<p>Network-disable the commentpress-default and commentpress-modern themes so these themes are no longer allowed to be shown in the "Appearance > Themes" screen since they only work with the commentpress-core plugin. (I've just done this, so no need to do it.)</p>
</blockquote>
<p>This sounds good to me.</p>
<blockquote>
<p>Remove the commentpress-theme and commentpress-modern themes from /wp-content/themes/. WordPress only stores the theme slug in the database, not the absolute path to the theme directory, so we should be safe. (I haven't done this yet. Wanted to get some confirmation before doing this.)</p>
</blockquote>
<p>This seems right to me too. Please go ahead with this step.</p>
<p>Thanks for identifying that related upstream issue!</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=571922020-12-18T01:53:11ZRaymond Hoh
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Staged for Production Release</i></li></ul><blockquote>
<p>This seems right to me too. Please go ahead with this step.</p>
</blockquote>
<p>I've removed the commentpress themes in the following commit: <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/5179c959f8876031eaac5e15f2ab32c4909ee598">https://github.com/cuny-academic-commons/cac/commit/5179c959f8876031eaac5e15f2ab32c4909ee598</a>.</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=571942020-12-18T02:56:07ZMarilyn WeberMweber@gc.cuny.edu
<ul></ul><p>I am so relieved!</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=571972020-12-18T14:35:58ZMatt Goldmattgold@gmail.com
<ul></ul><p>Hi Boone -- can you clarify whether this means that no one will be able to use CommentPress going forward?</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=571992020-12-18T15:03:20ZBoone Gorgesboone@gorg.es
<ul><li><strong>Category name</strong> deleted (<del><i>WordPress Themes</i></del>)</li></ul><p>Thanks, Ray!</p>
<blockquote>
<p>Hi Boone -- can you clarify whether this means that no one will be able to use CommentPress going forward?</p>
</blockquote>
<p>No, it's unrelated to whether CommentPress can be used. This change means that it will be impossible to activate a CommentPress theme without first having the CommentPress plugin active.</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=572012020-12-18T15:54:36ZMatt Goldmattgold@gmail.com
<ul></ul><p>Got it. Thanks, Boone and Ray. Should we document this is some way so that people understand the order of what they have to do? Or can we trigger a warning to people who try to select the CP theme before activating the plugin? Apologies if you've already done this and I missed it</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=572022020-12-18T15:57:42ZBoone Gorgesboone@gorg.es
<ul></ul><p>The changes we've made ensure that you won't even see the CommentPress themes in the list unless you have the CommentPress plugin activated. In other words, we are eliminating the possibility of the bad combination that caused the problems in related tickets. I don't think any further action is needed.</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=572042020-12-18T16:49:36ZMatt Goldmattgold@gmail.com
<ul></ul><p>Okay. I do think we should document this, though. I've cc'ed Scott into the thread. Scott, can you please add something about this to our Help section?</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=572172020-12-18T19:29:25ZMatt Goldmattgold@gmail.com
<ul></ul><p>Right, but then you won't even know about CommentPress as a possibility unless you see it in the plugin list. My suggestion for Scott to document this was to make sure that users knew about the possibilities CP offers and how to go about implementing it in the right way.</p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=573002020-12-22T20:32:17ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Staged for Production Release</i> to <i>Resolved</i></li></ul> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=573812020-12-26T22:08:11Zscott vothscott.voth@verizon.net
<ul></ul><p>For the record - new documentation is available here - <a class="external" href="https://help.commons.gc.cuny.edu/commentpress/">https://help.commons.gc.cuny.edu/commentpress/</a></p> CUNY Academic Commons - Bug #13657: Activating commentpress-modern theme can cause fatal errors if commentpress-core plugin not activehttps://redmine.gc.cuny.edu/issues/13657?journal_id=573822020-12-27T01:03:55ZMatt Goldmattgold@gmail.com
<ul></ul><p>Thanks so much, Scott!</p>