https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2021-09-13T17:48:17ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Support #14767: Kadence Block Plugin Icons not workinghttps://redmine.gc.cuny.edu/issues/14767?journal_id=638192021-09-13T17:48:17ZLaurie Hurson
<ul><li><strong>Tracker</strong> changed from <i>Feature</i> to <i>Support</i></li></ul> CUNY Academic Commons - Support #14767: Kadence Block Plugin Icons not workinghttps://redmine.gc.cuny.edu/issues/14767?journal_id=638342021-09-14T14:14:31ZLaurie Hurson
<ul><li><strong>Subject</strong> changed from <i>Kadence Bloack Plugin Icons not working</i> to <i>Kadence Block Plugin Icons not working</i></li></ul> CUNY Academic Commons - Support #14767: Kadence Block Plugin Icons not workinghttps://redmine.gc.cuny.edu/issues/14767?journal_id=638592021-09-14T15:09:50ZBoone Gorgesboone@gorg.es
<ul><li><strong>Category name</strong> set to <i>WordPress Plugins</i></li><li><strong>Target version</strong> set to <i>1.18.19</i></li></ul><p>Hi Laurie - Thank you very much for researching this issue.</p>
<p>We cannot allow the unfiltered-mu plugin, for security reasons.</p>
<p>I've had a look at the Kadence author's custom plugin. I have to say that it's pretty bonkers. First, it adds svg attributes to the allowlist for permitted HTML (this part is not so weird). Then, it uses a hash-based trick to work around WordPress's security filter at the time that content is saved. It's clever, but it defeats the purpose of having these security issues in place. It would be easy for me to write some malicious code that would take advantage of this workaround. So I'm very wary of installing it.</p>
<p>It's certainly none of my business how the Kadence author writes plugins, but it seems to me that this problem could be mitigated by inserting the SVG into the post content via filter/shortcode/JS/render-callback rather than inserting it into the post content. Many WP blocks use custom render callbacks for this very purpose.</p>
<p>I may be able to write a small plugin that uses a content filter to detect the class names (like kt-info-svg-icon-fe_calendar) and then inserts the SVG. I'll take a bit of time in the upcoming weeks to see how labor-intensive it'll be. In the meantime, my only idea for a workaround is to avoid using the icons.</p> CUNY Academic Commons - Support #14767: Kadence Block Plugin Icons not workinghttps://redmine.gc.cuny.edu/issues/14767?journal_id=638782021-09-14T16:24:04ZLaurie Hurson
<ul><li><strong>Category name</strong> deleted (<del><i>WordPress Plugins</i></del>)</li><li><strong>Target version</strong> deleted (<del><i>1.18.19</i></del>)</li></ul><p>Thanks for this insight Boone, super helpful.</p>
<p>Yes, I was worried about the developer plugin too. I understand your concerns with the plugin and it sounds like it can't be used on the Commons.</p>
<p>I wonder if a plugin like Atomic blocks has icons and if switching to this plugin might solve this issue. I think I am meeting with her tomorrow and if she decides to use another plugin, i will report back here so you don't spend too much time looking into another workaround for Kadence.</p>
<p>I have added Scott on this ticket as a watcher in case he knows a bit more about the icon and page building options available through atomic blocks.</p> CUNY Academic Commons - Support #14767: Kadence Block Plugin Icons not workinghttps://redmine.gc.cuny.edu/issues/14767?journal_id=638992021-09-15T14:13:55Zscott vothscott.voth@verizon.net
<ul></ul><p>I think as a workaround, the member could install "Font Awesome" plugin, use the column block, and for each column, add a custom HTML block with something like this (picking an appropriate icon from <a class="external" href="https://fontawesome.com/v5.15/icons?d=gallery&p=2">https://fontawesome.com/v5.15/icons?d=gallery&p=2</a>):</p>
<p><div style="background-color:#f1f1f2;padding:10px;border-radius:30px 30px"><br /> <div style="text-align:center"><br /> <i class="fas fa-concierge-bell fa-2x"></i><br /> </div><br /> <div style="text-align:center"><br /> <h3 style="color:red">WHEN</h3><br /> <p>Every other Friday, Sept. 17, Oct. 1 & 15 <br>12:00 PM – 1:00 PM</p></div><br /></div></p> CUNY Academic Commons - Support #14767: Kadence Block Plugin Icons not workinghttps://redmine.gc.cuny.edu/issues/14767?journal_id=639502021-09-17T17:20:59ZLaurie Hurson
<ul></ul><p>Thanks for this Scott! Will pass the workaround idea on to the user.</p> CUNY Academic Commons - Support #14767: Kadence Block Plugin Icons not workinghttps://redmine.gc.cuny.edu/issues/14767?journal_id=699272022-04-27T20:31:32ZBoone Gorgesboone@gorg.es
<ul><li><strong>Category name</strong> set to <i>WordPress Plugins</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Target version</strong> set to <i>Not tracked</i></li></ul><p>I'm going to close this as resolved, based on Scott's workaround. Thanks!</p>