https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2022-01-05T05:01:59ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Bug #15147: Homepage Launch Design Tweakshttps://redmine.gc.cuny.edu/issues/15147?journal_id=665202022-01-05T05:01:59ZRaymond Hoh
<ul></ul><blockquote>
<p>- Members section: the names on the "From your campus" side need to be aligned <a class="external" href="https://share.getcloudapp.com/7KuqxgPQ">https://share.getcloudapp.com/7KuqxgPQ</a> (looks great on the logged out)</p>
</blockquote>
<p>Fixed in <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/12bb6d067047db52e2b2dd5558c94bf246a08fd2">https://github.com/cuny-academic-commons/cac/commit/12bb6d067047db52e2b2dd5558c94bf246a08fd2</a>. This is available on cdev for testing.</p>
<hr />
<blockquote>
<p>Logged In Homepage:<br />- Under Groups, when the title gets to be two lines the title/time does not align to the top of the thumbnail <a class="external" href="https://share.getcloudapp.com/9ZuDWrEP">https://share.getcloudapp.com/9ZuDWrEP</a><br />- Same with sites <a class="external" href="https://share.getcloudapp.com/6quED72y">https://share.getcloudapp.com/6quED72y</a><br />- Members section: section title and "discover more members" - not centered in the background. The background seems thicker than groups and sites <a class="external" href="https://share.getcloudapp.com/rRuNnX7O">https://share.getcloudapp.com/rRuNnX7O</a></p>
<p>Logged Out:<br />- active groups have the same alignment issue for 2 lines as above</p>
</blockquote>
<p>I've aligned all list-item titles to the top in <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/97d96d9845168569f9620dbf6d5d1be45129d854">https://github.com/cuny-academic-commons/cac/commit/97d96d9845168569f9620dbf6d5d1be45129d854</a>. This is also available on cdev for testing.</p>
<hr />
<blockquote>
<p>- When I load the page, the campus groups and sites seem to be "lazy" in their loading ... they need me to scroll to load it seems. Could they load on pageload?</p>
</blockquote>
<p>I coded the suggestions blocks to lazyload intentionally. See <a class="external" href="https://redmine.gc.cuny.edu/issues/14181#note-7">https://redmine.gc.cuny.edu/issues/14181#note-7</a>. This is done to speed up the initial page load time. If others feel this is not a good idea, I can look into refactoring the code to load as part of the page.</p>
<hr />
<blockquote>
<p>Mobile:<br />- when you get to the scrolling sections, the next item should go to the edge of the screen:https://share.getcloudapp.com/WnuqA4k8</p>
</blockquote>
<p>If we remove the right margin here, if you scroll all the way to the right, there will not be any margin. See <a class="external" href="https://i.postimg.cc/NMk8N1hT/scroll-no-right-margin.png">https://i.postimg.cc/NMk8N1hT/scroll-no-right-margin.png</a>. Is that okay?</p> CUNY Academic Commons - Bug #15147: Homepage Launch Design Tweakshttps://redmine.gc.cuny.edu/issues/15147?journal_id=665382022-01-05T16:12:06ZBoone Gorgesboone@gorg.es
<ul></ul><p>Thanks for jumping in on these, Ray.</p>
<blockquote>
<p>If we remove the right margin here, if you scroll all the way to the right, there will not be any margin. See <a class="external" href="https://i.postimg.cc/NMk8N1hT/scroll-no-right-margin.png">https://i.postimg.cc/NMk8N1hT/scroll-no-right-margin.png</a>. Is that okay?</p>
</blockquote>
<p>I was able to juggle the markup so that this isn't necessary. I've made the change in <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/b92fd1a3f7f9aa560f3ce1930969b6ee013621e5">https://github.com/cuny-academic-commons/cac/commit/b92fd1a3f7f9aa560f3ce1930969b6ee013621e5</a> and it's ready to test on cdev. (Be sure to hard-refresh or clear browser cache.)</p>
<blockquote>
<p>I coded the suggestions blocks to lazyload intentionally. See <a class="external" href="https://redmine.gc.cuny.edu/issues/14181#note-7">https://redmine.gc.cuny.edu/issues/14181#note-7</a>. This is done to speed up the initial page load time. If others feel this is not a good idea, I can look into refactoring the code to load as part of the page.</p>
</blockquote>
<p>How about just setting the scroll threshold a bit higher so that no one notices? Maybe 100px before it appears on page, or something like that? IMO the lazyload is a nice performance enhancement (especially on mobile, where scroll lengths are long and bandwidth could be an issue) so I'd prefer not to scrap it.</p> CUNY Academic Commons - Bug #15147: Homepage Launch Design Tweakshttps://redmine.gc.cuny.edu/issues/15147?journal_id=665542022-01-05T19:32:06ZColin McDonald
<ul></ul><p>Thanks for these notes, Sara. On the lazy loading, I agree if we change the scroll threshold so the loading is just a bit more hidden, it would be nice to keep it for performance.</p> CUNY Academic Commons - Bug #15147: Homepage Launch Design Tweakshttps://redmine.gc.cuny.edu/issues/15147?journal_id=666152022-01-07T02:27:37ZRaymond Hoh
<ul></ul><blockquote>
<p>I was able to juggle the markup so that this isn't necessary. I've made the change in <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/b92fd1a3f7f9aa560f3ce1930969b6ee013621e5">https://github.com/cuny-academic-commons/cac/commit/b92fd1a3f7f9aa560f3ce1930969b6ee013621e5</a> and it's ready to test on cdev. (Be sure to hard-refresh or clear browser cache.)</p>
</blockquote>
<p>Unfortunately, this commit broke the two-column layout for the logged-in homepage. I reverted this commit and found an easier fix: <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/90764a2db4ad22835fb93244f453e66e311a7c76">https://github.com/cuny-academic-commons/cac/commit/90764a2db4ad22835fb93244f453e66e311a7c76</a>. This is ready for testing on cdev.</p>
<blockquote>
<p>How about just setting the scroll threshold a bit higher so that no one notices? Maybe 100px before it appears on page, or something like that?</p>
</blockquote>
<p>I've added a 300px threshold. See <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/3d7eeb9a8d187ceb8db966704359de4ae816a44b">https://github.com/cuny-academic-commons/cac/commit/3d7eeb9a8d187ceb8db966704359de4ae816a44b</a>. This is also ready for testing on cdev. You might need to do a hard refresh so the cac-suggestions JS is updated. When testing, if you're scrolling slow, you will not notice the loading, but if you're scrolling fast, you might. Let me know if we want to bump up the threshold even more.</p> CUNY Academic Commons - Bug #15147: Homepage Launch Design Tweakshttps://redmine.gc.cuny.edu/issues/15147?journal_id=666462022-01-10T16:01:48ZLaurie Hurson
<ul><li><strong>File</strong> <a href="/attachments/20756">Screen Shot 2022-01-10 at 10.55.51 AM.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20756/Screen%20Shot%202022-01-10%20at%2010.55.51%20AM.png">Screen Shot 2022-01-10 at 10.55.51 AM.png</a> added</li></ul><p>Hi All,</p>
<p>Writing with another home page tweak on alignment.</p>
<p>On the logged in home page, the "My Sites" area is aligned left but seems very narrow, making some site names take up two lines when it would make more sense just take up a single line. The "My Groups area width is more reasonable. (Am i making sense? screenshot attached)</p>
<p>Can we make the My sites area width and groups area width the same?</p> CUNY Academic Commons - Bug #15147: Homepage Launch Design Tweakshttps://redmine.gc.cuny.edu/issues/15147?journal_id=666642022-01-10T20:47:02ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Staged for Production Release</i></li><li><strong>Target version</strong> set to <i>1.19.1</i></li></ul><p>These columns use "flex" styling, which means that if the browser detects that one side has a lot more text to show than the other (as in your case), then it takes more room.</p>
<p>I've made an adjustment in <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/48f2f076842e7538899faf562217a6aa009ea25d">https://github.com/cuny-academic-commons/cac/commit/48f2f076842e7538899faf562217a6aa009ea25d</a> that will enforce equal width in the two columns. This will be part of tomorrow's release.</p> CUNY Academic Commons - Bug #15147: Homepage Launch Design Tweakshttps://redmine.gc.cuny.edu/issues/15147?journal_id=666862022-01-11T15:10:07ZLaurie Hurson
<ul></ul><p>Thanks Boone!</p> CUNY Academic Commons - Bug #15147: Homepage Launch Design Tweakshttps://redmine.gc.cuny.edu/issues/15147?journal_id=667272022-01-11T21:41:09ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Staged for Production Release</i> to <i>Resolved</i></li></ul>