https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2022-01-25T02:12:12ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Bug #15216: Blog posts and comments from private sites shouldn't be visible in sitewide activity streamhttps://redmine.gc.cuny.edu/issues/15216?journal_id=670182022-01-25T02:12:12ZRaymond Hoh
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Staged for Production Release</i></li></ul><p>Fixed in <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/5c4eb7a3752c41b779b80debd8004c0f6be2ac35">https://github.com/cuny-academic-commons/cac/commit/5c4eb7a3752c41b779b80debd8004c0f6be2ac35</a>.</p>
<p>If a site is private, the fix will hide the blog-related activity item from being displayed sitewide.</p>
<p>Boone, I decided to add the fix directly into the <code>bp-mpo-activity-filter</code> plugin as other sites using the plugin might benefit from it. I've also added a pull request <a href="https://github.com/boonebgorges/bp-mpo-activity-filter/pull/11" class="external">here</a>. In the PR, I note that BuddyPress will block the activity item from saving if the site visibility option is set to <code>Discourage search engines from indexing this site</code>. We might want to mirror what BuddyPress is doing if the site's visibility setting is private, but I opted to hide the activity item sitewide for now.</p>
<p>I'm also going to run a script similar to <a class="external" href="https://redmine.gc.cuny.edu/issues/15134#note-5">https://redmine.gc.cuny.edu/issues/15134#note-5</a> to address blog activity items that should be hidden sitewide. Here's the MySQL query: <code>select a.id from wp_bp_activity a left join wp_blogs b on (a.item_id = b.blog_id) where a.hide_sitewide = 0 and a.component = 'blogs' and b.public < 1</code>. I'll run the script to switch these activity items over tomorrow.</p>
<hr />
<p><strong>Update:</strong></p>
<blockquote>
<p>In the PR, I note that BuddyPress will block the activity item from saving if the site visibility option is set to <code>Discourage search engines from indexing this site</code>. We might want to mirror what BuddyPress is doing if the site's visibility setting is private</p>
</blockquote>
<p>Disregard what I said here. <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Non-public sites should generate activity items with hide_sitewide = 1 (Resolved)" href="https://redmine.gc.cuny.edu/issues/8075">#8075</a> allows for activity recording for sites with the visibility option set to <code>"Discourage search engines from indexing this site"</code> or (<code>blog_public = 0</code>), so we do not need to follow what BuddyPress does.</p> CUNY Academic Commons - Bug #15216: Blog posts and comments from private sites shouldn't be visible in sitewide activity streamhttps://redmine.gc.cuny.edu/issues/15216?journal_id=670202022-01-25T04:50:32ZRaymond Hoh
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/8075">Feature #8075</a>: Non-public sites should generate activity items with hide_sitewide = 1</i> added</li></ul> CUNY Academic Commons - Bug #15216: Blog posts and comments from private sites shouldn't be visible in sitewide activity streamhttps://redmine.gc.cuny.edu/issues/15216?journal_id=670392022-01-25T16:28:05ZBoone Gorgesboone@gorg.es
<ul></ul><p>Thanks for catching this, Ray.</p> CUNY Academic Commons - Bug #15216: Blog posts and comments from private sites shouldn't be visible in sitewide activity streamhttps://redmine.gc.cuny.edu/issues/15216?journal_id=670512022-01-25T16:33:48ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Staged for Production Release</i> to <i>Resolved</i></li></ul>