https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2012-10-30T14:03:26ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=96362012-10-30T14:03:26ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> set to <i>1.4.10</i></li></ul> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=98662012-11-12T03:45:29ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> changed from <i>1.4.10</i> to <i>1.4.11</i></li></ul> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100142012-11-20T01:37:44ZDominic Gigliohumanshell@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/855">Screen_Shot_2012-11-19_at_8.24.33_PM.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/855/Screen_Shot_2012-11-19_at_8.24.33_PM.png">Screen_Shot_2012-11-19_at_8.24.33_PM.png</a> added</li></ul><p>Matt,</p>
<p>I created a new group in my local env, then created a test doc so I could comment on it as the admin of both the group and doc.</p>
<p>I've attached a screenshot of what I see on my machine. It appears that these editing links actually get styled by some jQuery (technically Ajax Edit Comments). Can we confirm that this was a one-time error? Or is this happening repeatedly to one of our members (or you)?</p>
<p>If it happened only once, I would argue that there was a network error while loading the Ajax Edit Comments code. Which would prevent those links from being styled properly. If this is happening consistently then I can take a deeper look into Ajax Edit Comments to make sure there isn't a deeper issue at work.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100172012-11-20T01:50:10ZMatt Goldmattgold@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/856">Screen_Shot_2012-11-19_at_8.49.31_PM.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/856/Screen_Shot_2012-11-19_at_8.49.31_PM.png">Screen_Shot_2012-11-19_at_8.49.31_PM.png</a> added</li></ul><p>Thanks, Dom. I can kind-of confirm this. Please see attached screenshot. Maybe I clicked "less options" (which should be "fewer options"!!) at one point?</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100182012-11-20T02:01:01ZDominic Gigliohumanshell@gmail.com
<ul></ul><p>That screenshot looks like you're viewing the comments for a doc on which you are not the "admin" or "creator."</p>
<p>You don't see the edit links unless you have the permissions to edit the doc. That's why I created a new group and a new doc so I knew that I'd be the owner of everything involved.</p>
<p>That link to more or less options is just a toggle that turns the dropdown on and off. It isn't a setting that determines what edit options will or will not be seen. Are you the creator of the doc in the most recent screenshot?</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100192012-11-20T02:02:09ZMatt Goldmattgold@gmail.com
<ul></ul><p>No, I'm not the creator of the doc but I am the admin of the group in which it was created.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100202012-11-20T02:05:52ZDominic Gigliohumanshell@gmail.com
<ul></ul><p>Then I assume only the creator of the doc can see the edit links.</p>
<p>I'm gonna create a new doc in my local env as a different user and see if I can confirm this.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100212012-11-20T02:25:28ZDominic Gigliohumanshell@gmail.com
<ul></ul><p>OK, here's what it comes down to.</p>
<p>As the admin of the group I can see the large grey edit button <strong>and</strong> the edit links on any and all comments across all docs. Which kinda makes sense for an admin. I'm not sure why, as an admin, you aren't seeing the edit links on the comment in your last screenshot.</p>
<p>When logged in as a "normal" test user I can't see any edit links or buttons on any docs at all.</p>
<p>So there is definitely some Roles and Capabilities code involved here. I jumped on this issue cause I thought I could help Boone out and take some more off his plate. But since he's the author of this plugin I think we should wait to hear what he thinks once he's got a chance to look at his CAC issues again.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100222012-11-20T02:37:13ZMatt Goldmattgold@gmail.com
<ul></ul><p>okay. Just looked at a doc with comments in another group and can confirm that I see what's in the other screenshot -- just an edit button.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100272012-11-20T13:19:52ZBoone Gorgesboone@gorg.es
<ul><li><strong>Assignee</strong> changed from <i>Boone Gorges</i> to <i>Dominic Giglio</i></li><li><strong>Severity</strong> set to <i>Low impact</i></li></ul><p>The problem doesn't seem to have anything to do with roles. It appears that AEC is loading its js from a blank js file <a class="external" href="http://commons.gc.cuny.edu/files/aec/ajax-edit-comments.js?ver=5.0.7.0">http://commons.gc.cuny.edu/files/aec/ajax-edit-comments.js?ver=5.0.7.0</a> (it exists, but is empty). I don't know why it has put its assets into the uploads folder instead of serving them out of wp-content/plugins like every other plugin in the world. In any case, it's having the practical effect of disabling the plugin on the production site.</p>
<p>Since it's not being used anyway, and since AEC is so old and buggy and unmaintained, let's go ahead and remove it.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100292012-11-20T13:25:50ZMatt Goldmattgold@gmail.com
<ul></ul><p>Hi Boone - does that mean that users will no longer be able to edit their comments? I'm not sure that the issues I've identified here warrant the loss of that useful functionality.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100342012-11-20T13:53:33ZBoone Gorgesboone@gorg.es
<ul></ul><p>I think they'll still be able to edit the comments, but it will happen in the dashboard instead of the front end. But, as I note above, this is happening now anyway, because the plugin is broken.</p>
<p>If we really need the front-end comment editing functionality back, we will have to find a new plugin or write it ourselves.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100382012-11-20T14:02:15ZMatt Goldmattgold@gmail.com
<ul></ul><p>Okay. Can you create an action reminder to check this functionality after the change is made on production? I don't think we need to worry about front-end editing, just that people do have the ability to edit.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100412012-11-20T14:28:51ZBoone Gorgesboone@gorg.es
<ul></ul><p>OK, I've made a note: <a class="external" href="https://github.com/castiron/cac/wiki/Release-ACTION_REQUIRED-list">https://github.com/castiron/cac/wiki/Release-ACTION_REQUIRED-list</a> But again, I should underscore that removing the plugin will not affect normal WP comment editing one way or the other, since the plugin is currently non-functional.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100422012-11-20T14:35:46ZMatt Goldmattgold@gmail.com
<ul></ul><p>Okay -- got it. thanks.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100632012-11-20T19:22:33ZDominic Gigliohumanshell@gmail.com
<ul></ul><p>Boone, Matt,</p>
<p>Just wanted to update here quickly before I remove Ajax Edit Comments.</p>
<p>Aside from the Commons, there are 3 sites that have the plugin enabled:</p>
<p><a class="external" href="http://globalization.gc.cuny.edu/">http://globalization.gc.cuny.edu/</a><br /><a class="external" href="http://sciencestudies.gc.cuny.edu">http://sciencestudies.gc.cuny.edu</a><br /><a class="external" href="http://keithmiyake.commons.gc.cuny.edu/">http://keithmiyake.commons.gc.cuny.edu/</a></p>
<p>All three sites are running JetPack for commenting. I don't even see the Ajax Edit Comments script being loaded on their pages. Which leads me to believe that they've got the plugin enabled but aren't using it.</p>
<p>I wanted your feedback before yanking the plugin out from under them.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100662012-11-20T20:04:25ZBoone Gorgesboone@gorg.es
<ul></ul><p>Thanks for checking, Dom. Sounds like the plugin's not doing anything on their sites, so we're clear to remove it.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100682012-11-20T20:11:14ZDominic Gigliohumanshell@gmail.com
<ul></ul><p>Thanks, removing now for 1.4.11 release.</p> CUNY Academic Commons - Bug #2220: Spacing error on BP Doc commentshttps://redmine.gc.cuny.edu/issues/2220?journal_id=100772012-11-20T20:47:01ZDominic Gigliohumanshell@gmail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>Plugin has been removed:</p>
<p><a class="external" href="https://github.com/castiron/cac/commit/65e85793e812c6a57123c844cb44417adf056519">https://github.com/castiron/cac/commit/65e85793e812c6a57123c844cb44417adf056519</a></p>