https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2012-11-11T22:54:35ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Feature #2243: Setup chasefrobinson Theme as a Luna Child Theme.https://redmine.gc.cuny.edu/issues/2243?journal_id=98272012-11-11T22:54:35ZMatt Goldmattgold@gmail.com
<ul></ul><p>Thanks, Dom. Added Erin as a watcher on this.</p> CUNY Academic Commons - Feature #2243: Setup chasefrobinson Theme as a Luna Child Theme.https://redmine.gc.cuny.edu/issues/2243?journal_id=98282012-11-11T23:11:30ZDominic Gigliohumanshell@gmail.com
<ul></ul><p>Thanks, I shoulda remembered to add Erin. :-)</p>
<p>I've added the new luna-cfr child theme to our repo, so it will be included in the 1.4.10 release. I started our customizations off with a functions.php file in our child that deregisters the parent's version of <code>fadeslide.js</code> and registers the customized version that forces the slider to start on page load. This was actually what started me off thinking about a parent vs child setup. I figured if we were going to be making more edits like this we needed to move to a child sooner rather than later. The update to 1.9 would have overridden our custom js.</p>
<p>I've also added a reminder to <a href="https://github.com/castiron/cac/wiki/Release-ACTION_REQUIRED-list" class="external">ACTION_REQUIRED</a> to enable this child for chasefrobinson.</p>
<p>I think we'll be able to close this issue out tonight just like <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Update Luna Theme to v1.9 (Resolved)" href="https://redmine.gc.cuny.edu/issues/2242">#2242</a>. As soon as I verify the site is behaving appropriately.</p>
<p>Commit: <a class="external" href="https://github.com/castiron/cac/commit/447477a3ee5bf3e51be0df456627389d77ad60ed">https://github.com/castiron/cac/commit/447477a3ee5bf3e51be0df456627389d77ad60ed</a></p> CUNY Academic Commons - Feature #2243: Setup chasefrobinson Theme as a Luna Child Theme.https://redmine.gc.cuny.edu/issues/2243?journal_id=98292012-11-11T23:13:37ZMatt Goldmattgold@gmail.com
<ul></ul><p>Fantastic. Thanks, Dom! Can I ask you to email all child theme files you've created to Erin so that she can study what you've done? Many thanks.</p> CUNY Academic Commons - Feature #2243: Setup chasefrobinson Theme as a Luna Child Theme.https://redmine.gc.cuny.edu/issues/2243?journal_id=98302012-11-11T23:13:52ZMatt Goldmattgold@gmail.com
<ul></ul><p>No rush on that emailing, btw. At your convenience.</p> CUNY Academic Commons - Feature #2243: Setup chasefrobinson Theme as a Luna Child Theme.https://redmine.gc.cuny.edu/issues/2243?journal_id=98592012-11-12T03:38:51ZBoone Gorgesboone@gorg.es
<ul></ul><p>Dom, I've enabled (but not activated) the theme on the Provost blog.</p> CUNY Academic Commons - Feature #2243: Setup chasefrobinson Theme as a Luna Child Theme.https://redmine.gc.cuny.edu/issues/2243?journal_id=98692012-11-12T03:47:15ZDominic Gigliohumanshell@gmail.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Resolved</i></li></ul><p>Thanks Boone.</p>
<p>I've activated and verified that we are GODD TO GO!! Child theme operating as expected and slider begins on initial page load.</p>
<p>The only thing I had to update was the Primary Menu. But I knew I was gonna have to do that.</p>
<p>Closing issue.</p> CUNY Academic Commons - Feature #2243: Setup chasefrobinson Theme as a Luna Child Theme.https://redmine.gc.cuny.edu/issues/2243?journal_id=98702012-11-12T04:00:24ZMatt Goldmattgold@gmail.com
<ul></ul><p>Awesome work, Dom! Many thanks.</p>