https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2012-11-20T01:06:01ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Feature #2248: Create Profile link to academia.edu profilehttps://redmine.gc.cuny.edu/issues/2248?journal_id=100112012-11-20T01:06:01ZDominic Gigliohumanshell@gmail.com
<ul></ul><p>Boone,</p>
<p>I think I've found the code responsible for this in the <code>bp-social-media-profiles</code> plugin. I'm not sure if this plugin exists outside of our repo, but if you want to reassign this to me I think I can copy some of the existing code to create an additional profile field for academia.edu. It looks like I could simply duplicate the Facebook Profile link code.</p>
<p>Feel free to kick this over to me, if it's as simple as it looks I might be able to get it in to 1.4.x.</p> CUNY Academic Commons - Feature #2248: Create Profile link to academia.edu profilehttps://redmine.gc.cuny.edu/issues/2248?journal_id=100252012-11-20T12:29:40ZBoone Gorgesboone@gorg.es
<ul><li><strong>Assignee</strong> changed from <i>Boone Gorges</i> to <i>Dominic Giglio</i></li></ul><p>Dom - Yes, bp-social-media-profiles is the plugin responsible for turning those fields into icons. If you'd like to have a go at adding academia.edu support, that'd be great. Here's the repo: <a class="external" href="https://github.com/boonebgorges/bp-social-media-profiles">https://github.com/boonebgorges/bp-social-media-profiles</a> Fork and send a pull request when you've got something :)</p> CUNY Academic Commons - Feature #2248: Create Profile link to academia.edu profilehttps://redmine.gc.cuny.edu/issues/2248?journal_id=100762012-11-20T20:42:11ZDominic Gigliohumanshell@gmail.com
<ul></ul><p>Added the requested pull request:</p>
<p><a class="external" href="https://github.com/boonebgorges/bp-social-media-profiles/pull/4">https://github.com/boonebgorges/bp-social-media-profiles/pull/4</a></p> CUNY Academic Commons - Feature #2248: Create Profile link to academia.edu profilehttps://redmine.gc.cuny.edu/issues/2248?journal_id=100862012-11-20T21:27:38ZBoone Gorgesboone@gorg.es
<ul></ul><p>I've merged the pull request. Dom, please put the merged version into the CAC codebase, and make sure it works as expected on your local install before committing it. Thanks.</p> CUNY Academic Commons - Feature #2248: Create Profile link to academia.edu profilehttps://redmine.gc.cuny.edu/issues/2248?journal_id=100902012-11-20T22:32:51ZDominic Gigliohumanshell@gmail.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Resolved</i></li><li><strong>Target version</strong> changed from <i>1.4.12</i> to <i>1.4.11</i></li></ul><p>I've updated the repo with the latest changes to bp-social-media-profiles to support academia.edu profile links (after testing in my local env).</p>
<p>Boone, at some point we need to revisit this plugin on Github. Some changes to <code>bp-social-media-profiles.php</code> were preventing the icons from showing up on a user's profile page. I basically updated our repo with all the new files <strong>except</strong> that one. The master branch appears to have had some functions removed?</p>
<p>There's way too much going on right now to worry about this, but we should revisit in the future to make sure the plugin works the way it's supposed to.</p>
<p>I've also added a note to <a href="https://github.com/castiron/cac/wiki/Release-ACTION_REQUIRED-list" class="external">ACTION_REQUIRED</a> to let the original reporter know that this functionality has been added to the commons.</p>
<p>Commit: <a class="external" href="https://github.com/castiron/cac/commit/36e279cc014a96727b23a74e47c971361e127f64">https://github.com/castiron/cac/commit/36e279cc014a96727b23a74e47c971361e127f64</a></p> CUNY Academic Commons - Feature #2248: Create Profile link to academia.edu profilehttps://redmine.gc.cuny.edu/issues/2248?journal_id=101412012-11-22T02:53:16ZBoone Gorgesboone@gorg.es
<ul></ul><p>This looks good on the updated site.</p>
<p>I don't have access to contact the original reporter. Matt, perhaps you can do so?</p> CUNY Academic Commons - Feature #2248: Create Profile link to academia.edu profilehttps://redmine.gc.cuny.edu/issues/2248?journal_id=101462012-11-22T04:55:33ZMatt Goldmattgold@gmail.com
<ul></ul><p>Yes, I'll get in touch with the originator. Thanks for your work on this, Dom and Boone.</p>