https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2014-07-24T14:13:11ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=159332014-07-24T14:13:11ZMatt Goldmattgold@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/1302">Screen Shot 2014-07-24 at 10.09.23 AM.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1302/Screen%20Shot%202014-07-24%20at%2010.09.23%20AM.png">Screen Shot 2014-07-24 at 10.09.23 AM.png</a> added</li></ul> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=172152014-10-21T20:38:53ZSamantha Raddatz
<ul></ul><blockquote>
<p>I would suggest changing the order of the Yes/No options so that Yes appears on the right and No appears on the left.</p>
</blockquote>
<p>My two cents: yes, switching the Yes/No options would be more logical here and ease user error.</p> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=172342014-10-22T13:24:20ZMatt Goldmattgold@gmail.com
<ul><li><strong>Assignee</strong> changed from <i>Chris Stein</i> to <i>Boone Gorges</i></li></ul><p>Thanks, Samantha. This is pretty minor, so I am assigning to Boone for implementation. Chris, if you have options, please speak up, but if you are busy, we will just move forward with this.</p> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=173472014-11-01T18:51:59ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> set to <i>1.8</i></li></ul><p>This is going to take a pretty fair amount of work - it's likely I'll have to write some javascript to reorder them on the fly.</p> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=185532015-03-10T01:13:30ZBoone Gorgesboone@gorg.es
<ul><li><strong>Assignee</strong> changed from <i>Boone Gorges</i> to <i>Daniel Jones</i></li></ul><blockquote>
<p>This is going to take a pretty fair amount of work - it's likely I'll have to write some javascript to reorder them on the fly.</p>
</blockquote>
<p>What I meant is that it's going to be a pretty fair amount of work for Daniel :) Dan, would you mind seeing what you can do about writing the necessary javascript to do this? It probably won't be too tough.</p> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=185772015-03-11T03:24:04ZDaniel Jonesdrjones18@gmail.com
<ul></ul><p>Sure I'm happy to work on this! Doesn't seem like it ought to be too difficult. I'm using javascript so that I don't mess with the BuddyPress core code, right?</p> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=185782015-03-11T03:55:04ZDaniel Jonesdrjones18@gmail.com
<ul></ul><p>Let me know what you think of what I came up with here: <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/107c256b38893bd074fc6c17348ee65b7d30954f">https://github.com/cuny-academic-commons/cac/commit/107c256b38893bd074fc6c17348ee65b7d30954f</a></p>
<p>I tried to take advantage of the fact that both the cells in the headers and the cells with the radio buttons have the class "yes", and the fact that in jQuery (and I think vanilla javascript, too) the append() function, when called with an existing element as the argument, actually just moves the element to the end of the new parent, to try and keep it as simple as possible.</p>
<p>I'm not sure I put the function to enqueue the javascript, or the js file itself, in the right place though.</p> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=185792015-03-11T11:53:31ZBoone Gorgesboone@gorg.es
<ul></ul><p>Oh, clever. The JS looks good.</p>
<p>Let's move this to wp-content/themes/bp-nelo/_inc/js/cac-custom-js.js - this is where most of our miscellaneous JS stuff lives. (It's ugly in there, but it'll help us avoid another HTTP request.) Because this will run on every page, and it's likely that there are pages with elements using the 'yes' class, could we make the selector more specific? Maybe get the ID of the notification table - not sure off the top of my head what it is - and then use '#notification-settings-table .yes' or whatever as the selector.</p> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=186452015-03-13T19:01:31ZDaniel Jonesdrjones18@gmail.com
<ul></ul><p>Okay great I made some changes based on this: put the code in the file you suggested, and added the 'notification-settings' class to the jQuery selector. Turns out it's actually a bunch of different tables that make up the page, but they all share that class. I also added in an if() statement so that we don't try to run .each() on an empty array. Let me know if you think this is good to go.</p>
<p>Here are the changes on Github: <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/dab1aac609c743f83f2120bc8daa772bd0ea7d04">https://github.com/cuny-academic-commons/cac/commit/dab1aac609c743f83f2120bc8daa772bd0ea7d04</a></p> CUNY Academic Commons - Design/UX #3346: Notification page option orderinghttps://redmine.gc.cuny.edu/issues/3346?journal_id=186482015-03-13T21:25:41ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Resolved</i></li></ul><p>Looks good. Thanks!</p>