https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2015-11-20T05:41:04ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Feature #4932: Allow users to see Files when using wplink feature in BuddyPress Docshttps://redmine.gc.cuny.edu/issues/4932?journal_id=217442015-11-20T05:41:04ZHannah Aizenmanhaizenman@gmail.com
<ul><li><strong>Assignee</strong> deleted (<del><i>Boone Gorges</i></del>)</li></ul> CUNY Academic Commons - Feature #4932: Allow users to see Files when using wplink feature in BuddyPress Docshttps://redmine.gc.cuny.edu/issues/4932?journal_id=217592015-11-21T21:48:08ZBoone Gorgesboone@gorg.es
<ul><li><strong>Subject</strong> changed from <i>Allow users to see files in docs</i> to <i>Allow users to see Files when using wplink feature in BuddyPress Docs</i></li><li><strong>Assignee</strong> set to <i>Boone Gorges</i></li><li><strong>Target version</strong> set to <i>1.9</i></li></ul><p>This is a good idea. Let me see how hard it would be.</p>
<p>Just to be clear: by "files" you are talking about items uploaded under the Files tab of a group?</p> CUNY Academic Commons - Feature #4932: Allow users to see Files when using wplink feature in BuddyPress Docshttps://redmine.gc.cuny.edu/issues/4932?journal_id=217602015-11-21T23:30:38ZHannah Aizenmanhaizenman@gmail.com
<ul></ul><p>Boone Gorges wrote:</p>
<blockquote>
<p>Just to be clear: by "files" you are talking about items uploaded under the Files tab of a group?</p>
</blockquote>
<p>Yes and thanks!</p> CUNY Academic Commons - Feature #4932: Allow users to see Files when using wplink feature in BuddyPress Docshttps://redmine.gc.cuny.edu/issues/4932?journal_id=219422015-12-09T17:57:48ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> changed from <i>1.9</i> to <i>1.9.2</i></li></ul> CUNY Academic Commons - Feature #4932: Allow users to see Files when using wplink feature in BuddyPress Docshttps://redmine.gc.cuny.edu/issues/4932?journal_id=220692015-12-15T16:54:36ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>Okey dokey, I've added this in <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/d6c4725fe0c30d2f48c9c0b1669398d79d4448d4">https://github.com/cuny-academic-commons/cac/commit/d6c4725fe0c30d2f48c9c0b1669398d79d4448d4</a></p>
<p>When editing a Doc in a group, you'll now see that group's Files at the top of the list when selecting from existing content in the Link dialog.</p>
<p>A note for posterity. The wpLink dialog supports a sort of river/infinite-scroll, which works by fetching the next 20 items when the scroll position reaches a certain vertical position. Behind the scenes, this works by passing an incrementing 'offset' to WP_Query. I didn't feel like covering all the possible cases of altered pagination/offset when dealing with group files, so I ignored it: group files are put at the very top of the results, followed immediately by the first 20 post-type results. The only concern here is performance; there may be some delay in cases where a group has many hundreds of Files. But this will only be the case very rarely.</p>