https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2016-01-03T02:14:37ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=221582016-01-03T02:14:37ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> set to <i>1.9.4</i></li></ul> CUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=222262016-01-12T03:51:30ZBoone Gorgesboone@gorg.es
<ul><li><strong>Assignee</strong> changed from <i>Boone Gorges</i> to <i>Raymond Hoh</i></li></ul><p>Ray, you have any idea why this would be happening? I don't see how Edit mode would be triggered on entry like this.</p> CUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=222312016-01-12T03:54:54ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> changed from <i>1.9.4</i> to <i>1.9.5</i></li></ul> CUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=223512016-01-22T02:57:30ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> changed from <i>1.9.5</i> to <i>1.9.6</i></li></ul> CUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=226102016-02-01T22:35:47ZRaymond Hoh
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Reporter Feedback</i></li></ul><p>It might have something to do with HTTPS and the hotfix we deployed for FEE:<br /><a class="external" href="https://github.com/cuny-academic-commons/cac/commit/7550ae6e1835fb87fbf7ecda757819e28ded4688">https://github.com/cuny-academic-commons/cac/commit/7550ae6e1835fb87fbf7ecda757819e28ded4688</a></p>
<p>But, like Boone, I could not duplicate this with Sam's instructions. Specifically:</p>
<blockquote>
<p>- Clicked on my paper in the 'All Papers' tab of the directory<br />- That took me to my own paper in edit-mode with the comment bubbles visible.</p>
</blockquote>
<p>If you click on a link from the Papers Directory, it shouldn't take you directly to Edit Mode.</p>
<p>Is this still happening on production?</p> CUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=226112016-02-01T22:36:00ZRaymond Hoh
<ul><li><strong>Assignee</strong> changed from <i>Raymond Hoh</i> to <i>Samantha Raddatz</i></li></ul> CUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=226192016-02-02T04:27:10ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> changed from <i>1.9.6</i> to <i>1.9.7</i></li></ul> CUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=226212016-02-02T16:13:44ZSamantha Raddatz
<ul></ul><p>I just re-tried my steps on the dev and it does not appear to happen on cdev, though it's still happening on the live-site.</p> CUNY Academic Commons - Bug #5069: Comments visible in edit modehttps://redmine.gc.cuny.edu/issues/5069?journal_id=227122016-02-11T10:45:31ZRaymond Hoh
<ul><li><strong>Status</strong> changed from <i>Reporter Feedback</i> to <i>Resolved</i></li><li><strong>Assignee</strong> changed from <i>Samantha Raddatz</i> to <i>Raymond Hoh</i></li></ul><p>Okay, I was finally able to duplicate this bug locally and have added a fix for this:<br /><a class="external" href="https://github.com/cuny-academic-commons/cac/commit/6a9cfa129076fa8a9229588d1ac33f277390dd7c">https://github.com/cuny-academic-commons/cac/commit/6a9cfa129076fa8a9229588d1ac33f277390dd7c</a></p>
<p>Previously, we appended <code>#edit=true</code> to the paper URL if you were viewing the site without SSL. This would trigger edit mode automatically when clicking on a paper link.</p>
<p>Now, if you click on a paper from the Papers Directory, edit mode will no longer be triggered, which is what we intended originally.</p>