https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2011-05-03T19:25:53ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Bug #725: BP Group Email Subscription - Double notificationshttps://redmine.gc.cuny.edu/issues/725?journal_id=28852011-05-03T19:25:53ZBoone Gorgesboone@gorg.es
<ul></ul><p>Good catch.</p>
<p>I'd say that a better fix is for BP Group Email Sub to check to see whether you've got notification_activity_new_reply set before sending an email to you. The only trick will be to get the user_id of the activity being responded to.</p>
<p>Does that sound reasonable? If so, feel free to work up a patch - or I can do it myself.</p> CUNY Academic Commons - Bug #725: BP Group Email Subscription - Double notificationshttps://redmine.gc.cuny.edu/issues/725?journal_id=28922011-05-04T08:32:18ZRaymond Hoh
<ul></ul><p>Boone Gorges wrote:</p>
<blockquote>
<p>I'd say that a better fix is for BP Group Email Sub to check to see whether you've got notification_activity_new_reply set before sending an email to you. The only trick will be to get the user_id of the activity being responded to.</p>
</blockquote>
<p>I guess the better question is do we want to stop the built-in BuddyPress notification or the one from the Group Email plugin?</p>
<p>The latter is easier (which is the method you recommend). When I originally posted this ticket, it was to cancel the BuddyPress one. However, stopping the built-in BuddyPress one (while allowing the Group Email send) will require a bit of hackery.</p> CUNY Academic Commons - Bug #725: BP Group Email Subscription - Double notificationshttps://redmine.gc.cuny.edu/issues/725?journal_id=28942011-05-04T13:23:39ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> changed from <i>Raymond Hoh</i> to <i>Boone Gorges</i></li></ul><blockquote>
<p>I guess the better question is do we want to stop the built-in BuddyPress notification or the one from the Group Email plugin?</p>
</blockquote>
<p>Right - I was implying that we should favor the BP-native notification. Since bp_activity_new_comment_notification() is called directly, not via a hook, it would require (as you say) some ugly hackery to make it work right.</p>
<p>I opted to fix BPGES so that it would bail when BP-native notifications are enabled. Fixed in <a class="external" href="https://github.com/castiron/cac/commit/d0282f024bcc4cf95bc6e64bd710a3f8f22f004e">https://github.com/castiron/cac/commit/d0282f024bcc4cf95bc6e64bd710a3f8f22f004e</a> Thanks for talking through it, Ray.</p> CUNY Academic Commons - Bug #725: BP Group Email Subscription - Double notificationshttps://redmine.gc.cuny.edu/issues/725?journal_id=28952011-05-04T13:25:18ZBoone Gorgesboone@gorg.es
<ul></ul><p>(also fixed in the distribution version: <a class="external" href="http://plugins.trac.wordpress.org/changeset/380733">http://plugins.trac.wordpress.org/changeset/380733</a>)</p> CUNY Academic Commons - Bug #725: BP Group Email Subscription - Double notificationshttps://redmine.gc.cuny.edu/issues/725?journal_id=28962011-05-04T13:28:24ZBoone Gorgesboone@gorg.es
<ul></ul><p>Also, boo on me for committing debug code. Fixed in <a class="external" href="http://plugins.trac.wordpress.org/changeset/380738">http://plugins.trac.wordpress.org/changeset/380738</a> and <a class="external" href="https://github.com/castiron/cac/commit/47f9d78f65bca3d58a3baff09ef3b1a318094e45">https://github.com/castiron/cac/commit/47f9d78f65bca3d58a3baff09ef3b1a318094e45</a></p>