https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2011-05-04T14:37:38ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=29042011-05-04T14:37:38ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> changed from <i>1.2.1</i> to <i>1.3</i></li></ul><p>I do not want to add separate notification settings for Docs. Notification settings are already too complex and spread out throughout the site.</p>
<p>I should note that Docs has activity throttle built in. It will not post more than one activity item per editor per doc per hour. Thus, there is a de facto throttle on notifications as well. In other words, if you edit and save frequently, only the first one will create an activity item/notification. A second one will only be created for saves that happen more than 60 minutes later (a time limit that we can extend to whatever we want).</p>
<p>For this reason, I don't think that any checkbox is needed. I don't want to clutter up the interface unnecessarily. However, I'm willing to be overruled if people overwhelmingly think that the throttle isn't enough of a solution.</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=29182011-05-04T17:30:45ZMatt Goldmattgold@gmail.com
<ul></ul><p>Didn't know about the throttle -- that does obviously change things. I'm curious to hear about what others think. We might also want to take some time to let people use the plugin and see what they think (Group for Group Admins would be a good group to ask about this). Depending upon what this group says, we might want to put this on hold for at least a little while.</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=30512011-05-16T14:07:23ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Hold</i></li><li><strong>Target version</strong> changed from <i>1.3</i> to <i>Not tracked</i></li></ul><p>Cool. I'm going to remove this from the 1.3 milestone and change it to Hold. We'll revisit in a few months and decide whether to close or prioritize.</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=31412011-06-02T11:22:15ZMatt Goldmattgold@gmail.com
<ul><li><strong>Status</strong> changed from <i>Hold</i> to <i>Assigned</i></li><li><strong>Target version</strong> changed from <i>Not tracked</i> to <i>1.3</i></li></ul><p>Last night, I avoided edited a group doc because I didn't want another email notification to go out (7 notifications had been sent yesterday alone). That's not good for the Commons or the for usage of Group Docs.</p>
<p>It seems to me that adding a small checkbox that says "Minor edit, no email notification" near the save button wouldn't clutter up the interface too much and would add some nice functionality to the system. I'd like to recommend that we move this to the 1.3 milestone.</p>
<p>How do others feel?</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=32292011-06-08T17:15:15ZBoone Gorgesboone@gorg.es
<ul></ul><p>I still don't care for the idea but I'm willing to be overruled. Anyone else have thoughts about it?</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=32342011-06-09T14:18:40ZChris Steincstein@bmcc.cuny.edu
<ul><li><strong>File</strong> <a href="/attachments/160">DocsMinorUpdate.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/160/DocsMinorUpdate.png">DocsMinorUpdate.png</a> added</li></ul><p>I think that throttling is excellent and also that Matt's concern will be shared by others. The checkbox idea is basically what MediaWiki has too so the concept is one in use already (and it shows there may be a need for it).</p>
<p>Boone I understand your concern but I think I would go in favor of the checkbox (quick mockup attached).</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=32352011-06-09T14:24:52ZBoone Gorgesboone@gorg.es
<ul></ul><p>The architectural problem I have is that the checkbox suggestion is too broad an approach. Matt's initial concern arises out of the fact that the Commons uses a group email subscription plugin, and that our members are subscribed by default to each group's firehose (ie all activity from the group). But neither of these things is the typical setup (group email is a plugin, and I hacked it to make "all activity" the default). Such a checkbox would presumably keep BP Docs from creating an activity item, but it's not activity that's causing the problem - it's our group email settings. Since activity items are used in a variety of other ways within BP, it's a bad thing to stop those activity items from being created because of these indirect concerns.</p>
<p>I guess this is largely a question of whether such a checkbox should be a part of the release version of BuddyPress Docs. For the reasons I give above, I am pretty much opposed to the checkbox in the release version. But I'm happy to build it as a Commons-only plugin for BP Docs.</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=32722011-06-16T20:51:22ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Resolved</i></li></ul><p>I added a checkbox with the following text:<br />This is a minor edit (notifications will not be sent to subscribed group members)</p>
<p>When checked, no activity item is posted, and thus no notifications are sent. This is a Commons-specific plugin, found in bp-custom.php</p>
<p>Fixed in cdf0736</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=32732011-06-16T20:51:38ZBoone Gorgesboone@gorg.es
<ul></ul><p>aka <a class="external" href="https://github.com/castiron/cac/commit/cdf07366474f0c96797bd397ef5709586f220e4a">https://github.com/castiron/cac/commit/cdf07366474f0c96797bd397ef5709586f220e4a</a></p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=32762011-06-16T21:10:31ZMatt Goldmattgold@gmail.com
<ul></ul><p>Thank you, Boone.</p> CUNY Academic Commons - Feature #735: BP Docs - Include Check-Box to Avoid Email Notifications of Minor Editshttps://redmine.gc.cuny.edu/issues/735?journal_id=41702011-07-24T15:34:25ZBoone Gorgesboone@gorg.es
<ul><li><strong>Target version</strong> changed from <i>1.3</i> to <i>1.2.5</i></li></ul>