https://redmine.gc.cuny.edu/https://redmine.gc.cuny.edu/favicon.ico2018-03-09T09:51:47ZCUNY Graduate Center - Project Tracking SystemCUNY Academic Commons - Support #9370: Text to Speech pluginhttps://redmine.gc.cuny.edu/issues/9370?journal_id=359852018-03-09T09:51:47ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Reporter Feedback</i></li></ul><p>Could you point out the place in the code where you made the change? I can take a look to see if there's a way that we can make such a change without changing the plugin's source code (via a filter or something like that). If so, we can create a small plugin for this specific site that'll set the default. If not, we can talk about alternative approaches. (In general, we don't modify plugin source code, as it wreaks havoc with future updates.)</p> CUNY Academic Commons - Support #9370: Text to Speech pluginhttps://redmine.gc.cuny.edu/issues/9370?journal_id=359902018-03-09T16:19:23Zscott vothscott.voth@verizon.net
<ul><li><strong>File</strong> <a href="/attachments/7246">text-to-speech-widget.zip</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/7246/text-to-speech-widget.zip">text-to-speech-widget.zip</a> added</li></ul><p>Thanks Boone - He also wanted the option to speak the text more slowly - so I added checkbox for that too. I have attached the zip file.</p>
<p>Changes to voice.js lines 16-19<br />changes to text-to-speech-widget.php - lines 50-60, 66, 82-90, 98-104</p>
<p>Hope this is not too much work for you.</p> CUNY Academic Commons - Support #9370: Text to Speech pluginhttps://redmine.gc.cuny.edu/issues/9370?journal_id=360282018-03-13T15:38:52ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Reporter Feedback</i> to <i>Assigned</i></li><li><strong>Target version</strong> set to <i>1.12.11</i></li></ul><p>Thanks, Scott. I'll take a look and see what can be done in the next few days.</p> CUNY Academic Commons - Support #9370: Text to Speech pluginhttps://redmine.gc.cuny.edu/issues/9370?journal_id=360802018-03-15T15:22:21ZBoone Gorgesboone@gorg.es
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Hold</i></li></ul><p>Hi Scott - I've had a chance to look over your changes. I have to say, the features you've suggested are pretty good additions to the plugin. If you want to pursue them, you might consider sending an enhancement request to the plugin author. It looks like this is the author's GitHub repo <a class="external" href="https://github.com/pmbaldha/Text-To-Speech-Widget-Wordpress-Plugin">https://github.com/pmbaldha/Text-To-Speech-Widget-Wordpress-Plugin</a>. No idea whether he'll consider a pull request - it doesn't look like the repo has been updated since the plugin was initially added.</p>
<p>Unfortunately, I can't accept the changes as-is on the Commons, because we can't maintain plugin forks (except in extreme circumstances). So what I've done is move your mods into a separate plugin, which makes the requested changes in JS (there are no applicable filters in the PHP). Here's the changeset on the Commons repo, which I've just granted you access to: <a class="external" href="https://github.com/cuny-academic-commons/cac/commit/15177d2cd52e9b6732b3f924104a4ebf24d11275">https://github.com/cuny-academic-commons/cac/commit/15177d2cd52e9b6732b3f924104a4ebf24d11275</a> Note my trick in the plugin loader file: I wait until after the text-to-speech-widget plugin has registered its JS at wp_enqueue_scripts (with implied priority 10 - thus my own priority 20), and then I deregister its script and register our version of it with the same name. Then the mods in the voice.js file match your mods pretty closely. In a separate commit, I limited the plugin so that it can only be activated on the elementaryitalian site. I'll activate it there and verify that it works properly after the next release.</p>
<p>Thanks for your work on this - you went above and beyond. Let me know if you have more questions or thoughts about implementation on this ticket.</p> CUNY Academic Commons - Support #9370: Text to Speech pluginhttps://redmine.gc.cuny.edu/issues/9370?journal_id=360822018-03-15T17:14:02Zscott vothscott.voth@verizon.net
<ul></ul><p>Awesome Boone! Thanks!</p> CUNY Academic Commons - Support #9370: Text to Speech pluginhttps://redmine.gc.cuny.edu/issues/9370?journal_id=362942018-03-27T16:47:58ZRaymond Hoh
<ul><li><strong>Status</strong> changed from <i>Hold</i> to <i>Resolved</i></li></ul><p>I've activated our custom text-to-speech plugin on Daniel's site.</p>
<p>Thanks for your work on this, Scott!</p>