Bug #10899: Social Paper should not attempt to delete activity after deletion of a non-SP post - CUNY Academic Commons - CUNY Graduate Center - Project Tracking System

Actions

Bug #10899

closed

Social Paper should not attempt to delete activity after deletion of a non-SP post

Added by Boone Gorges almost 6 years ago. Updated almost 6 years ago.

Status:

Resolved

Priority name:

Normal

Assignee:

-

Category name:

Social Paper

Target version:

Start date:

2018-12-28

Due date:

% Done:

0%

Estimated time:

Deployment actions:

Description

Social Paper tries to clean up SP-linked activity after posts are deleted https://github.com/cuny-academic-commons/social-paper/blob/7ebe52a2c3ef31e915140cc7f19a6c32fcd2bc95/includes/hooks-buddypress-activity.php#L400

But it doesn't differentiate between SP posts and other posts, so it runs unnecessarily in many cases.

Actions

#1

Updated by Boone Gorges almost 6 years ago

Status changed from New to Resolved

I've made the change in https://github.com/cuny-academic-commons/social-paper/commit/c6cdd1b501c803ce36bb1bff1f8fcd39a494987f https://github.com/cuny-academic-commons/cac/commit/a84a43a4a63f285fe367ae8abf53df2bf4c93a2a

Actions

Also available in: Atom PDF