CUNY Academic Commons

Hey,
You are a star!
Thanks for your help with the debugging! Just fixed it.

Yeah I know testing and doing back and forth on your server is not possible. Was hoping that the theme is good enough to run on Commons between now and the next deadline. But I agree with you now, let me try a local Wordpress and make sure that the theme is absolutely good to go. Will bother you then for the deployment.

Best,
Moein

The launch is set to be Sep 1. It would be great to have this up tomorrow so I have time to get feedback and if necessary update it one more time to be released on the 27th.
Thanks a lot.

I've added the theme to the repo and deployed to the production site. Internal reference: https://github.com/cuny-academic-commons/cac/commit/a09b06b5c765c31401810c70b539d9cd09609ada

The theme is enabled, but not activated, on https://preludenyc19.commons.gc.cuny.edu/presents/.

Regarding testing and feedback, I strongly suggest that in future years, you set up a separate space where the stakeholders can review prior to deployment on the Commons. I am happy to push bugfixes and other updates as part of the next scheduled release, but it's not generally possible for me to make exceptions to that schedule as I have in the current case.

Thank you very much Boone. Your extracurricular work is greatly appreciated.

I inherited from my predecessor Alex, a segalcenterdigital.org exactly as that separate space (I do not know how much you are involved in that back, if at all) which crashed on me halfway and I hope to get to see what exactly is wrong with it as soon as I am done with Prelude 2019.

Thank you!

Thank you :)

Updated in https://github.com/cuny-academic-commons/cac/commit/87750ca5612d5c360390943ecdb563d971e2d0e4. It will be part of the 1.15.9 release, within the next hour or so.

Thanks Boone,

There is one problem left that I can not figure out. The Schedule page a.k.a front page of preludenyc19.commons.gc.cuny.edu is missing the timeline! It should look just like the preludenyc18.commons.gc.cuny.edu. It is especially weird since both the site and the theme are basically clones of the site and the theme from last year.

Do you have any clues why this is happening and how it could be fixed?

(Might be obvious for you, but in the https://preludenyc19.commons.gc.cuny.edu/wp-admin/edit.php?post_type=page , if you wanted to check the schedule / front page do not view since the homepage is redirected to the splash page, but preview)

I'm seeing a fatal error:

Fatal error:  Uncaught Error: Call to a member function format() on null in /var/www/html/commons/www/wp-content/themes/prelude19/front-page.php:279
Stack trace:
#0 /var/www/html/commons/www/wp-includes/template-loader.php(78): include()
#1 /var/www/html/commons/www/wp-blog-header.php(19): require_once('/var/www/html/c...')
#2 /var/www/html/commons/www/index.php(17): require('/var/www/html/c...')
#3 {main}
  thrown in /var/www/html/commons/www/wp-content/themes/prelude19/front-page.php on line 279

This points to the following line:

$first_hour = $first_time->format('Hi');

You'll need to debug why an item might not have a $first_time - I see some foreach logic just above that but I don't fully understand the cases where it might fail.

Thanks for the catch!

Ok — back to the keyboard

Hi Boone,

That last issue got resolved when we just reenter the dates and times of each event in the back! I have no idea how! Does it make any sense to you?

There is another bug that I just found in the front-page.php:

The --> in line 149 should be moved to line 148. In other words the comment should end one </div> tag sooner.

so instead of

</div>
</div>-->

should be:

</div>-->
</div>

Is that an easy fix?

Thank you

Hi,

I am working on some other changes and will actually have an updated version of the theme by Monday, for the 24th release.
Just thought debugging could go live earlier. The festival is a bit more than 2 weeks away and everyone is antsy to see the front page polished.

If you get me the changes sometime on Monday, it should be no problem to include them the next day.

As noted here and elsewhere, please keep in mind that the Commons is not set up for frequent, quick-turnaround deployment. Testing and QA should happen elsewhere, with the Commons used only as a production site.

I've made another exception in this case and deployed your most recent bug fix.

Sorry to open this one back up. They are now beginning to think about Prelude 2021, and I am wondering if I should try to gently discourage them from coming up with their own theme. The person involved on this ticket is no longer with them, and I get the impression they only have one person working there now.

I definitely recommend against going with a custom theme if they no longer have anyone on their staff to do the necessary technical work. Threads like this one should serve as a warning about the time and skills necessary to make it work.