Project

General

Profile

Support #11757

New Wordpress theme - Prelude 19

Added by Moeinedin Shashaei 12 months ago. Updated 11 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2019-08-15
Due date:
% Done:

0%

Estimated time:

Description

Hi Boone,

Can I ask for an emergency theme installation? You can find the .zip file attached.

It is for the Prelude 2019 site and I intended to check it with our curators on SegalCenterDigital and send you the final version for the next deadline but SegalCenterDigital has been giving me a ton of headaches in the past week. Lots of:

This page isn’t working segalcenterdigital.org is currently unable to handle this request.
HTTP ERROR 500

I thought perhaps testing it on the actual site on the Commons would be a safer bet for now. I will check it with them and resubmit the finalized version of the theme to you before the last deadline of August.

Let me know what you think.

Thanks as always
Mo

prelude19.zip (9.46 MB) prelude19.zip Moeinedin Shashaei, 2019-08-15 07:03 PM
prelude19.zip (9.88 MB) prelude19.zip Moeinedin Shashaei, 2019-08-21 12:40 PM
prelude19.zip (12.8 MB) prelude19.zip Moeinedin Shashaei, 2019-08-26 03:58 PM
prelude19.zip (12.8 MB) prelude19.zip Moeinedin Shashaei, 2019-09-10 07:24 AM
11757.diff (642 Bytes) 11757.diff Boone Gorges, 2019-09-19 12:31 PM

History

#1 Updated by Boone Gorges 12 months ago

  • Status changed from New to Reporter Feedback

Hi Mo - I might consider an immediate deployment, but I can't do it just for testing purposes. Because you don't have server access, you're not going to be able to do the kinds of necessary debugging; and I won't be available for the kind of immediate back-and-forth deployment/troubleshooting that you'd need in this kind of case.

I'm unsure about Segal's setup, but you should be able to do the necessary debugging in a local installation of WordPress. I can see just by linting the files, for example, that there's a syntax error in front-page.php:

$ php -l prelude19/front-page.php
PHP Parse error:  syntax error, unexpected '(', expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in wp-content/themes/prelude19/front-page.php on line 562
Errors parsing wp-content/themes/prelude19/front-page.php

This points to a line where I think you meant to write $hour->format('H') but instead you wrote $hour->('H'). I'd suggest going through the theme on a local WP installation in order to clear up these 500 errors (triggered in this case by PHP fatals). When you're happy with what you've got, we can deploy to the production site.

#2 Updated by Moeinedin Shashaei 12 months ago

Hey,
You are a star!
Thanks for your help with the debugging! Just fixed it.

Yeah I know testing and doing back and forth on your server is not possible. Was hoping that the theme is good enough to run on Commons between now and the next deadline. But I agree with you now, let me try a local Wordpress and make sure that the theme is absolutely good to go. Will bother you then for the deployment.

Best,
Moein

#3 Updated by Moeinedin Shashaei 12 months ago

Hello Boone,

I installed Wordpress locally. Fixed the design and took care of any error I could catch. I guess what you find attached now is good to go — fingers crossed.
Am I correct that today or tomorrow is the deployment date?

Our staff and curators are excited to catch a glimpse of the update on screen. They also asked me to share with their appreciation of all your generous helps.
Please let me know how it goes.

Best,
Moein

#4 Updated by Boone Gorges 12 months ago

  • Subject changed from New Wordpress theme to New Wordpress theme - Prelude 19
  • Target version set to 1.15.8

Thanks for fixing this up. We release on the second and fourth Tuesdays of each month, and the next scheduled release is next Tuesday, August 27. Can you remind me of your deadline for this project? I can likely arrange a more immediate deployment, perhaps sometime tomorrow, but only if it's critical.

#5 Updated by Moeinedin Shashaei 12 months ago

The launch is set to be Sep 1. It would be great to have this up tomorrow so I have time to get feedback and if necessary update it one more time to be released on the 27th.
Thanks a lot.

#6 Updated by Boone Gorges 12 months ago

I've added the theme to the repo and deployed to the production site. Internal reference: https://github.com/cuny-academic-commons/cac/commit/a09b06b5c765c31401810c70b539d9cd09609ada

The theme is enabled, but not activated, on https://preludenyc19.commons.gc.cuny.edu/presents/.

Regarding testing and feedback, I strongly suggest that in future years, you set up a separate space where the stakeholders can review prior to deployment on the Commons. I am happy to push bugfixes and other updates as part of the next scheduled release, but it's not generally possible for me to make exceptions to that schedule as I have in the current case.

#7 Updated by Moeinedin Shashaei 12 months ago

Thank you very much Boone. Your extracurricular work is greatly appreciated.

I inherited from my predecessor Alex, a segalcenterdigital.org exactly as that separate space (I do not know how much you are involved in that back, if at all) which crashed on me halfway and I hope to get to see what exactly is wrong with it as soon as I am done with Prelude 2019.

#8 Updated by Boone Gorges 12 months ago

Thank you!

#9 Updated by Moeinedin Shashaei 12 months ago

Dear Boone,

An updated version of the theme Prelude 19 is attached and we appreciate it if you can put it in the queue for tomorrow.

Thank you
Moein

#10 Updated by Boone Gorges 12 months ago

  • Status changed from Reporter Feedback to Assigned

Sure thing, I'll include it. Thanks!

#11 Updated by Moeinedin Shashaei 12 months ago

Thank you :)

#12 Updated by Boone Gorges 12 months ago

  • Status changed from Assigned to Resolved

Updated in https://github.com/cuny-academic-commons/cac/commit/c5c06456249a0e42d599a3965711c8606a304aa3. The new theme will be live on the site within the hour.

#13 Updated by Moeinedin Shashaei 11 months ago

Hello Boone,

The updated Prelude19 is attached. I hope that I am on time for it.

Thank you

#14 Updated by Boone Gorges 11 months ago

Updated in https://github.com/cuny-academic-commons/cac/commit/87750ca5612d5c360390943ecdb563d971e2d0e4. It will be part of the 1.15.9 release, within the next hour or so.

#15 Updated by Moeinedin Shashaei 11 months ago

Thanks Boone,

There is one problem left that I can not figure out. The Schedule page a.k.a front page of preludenyc19.commons.gc.cuny.edu is missing the timeline! It should look just like the preludenyc18.commons.gc.cuny.edu. It is especially weird since both the site and the theme are basically clones of the site and the theme from last year.

Do you have any clues why this is happening and how it could be fixed?

(Might be obvious for you, but in the https://preludenyc19.commons.gc.cuny.edu/wp-admin/edit.php?post_type=page , if you wanted to check the schedule / front page do not view since the homepage is redirected to the splash page, but preview)

#16 Updated by Boone Gorges 11 months ago

I'm seeing a fatal error:

Fatal error:  Uncaught Error: Call to a member function format() on null in /var/www/html/commons/www/wp-content/themes/prelude19/front-page.php:279
Stack trace:
#0 /var/www/html/commons/www/wp-includes/template-loader.php(78): include()
#1 /var/www/html/commons/www/wp-blog-header.php(19): require_once('/var/www/html/c...')
#2 /var/www/html/commons/www/index.php(17): require('/var/www/html/c...')
#3 {main}
  thrown in /var/www/html/commons/www/wp-content/themes/prelude19/front-page.php on line 279

This points to the following line:

$first_hour = $first_time->format('Hi');

You'll need to debug why an item might not have a $first_time - I see some foreach logic just above that but I don't fully understand the cases where it might fail.

#17 Updated by Moeinedin Shashaei 11 months ago

Thanks for the catch!

Ok — back to the keyboard

#18 Updated by Moeinedin Shashaei 11 months ago

Hi Boone,

That last issue got resolved when we just reenter the dates and times of each event in the back! I have no idea how! Does it make any sense to you?

There is another bug that I just found in the front-page.php:

The --> in line 149 should be moved to line 148. In other words the comment should end one </div> tag sooner.

so instead of


</div>
</div>-->

should be:


</div>-->
</div>

Is that an easy fix?

Thank you

#19 Updated by Boone Gorges 11 months ago

I've attached a diff of the change that I made to the theme. Let me know if this is incorrect.

This change will be live after our next release on Tuesday the 24th.

#20 Updated by Moeinedin Shashaei 11 months ago

Hi,

I am working on some other changes and will actually have an updated version of the theme by Monday, for the 24th release.
Just thought debugging could go live earlier. The festival is a bit more than 2 weeks away and everyone is antsy to see the front page polished.

#21 Updated by Boone Gorges 11 months ago

If you get me the changes sometime on Monday, it should be no problem to include them the next day.

As noted here and elsewhere, please keep in mind that the Commons is not set up for frequent, quick-turnaround deployment. Testing and QA should happen elsewhere, with the Commons used only as a production site.

I've made another exception in this case and deployed your most recent bug fix.

Also available in: Atom PDF