Project

General

Profile

Bug #12771

Blog name uniqueness check doesn't work during blog creation

Added by Boone Gorges over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Blogs (BuddyPress)
Target version:
Start date:
2020-05-08
Due date:
% Done:

0%

Estimated time:

Description

During site creation, there's an AJAX request to verify that a site slug is unique. It's now broken: there's no wp_ajax callback available on the server for this.

I don't know how it got broken, and git -S is, for some reason, not turning up any results for its removal. But I know I'm not crazy: https://github.com/cuny-academic-commons/cac/blob/7dae274013d3fa482693475107a7b354db8fad54/wp-content/themes/bp-nelo/functions.php#L1085

We should probably reintroduce something like this. Maybe Jeremy has an idea about whether there's a core endpoint that makes more sense than a bespoke wp_ajax callback.


Related issues

Related to CUNY Academic Commons - Feature #12134: Site cloningResolved2019-11-22

History

#1 Updated by Boone Gorges over 1 year ago

#2 Updated by Boone Gorges over 1 year ago

  • Target version changed from 1.17.0 to 1.17.1

Let's try to get this for the first maintenance release after 1.17.0. Jeremy, could you please let me know what you think about a custom endpoint vs one built into core?

#3 Updated by Boone Gorges about 1 year ago

  • Target version changed from 1.17.1 to 1.17.2

#4 Updated by Boone Gorges about 1 year ago

  • Status changed from New to Staged for Production Release

This has now been fixed: https://github.com/cuny-academic-commons/cac/commit/671bf7e298b5fedbd4615ea39fe940faaf860f2f It was a bit tricky because we have some other blogname validation that takes place directly in the client - validity, length, stuff like that. To ensure consistency between in-browser and AJAX validation, I abstracted the way that the form-disabling and error-markup-building was done.

#5 Updated by Boone Gorges about 1 year ago

  • Status changed from Staged for Production Release to Resolved

Also available in: Atom PDF