Support #12772
closedHelp with embed codes for JITP article
0%
Description
We have an article for an upcoming issue that has embed codes for iframes that are not working.
The article is on the JITP staging site here: https://jitpstaging.commons.gc.cuny.edu/representing-indigenous-histories-using-xr-technologies-in-the-classroom/
There are placeholder images for where the iframes should be. We need shortcodes that will work on the Commons so that the iframe display correctly.
Here are the embed codes in question:
Figure 1: <iframe width="100%" height="480px" src="https://poly.google.com/view/bJVoiV0LPL-/embed?chrome=min" frameborder="0" style="border:none;" allowvr="yes" allow="vr; xr; accelerometer; magnetometer; gyroscope; autoplay;" allowfullscreen mozallowfullscreen="true" webkitallowfullscreen="true" onmousewheel="" ></iframe>
Figure 2: <div class="sketchfab-embed-wrapper">
<iframe title="A 3D model" width="640" height="480" src="https://sketchfab.com/models/6a80e857e6c448b196c0ddaa52c403e2/embed?preload=1&ui_controls=1&ui_infos=1&ui_inspector=1&ui_stop=1&ui_watermark=1&ui_watermark_link=1" frameborder="0" allow="autoplay; fullscreen; vr" mozallowfullscreen="true" webkitallowfullscreen="true"></iframe>
<p style="font-size: 13px; font-weight: normal; margin: 5px; color: #4A4A4A;">
<a href="https://sketchfab.com/3d-models/phoenix-button-6a80e857e6c448b196c0ddaa52c403e2?utm_medium=embed&utm_source=website&utm_campaign=share-popup" target="_blank" style="font-weight: bold; color: #1CAAD9;">Phoenix Button</a>
by <a href="https://sketchfab.com/scu-chl?utm_medium=embed&utm_source=website&utm_campaign=share-popup" target="_blank" style="font-weight: bold; color: #1CAAD9;">SCU Community Heritage Lab</a>
on <a href="https://sketchfab.com?utm_medium=embed&utm_source=website&utm_campaign=share-popup" target="_blank" style="font-weight: bold; color: #1CAAD9;">Sketchfab</a>
</p>
</div>
Please let me know if any other information is needed. Thanks!
Files
Updated by Boone Gorges almost 4 years ago
- Status changed from New to Staged for Production Release
- Target version set to 1.16.11
This has been added in https://github.com/cuny-academic-commons/cac/commit/75be0c2476ae7bda2fc04c4fedea62585f1910c3. The shortcodes are [jitp-lueck-1] and [jitp-lueck-2]. They'll be part of the next scheduled release, which is on Tuesday, May 12.
Updated by Boone Gorges almost 4 years ago
- Status changed from Staged for Production Release to Resolved
Updated by Laura Kane almost 4 years ago
Hi Boone,
Something seems to be wrong with the second shortcode [jitp-lueck-2]. When inserted into the text editor and previewed, it wraps the entire article and displays this code: div class="sketchfab-embed-wrapper">.
I've attached a screenshot.
Updated by Boone Gorges almost 4 years ago
Sorry about the issue, Laura. There was a typo in the shortcode implementation. I've fixed it in https://github.com/cuny-academic-commons/cac/commit/a125841801a0e1d5c00c384678ecb20e2ad334a8 and pushed to the production site. Could you please test again?
Updated by Laura Kane almost 4 years ago
Hi Boone,
I have one more request related to the short codes. If possible, is there a way to hard-code them so that they align center, or that they at least don't override the figure class alignment (which is centered)?
Thank you!
Updated by Boone Gorges almost 4 years ago
I've done the following:
1. In https://jitpstaging.commons.gc.cuny.edu/wp-admin/post.php?post=6471&action=edit&classic-editor, I added the jitp-shortcode-embed class to the figure tags that surround the embeds.
2. At https://jitpstaging.commons.gc.cuny.edu/wp-admin/customize.php?return=%2Fwp-admin%2Fpost.php%3Fpost%3D6471%26action%3Dedit%26classic-editor, I added some CSS that causes text in these elements to be centered.
Does that do it?
Updated by Laura Kane almost 4 years ago
It says your currently editing the post, and in preview it doesn't look any different.
Updated by Boone Gorges almost 4 years ago
Try editing again. Maybe it took a minute for the lock to clear.
If you're still seeing issues, could you please provide screenshots, along with some information about your browser setup? Also, be sure that you're doing a hard-refresh in your browser, and note that I've modified the staging site only. https://jitpstaging.commons.gc.cuny.edu/representing-indigenous-histories-using-xr-technologies-in-the-classroom/
Updated by Laura Kane almost 4 years ago
Okay, I see it now - it looks great! Thank you, Boone! :D