Project

General

Profile

Bug #13135

bp-groupblog plugin update wiped out local mods

Added by Boone Gorges over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Site cloning
Target version:
Start date:
2020-08-01
Due date:
% Done:

0%

Estimated time:

Description

During the lead-up to 1.17.0, I updated all public plugins. During this, I neglected to note that Jeremy had made some local changes to bp-groupblog. See https://github.com/cuny-academic-commons/cac/commit/4c133f37c2897b2c9cbb9c7670e2543591b87fda#diff-86b6ffca61ab0fff092898d4c1190f9c, https://github.com/cuny-academic-commons/cac/commit/5aea35fc224065004ae57cb6791c0a67c9bc62a0#diff-86b6ffca61ab0fff092898d4c1190f9c, and https://github.com/cuny-academic-commons/cac/commits/1.17.x/wp-content/plugins/bp-groupblog more generally. As such, after the 1.17.0 launch, Group+Site cloning was not working properly.

I've reverted the wordpress.org plugin update https://github.com/cuny-academic-commons/cac/commit/02f28057934982479dfd3871c3ed74ad126c551a#diff-86b6ffca61ab0fff092898d4c1190f9c, deployed the revert as a hotfix, and added bp-groupblog to the list of plugins that should not be updated as part of my wp-cli-cac toolkit. But we should figure out a way, if possible, to move the mods out of bp-groupblog.

This is mainly about catching a form request with a specific radio button value, so it should be doable. Jeremy, could you have a look? See https://github.com/cuny-academic-commons/cac/blob/1.17.x/wp-content/plugins/cac-bp-custom-includes/groupblog.php for some other places where we override bp-groupblog functionality.

History

#1 Updated by Boone Gorges over 1 year ago

  • Target version changed from 1.17.1 to 1.17.2

#2 Updated by Boone Gorges over 1 year ago

  • Target version changed from 1.17.2 to 1.17.3

#3 Updated by Boone Gorges over 1 year ago

  • Status changed from New to Resolved

Also available in: Atom PDF