Bug #14142
closedCan't add Twitter widget to profile
0%
Description
I tried to add the Twitter widget to my CAC profile a few times. When I hit save, it goes away.
Files
Updated by Boone Gorges about 3 years ago
Are you filling in a title for the widget? See screenshot, where it says 'TWITTER'.
Updated by Raffi Khatchadourian about 3 years ago
I tried with and without the widget title. Both didn't save.
Updated by Boone Gorges about 3 years ago
Seems to be working OK for me. I can see a number of places where things might go wrong. It might be helpful if you could share a short video of what you're doing. You might also consider opening your browser console to see if there are any obvious errors that might give me a place to begin investigating.
Updated by Raffi Khatchadourian about 3 years ago
Updated by Raffi Khatchadourian about 3 years ago
Boone Gorges wrote:
Seems to be working OK for me. I can see a number of places where things might go wrong. It might be helpful if you could share a short video of what you're doing. You might also consider opening your browser console to see if there are any obvious errors that might give me a place to begin investigating.
No errors that I can see.
Updated by Boone Gorges about 3 years ago
Thanks for the additional info. Marilyn, would you mind seeing whether you can reproduce Raffi's problem on your own profile? I'm not sure where to go next without reproducible steps.
Updated by Raffi Khatchadourian about 3 years ago
Sorry, I am not very good with the screen recordings. I've attached one. It's a bit fast, so you may need to pause it (sorry about that). It can be played with the VLC video player, which is free to download.
Updated by Boone Gorges about 3 years ago
Thanks, this is helpful. I'm not seeing the same behavior in my own case, but hopefully Marilyn can reproduce so that I can have something to test with.
Updated by Marilyn Weber about 3 years ago
I am able to reproduce this problem. It worked the first time when I entered MarilynWeberGC. Then I noticed that Raff didn't use the , so I tried again without it. Now, whether I use the @ or not, it will not stick - exactly as Raffi's video shows.
Updated by Marilyn Weber about 3 years ago
Wait, what! I see my reply above has left out the AT symbol before my name, which kinda was the whole point. It worked with the AT symbol. Then I tried without and it didn't work. So I tried again with and that didn't fix it. Trying one final time didn't work either.
I'm going to guess I am hard to follow here. I will try this with another identity (username conduit) and I will record it.
Updated by Marilyn Weber about 3 years ago
- File Screen Recording 2021-03-09 at 6.57.34 PM.mov Screen Recording 2021-03-09 at 6.57.34 PM.mov added
Here is my recording. It seems that you can add Twitter to your profile only once. If you remove it, then try again, it won't stick.
Updated by Boone Gorges about 3 years ago
- Status changed from New to Reporter Feedback
- Target version set to 1.18.7
Thanks, Marilyn. I had to test a couple different user accounts but I was finally able to reproduce.
The root issue is kind of in-the-weeds, having to do with the fact that the Twitter widget's data is stored using a WP function that returns false if you call it using the same data as what's already stored in the database, which the profile plugin was interpreting as a failed save. As such, if you had a Twitter widget on your profile, then deleted it, then tried to add the very same widget, it would fail in the way described here. I've fixed the issue in https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/c3da281354864bfc26fb56d1f526d6ec481eed35 and pushed to the production site if you'd like to give it a test.
Updated by Raffi Khatchadourian about 3 years ago
Marilyn Weber wrote:
Wait, what! I see my reply above has left out the AT symbol before my name, which kinda was the whole point. It worked with the AT symbol. Then I tried without and it didn't work. So I tried again with and that didn't fix it. Trying one final time didn't work either.
I'm going to guess I am hard to follow here. I will try this with another identity (username conduit) and I will record it.
Ha. I would not have thought to use the AT symbol. I believe that the prompt just asks for a username.
Updated by Raffi Khatchadourian about 3 years ago
Boone Gorges wrote:
Thanks, Marilyn. I had to test a couple different user accounts but I was finally able to reproduce.
The root issue is kind of in-the-weeds, having to do with the fact that the Twitter widget's data is stored using a WP function that returns false if you call it using the same data as what's already stored in the database, which the profile plugin was interpreting as a failed save. As such, if you had a Twitter widget on your profile, then deleted it, then tried to add the very same widget, it would fail in the way described here. I've fixed the issue in https://github.com/cuny-academic-commons/cac-advanced-profiles/commit/c3da281354864bfc26fb56d1f526d6ec481eed35 and pushed to the production site if you'd like to give it a test.
It works! Thanks, guys!
Updated by Boone Gorges about 3 years ago
- Target version changed from 1.18.7 to 1.18.8
Updated by Boone Gorges about 3 years ago
- Target version changed from 1.18.8 to 1.18.9
Updated by Boone Gorges almost 3 years ago
- Target version changed from 1.18.9 to 1.18.10
Updated by Boone Gorges almost 3 years ago
- Status changed from Reporter Feedback to Resolved