Project

General

Profile

Actions
Copy link

Support #15211

closed

No good error reporting for already-used domain name when creating a site in Firefox

Added by Marilyn Weber almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
Blogs (BuddyPress)
Target version:
1.19.2
Start date:
2022-01-21
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Boone -

Matt asked me to report this:

From
Bakaitis, Elvis
Today ‪12:47 pm‬

Hi -I'm trying to create a new site to demo with the Open Pedagogy Fellows today, but it keeps bouncing me back to "create a site," after I click the submit button. Is there a bug, or something with my computer...thank you! - Elvis

From
Bakaitis, Elvis
Today ‪12:53 pm‬

Hi Marilyn,

Thank you so much for your quick response.

I opened in Safari instead of Firefox, and got it to work. Basically the error message "this site title is already taken" was not appearing in Firefox, it just bounced me back up to the top of the page when I clicked "create a site."

In Safari, the message was visible so I corrected and could continue.

Thank you!

Sincerely,

Elvis

Actions
Copy link
 #1

Updated by Marilyn Weber almost 3 years ago

He writes "That error message should show regardless of the browser used, so there might be a bug here that we should fix."

Actions
Copy link
 #2

Updated by Boone Gorges almost 3 years ago

  • Subject changed from browser bug? to No good error reporting for already-used domain name when creating a site in Firefox
  • Category name set to Blogs (BuddyPress)
  • Status changed from New to Staged for Production Release
  • Assignee set to Boone Gorges
  • Target version set to 1.19.2

I wasn't able to reproduce a Firefox/Safari issue. But the behavior described suggests that something on Elvis's setup prevented the validation JavaScript from running on Firefox. In turn, the server-side validation worked (by not allowing a site to be created with a duplicate domain) but the error message was not being properly shown on page refresh.

In https://github.com/cuny-academic-commons/cac/commit/3e33f0ba4589787306ceea1082bf12f1a9cfe0df I've ensured that, in cases where JS validation doesn't work for some reason, that the errors are shown properly on page refresh, in a similar style (red italic text).

Actions
Copy link
 #3

Updated by Boone Gorges almost 3 years ago

  • Status changed from Staged for Production Release to Resolved
Actions
Copy link

Also available in: Atom PDF