Project

General

Profile

Actions
Copy link

Bug #24295

closed

Lock PHPCompatibility library to specific commit

Added by Jeremy Felt about 2 months ago. Updated 17 days ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Jeremy Felt
Category name:
Internal Tools and Workflow
Target version:
Not tracked
Start date:
2026-01-26
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

The PHPCompatibility package dropped support for PHPCS < 4.0 back in November. See: https://github.com/PHPCompatibility/PHPCompatibility/pull/2009

We previously locked ourselves to the develop branch of that package because it's the way to provide support for the latest version of PHPCompatibilityWP. See: https://github.com/PHPCompatibility/PHPCompatibilityWP/issues/40#issuecomment-1139623926, https://redmine.gc.cuny.edu/issues/18496

To maintain the house of cards, we now need to mark the last compatible commit of PHPCompatibility as version 9.99.9 so that we continue to satisfy other dependencies and can update other PHPCS related packages.

Actions
Copy link
 #1

Updated by Jeremy Felt about 2 months ago

I've made this change in https://github.com/cuny-academic-commons/cac/commit/559c7aceb433bf78285a6d339e63b5e6d76850f5

Leaving this ticket open for at least brief visibility. :)

Actions
Copy link
 #2

Updated by Boone Gorges about 2 months ago

House of cards indeed. Thanks, Jeremy!

Actions
Copy link
 #3

Updated by Boone Gorges 17 days ago

  • Category name set to Internal Tools and Workflow
  • Status changed from New to Resolved
  • Target version set to Not tracked
Actions
Copy link

Also available in: Atom PDF