Feature #2505
closedAdd custom theme
0%
Description
I was wondering if I could add a custom theme that I've been working on. It's hosted on github here: https://github.com/kaymmm/mellontheme and can be downloaded as a .zip here: https://github.com/kaymmm/mellontheme/archive/master.zip
It is a child theme of twentytwelve.
I'm still working on development (and will bump version numbers as I go) but it should be ready to deploy...at least for the sites that I maintain.
Thanks!
Updated by Boone Gorges about 11 years ago
- Status changed from New to Assigned
- Assignee set to Boone Gorges
- Target version set to 1.4.21
I'll review this for the next Commons release. Keith, is that Github repo going to be the permanent home of the theme? I'd like to use git submodules for this.
Updated by Keith Miyake about 11 years ago
cool.
yes, git will be the permanent home for the theme as long as i'm maintaining it.
out of curiosity, if you're using submodules, will they get refreshed with every release or only when I add a ticket/bump this thread?
Updated by Boone Gorges about 11 years ago
yes, git will be the permanent home for the theme as long as i'm maintaining it.
Great, thanks.
if you're using submodules, will they get refreshed with every release or only when I add a ticket/bump this thread?
Submodules are pinned to a specific changeset. So it'll only be updated when you tell me that you're ready for me to point to a new one.
Updated by Boone Gorges about 11 years ago
- Status changed from Assigned to Resolved
Hi Keith. I've added the theme to our repo at https://github.com/castiron/cac/commit/b4bed4537e43077a1b5dc8270efa66ba10528501
For now, it's not a submodule. I need a version of the theme that doesn't use the shorthand for opening PHP blocks. I've sent you a pull request on Github with the necessary changes. Once you've made them, please leave a note here, and I can change our internal reference so that it's a submodule instead of a checkout of my fork.
Updated by Boone Gorges about 11 years ago
Keith - Could you verify for me which blog you'd like to have access to the theme?
Updated by Keith Miyake about 11 years ago
globalization, cpcp, studyofreligion, gcsciencestudies, and keithmiyake
also, I committed your changes to the php tags. thanks!
Updated by Boone Gorges about 11 years ago
Thanks, Keith. I've enabled the theme for each of those sites.
I also switched out the theme so that we're now pulling from your Github repo as a submodule (at rev 76ab2388f516da8260b7bf4329fab75fe10e00e5). Feel free to ping me when you need this reference updated to a new changeset. Please keep in mind that we release on the 1st, 11th, and 21st of each month, and it'd be nice to have a few days' warning so I can look over changes. Thanks :)
Updated by Keith Miyake about 11 years ago
boone, can you bump to the newest version (b3be7a9404a46d9c87e293fb8ff4be659bcd0467) as soon as possible because it (should) fix a jquery error that popped up when I activated the theme on the commons. thanks!
Updated by Boone Gorges about 11 years ago
Hi Keith - Can you open a request in a new ticket, with the target version 1.4.22? Thanks.