Project

General

Profile

Actions

Bug #2531

closed

mellontheme submodule not pulling in its submodules

Added by Keith Miyake over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority name:
Immediate
Assignee:
Category name:
-
Target version:
Start date:
2013-04-02
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

I have a submodule dependency in the theme that needs to get added/initialized recursively from my my theme. The way it's currently included as a commons submodule leaves my submodule directory empty.

see: http://stackoverflow.com/questions/1535524/git-submodule-inside-of-a-submodule

Right now my sites are not accessible because I have php requires on the submodule in my theme.

Actions #1

Updated by Boone Gorges over 9 years ago

  • Status changed from New to Reporter Feedback
  • Assignee set to Boone Gorges
  • Target version set to Not tracked

Sorry about that, Keith. I've done a recursive update. Please check again.

Actions #2

Updated by Keith Miyake over 9 years ago

phew! thanks, boone. at least now i know that i need to fix the sanity checks in functions.php so that i don't lock myself out again!

Actions #3

Updated by Boone Gorges over 9 years ago

  • Status changed from Reporter Feedback to Resolved

Yeah, some sort of failsafe check is probably a smart idea, especially if you're just using the external lib for secondary stuff (sanitization, saving settings, etc).

But this one's my fault :) You're our first guinea pig with the submodule setup. We just have to get the workflow down. Thanks for your patience.

Actions

Also available in: Atom PDF