Project

General

Profile

Actions

Support #2532

closed

one more bump on mellontheme

Added by Keith Miyake about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority name:
High
Assignee:
Category name:
-
Target version:
Start date:
2013-04-02
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

sorry boone, i left in a php short tag that broke the theme so that content wasn't showing up when it went live.

took me a while to nail down the issue but finally got it sorted and added to the latest commit: 60b882a684ca7ac7e50e438858ca2fa24a1266f7

i changed the short tag setting in my dev environment so i should catch these in the future.

Actions #1

Updated by Boone Gorges about 11 years ago

  • Status changed from New to Assigned
  • Assignee set to Boone Gorges
  • Target version set to 1.4.25

I did a live switch of the commit hash. In the future, let's please be very careful about this stuff - I like to keep a strict release schedule, and am making an exception in this case as payback for my screwup yesterday :)

I'm leaving the ticket open so that I fix it in the repo for the next release.

Actions #2

Updated by Keith Miyake about 11 years ago

Thanks, Boone. I completely understand your concern.

Here's my problem right now: Even after you did the update, my sites are still not rendering properly and I'm pretty sure that it's because one of my theme's php scripts is failing out silently, and I'm almost certain I know which one it is. On my development site everything seems to be working fine and I don't get any php errors, even after forcing full php tags and including all of the same plugins as on the live site.

Would it be possible to send me a copy of the php.ini that is being used on the commons server so that I can make sure that my development server more closely mirrors the live one and I don't keep running into problems that I can't reproduce locally? Or any other suggestions you have for debugging would be greatly appreciated.

Actions #3

Updated by Boone Gorges about 11 years ago

I'll see what I can do about getting you a copy of the php.ini file (or seeing if I can think of any better ideas). In the meantime, can you send me a link to the specific page that's causing problems, with a description of what's wrong?

Actions #4

Updated by Keith Miyake about 11 years ago

Any page on this site: http://globalization.gc.cuny.edu/ that calls my customized content.php is erroring out, but pages that use any other loop template load fine. I thought the problem was simply my use of a php shortcode (which was also a problem), but fixing that didn't fix the page load issue on the live server.

What should be happening is in the main loop it should load a bunch of posts and display them blog style. It errors out after loading everything up to the main loop.

Right now I'm trying to debug using the samsarin php widget and an error handling function and am just stepping through the code line by line...

Actions #5

Updated by Keith Miyake about 11 years ago

figured out my problem.

I was cheating by referencing a function-array (eg foo()[$index]) instead of assigning a temp variable first. My server is running php 5.4 which allows this, while the commons is on 5.3.3, which doesn't allow it.

the commit that fixes this problem is hash 4defa49742d5d7f48fff2e40f0846f7838b53e71

Sorry for all of the headaches. I appreciate your help, Boone.

Actions #6

Updated by Boone Gorges about 11 years ago

I just found the same thing, and was blocked in posting because you found it a minute earlier.

I've put in a hotfix, and will update the reference for the next release. Glad we could track down the issue.

Actions #7

Updated by Boone Gorges about 11 years ago

  • Status changed from Assigned to Resolved
  • Target version changed from 1.4.25 to 1.4.24
Actions

Also available in: Atom PDF