Project

General

Profile

Actions

Support #2569

closed

sites broken: need a bump on submodule

Added by Keith Miyake almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority name:
Urgent
Assignee:
-
Category name:
-
Target version:
Start date:
2013-05-15
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

hi, this was a weird one.
these sites are all broken and fail to load (php/serverside error):
studyofreligion.gc.cuny.edu
pcp.gc.cuny.edu
globalization.gc.cuny.edu

all three sites are using my mellontheme, whose codebase hasn't changed in over a month. but there was an upstream git change that killed one of my submodule references, and this in turn killed the theme when it was updated with the most recent commons update the other day. it was confusing. but everything is fixed in my git repository now.

i know this is off cycle, but since all three sites are currently broken, would it be possible to immediately update the submodule for the mellontheme at git://github.com/kaymmm/mellontheme.git to commit babbf2d1d208c5e26b2f19f4d7053eb4f4d4fa1e

much appreciation for your work.

Actions #1

Updated by Boone Gorges almost 11 years ago

  • Status changed from New to Reporter Feedback

Hi Keith. I'm not quite sure how anything would have been modified on the Commons, given that the module changeset for mellontheme wasn't modified. But in any case, I did try running the update, and got an error that "reference is not a tree: 942f8a18d0ef7638b7790d0b94728859d1d7d52e" on redux-framework. I checked on Github and I don't see that changeset in the tree: https://github.com/kaymmm/Redux-Framework/commit/942f8a18d0ef7638b7790d0b94728859d1d7d52e

Can you double check the reference please?

Actions #2

Updated by Keith Miyake almost 11 years ago

that is strange. when i just checked https://github.com/kaymmm/Redux-Framework/commit/942f8a18d0ef7638b7790d0b94728859d1d7d52e it shows the upstream commits that have been merged, and that is the same submodule reference point that is included in the mellontheme repository: https://github.com/kaymmm/mellontheme/commit/babbf2d1d208c5e26b2f19f4d7053eb4f4d4fa1e

i'm pretty sure that everything is in sync with the published repositories...

on a different computer i just cloned the repo in a fresh directory and everything seemed to run smoothly:

$ git clone https://github.com/kaymmm/mellontheme.git
Cloning into 'mellontheme'
...
$ git submodule init
Submodule 'inc/redux-framework' (git://github.com/kaymmm/Redux-Framework/) registered for path 'inc/redux-framework'
$ git submodule update
Cloning into 'inc/redux-framework'...
...
Submodule path 'inc/redux-framework': checked out '942f8a18d0ef7638b7790d0b94728859d1d7d52e'

it seems redundant, but can you try running git submodule update one more time to see if it still fails for you?

Actions #3

Updated by Boone Gorges almost 11 years ago

Now I see that the changeset exists. Looks like it was a merge commit - maybe you hadn't pushed it to github?

I ran the submodule update and things seem to be working correctly now. Let me know if you have more problems.

Actions #4

Updated by Keith Miyake almost 11 years ago

  • Status changed from Reporter Feedback to Resolved

Yeah, I'm not sure what the issue was since I didn't have to push anything after your feedback, but looks like everything is fixed. Thanks a lot Boone!

Actions #5

Updated by Boone Gorges almost 11 years ago

  • Target version set to 1.4.28

No problem - thanks for working through it with me.

Actions

Also available in: Atom PDF