Project

General

Profile

Actions
Copy link

Feature #4052

closed

Add room number field for events

Added by Boone Gorges over 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
Events
Target version:
1.10
Start date:
2015-05-12
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Where should it go? If it's part of Venue, then we'll have different venues for each room number. So, presumably, separate.

Assigning to Sam for suggestions.

Files

Download all files
Screen Shot 2015-05-12 at 4.34.19 PM.png (196 KB) Screen Shot 2015-05-12 at 4.34.19 PM.png Samantha Raddatz, 2015-05-12 04:36 PM
Screen Shot 2016-03-29 at 1.13.47 PM.png (23.9 KB) Screen Shot 2016-03-29 at 1.13.47 PM.png Samantha Raddatz, 2016-03-29 01:18 PM
Actions
Copy link
 #1

Updated by Samantha Raddatz over 9 years ago

Yes, as long as we keep the auto-fill/dropdown for the building addresses it should be separate. Such as:

Venue: (auto-fill/dropdown for building address)
Room: (open-text field)
(Map)

See attached for a proposed layout.

I originally thought the text field should be titled "Room number", but an event could take place in an auditorium or other space that doesn't have a room number assigned to it.

Actions
Copy link
 #2

Updated by Boone Gorges over 9 years ago

Thanks, Sam. This seems good to me. Is it worth having an "optional" label on Venue and Room?

Actions
Copy link
 #3

Updated by Samantha Raddatz over 9 years ago

Currently, all of the fields are technically optional, so I don't think there's any need to state that these are.

We may want to consider making some fields required so that people aren't posting blank or partially-entered events (though blank events that are published don't appear in the calendar), in which case anything optional should be labeled as such.

Actions
Copy link
 #4

Updated by Samantha Raddatz almost 9 years ago

  • Assignee changed from Samantha Raddatz to Boone Gorges

Moving the assignment of this from me back to Boone.
Boone -- let me know if you need any more input from me here.

Actions
Copy link
 #5

Updated by Boone Gorges almost 9 years ago

  • Target version changed from Future release to 1.10

Cool, let's do this for 2.0. It should be an easy win.

Actions
Copy link
 #6

Updated by Boone Gorges almost 9 years ago

  • Category name changed from Events to 136
Actions
Copy link
 #7

Updated by Boone Gorges over 8 years ago

  • Category name changed from 136 to Events
Actions
Copy link
 #8

Updated by Boone Gorges over 8 years ago

  • Status changed from Assigned to Testing Required

This is ready to test on cdev. See http://cdev.gc.cuny.edu/members/boonebgorges/events/kegger/

The relevant changeset is https://github.com/cuny-academic-commons/bp-event-organiser/commit/35adce69311a6fc0011193eb2138daccaa4f73d3, though I had to make a hotfix to event-organiser to make it work on CAC. I've opened a PR so that this hotfix can be deprecated with the next version of EO. https://github.com/stephenharris/Event-Organiser/pull/350

Actions
Copy link
 #9

Updated by Samantha Raddatz over 8 years ago

Thanks, Boone! I tested it out and the room functionality works great.
The map was acting weird though -- when I chose the Graduate Center from the dropdown it dropped a pin in some random place in the middle of an ocean (screenshot attached). Not sure if this is a cdev bug or related to the changes you made, but I figure it's of note.

Actions
Copy link
 #10

Updated by Boone Gorges over 8 years ago

  • Status changed from Testing Required to Resolved

Thanks, Sam!

Yeah, the bad GC address is a data-related bug that I introduced to cdev when doing some testing there. Ignore it :)

Actions
Copy link

Also available in: Atom PDF