Project

General

Profile

Bug #8870

Archive Pages on JADT site not working

Added by Alex Hills almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
WordPress Themes
Target version:
Start date:
2017-10-29
Due date:
% Done:

0%

Estimated time:

Description

Hi Boone,

For some reason archive pages on http://jadtjournal.org/ are not displaying posts. Here is an example: http://jadtjournal.org/category/current-issue/. I understand that this site was built before my time working with the Segal Center using a child theme based on the Thematic theme. The Thematic team has since stopped making updates to their theme and I believe that we are beginning to see some incompatibility issues crop up as WP continues to evolve and their theme has remained dormant. The strange thing is that the JADT theme is working fine on our dev server here: http://segalcenterdigital.org/WPdev/jadtdev/. It seems like the settings are all the same and all the plugins and themes are updated to their latest versions. Any thoughts as to why the archive pages might not be working on the commons? I will likely recommend to the Segal Center that all themes that utilize Thematic be redesign as independent themes but I was wondering if we might be able to get this site working while we develop replacement themes.

Thanks,
Alex

jadt.diff (1.58 KB) jadt.diff Boone Gorges, 2017-10-30 11:21 AM

History

#1 Updated by Boone Gorges almost 2 years ago

  • File jadt.diff jadt.diff added
  • Status changed from New to Reporter Feedback
  • Target version set to 1.12.1

Hi Alex - It appears that the issue here is something breaking in the child theme rather than Thematic itself. I didn't take the time to look into exactly why it broke, but it appears that the query_posts() call in the child theme's category loop override function stopped working at some point. I've attached a diff that shows how I moved the same logic into a pre_get_posts callback. Can you review the diff and the site and let me know whether it seems OK to you?

#2 Updated by Alex Hills almost 2 years ago

Thanks Boone. Really appreciate you working on a fix. Everything seems to be working correctly now and the fix makes perfect sense.

#3 Updated by Boone Gorges almost 2 years ago

  • Status changed from Reporter Feedback to Resolved

Thanks for confirming, Alex. I've added the change to the repo in https://github.com/cuny-academic-commons/cac/commit/182b526bcef5326512c1f6de4ee3ab1f17fdcaab.

Also available in: Atom PDF