Project

General

Profile

Actions

Support #9728

closed

Commons Custom CSS

Added by Stephen Klein over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
-
Target version:
Start date:
2018-05-08
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

We just noticed that our Commons' site:
https://gclibrary.commons.gc.cuny.edu

Has somehow lost its custom CSS.

Not sure if it had to do with an upgrade or the migration last week.
It looks like it may have also reset some of our general theme settings.
Is there a way to recover the way it was?

We are using the Arras Theme.

Actions #1

Updated by Boone Gorges over 4 years ago

Thanks for the report, Stephen, and sorry for the issues.

This is indeed linked to yesterday's release, and the change in our custom CSS plugin. See #7811. The specific problem in your case is that the new plugin loads its CSS just a bit earlier than the old plugin, and as a result doesn't properly override all of the theme's styles. I've put a hotfix in place that appears to resolve the issue in the specific case of https://gclibrary.commons.gc.cuny.edu/. Could you have a look and confirm? A more permanent fix will be part of the release later today.

Regarding theme settings: Nothing in a recent update or migration should have touched any of your theme settings. If you're still seeing problems after the fix I've just put in place, can you please be specific about at least some of them so that I can investigate what might be happening?

Actions #2

Updated by Stephen Klein over 4 years ago

Thanks, Boone. I will report back to the group and see if they have anything else. Super appreciate your quick response.

Actions #3

Updated by Stephen Klein over 4 years ago

Folks have confirmed the site looks and behaves as it should. You could close and thank you so much.

Actions #4

Updated by Boone Gorges over 4 years ago

  • Status changed from New to Resolved
  • Target version set to 1.13.1

Thanks very much for the quick confirmation, Stephen, and for your team's patience.

A more permanent fix is in the repo in https://github.com/cuny-academic-commons/cac/commit/0ba913281d525a9c70869e0b975fa6079b01d7a0.

I've suggested a fix to the plugin author: https://wordpress.org/support/topic/load-css-later-on-wp_head/

Actions #5

Updated by Stephen Klein over 4 years ago

elegant solution

Actions

Also available in: Atom PDF