Project

General

Profile

Actions

Bug #9929

closed

External Group Blogs cron review

Added by Boone Gorges almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
WordPress Plugins
Target version:
Start date:
2018-06-14
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

A couple problems with External Group Blogs cron:

1. Up until a few minutes ago, the plugin was available to be activated on any site on the Commons. A few members had gone through and activated pretty much every single available plugin (a different problem!) and the Cavalcade logs show that the imports taking place on those sites are very slow. So the plugin should be hidden for users, and then removed from those sites.

2. The cron routine can be very long running. I'll see what can be done about breaking it into groups or even specific feeds.


Related issues

Related to CUNY Academic Commons - Feature #8987: Migrate away from wp-cronResolvedBoone Gorges2017-12-07

Actions
Actions #1

Updated by Boone Gorges almost 6 years ago

Actions #2

Updated by Boone Gorges almost 6 years ago

I've deactivate the plugin from the handful of sites where it was running.

The plugin has been hidden from plugins.php in https://github.com/cuny-academic-commons/cac/commit/70b53b807fff006476fd2caafb85e2acbac4cd71 and is effective immediately on the production site.

Actions #3

Updated by Boone Gorges almost 6 years ago

  • Status changed from New to Resolved

Looking more closely at how this plugin works, there are two feed refresh mechanisms.

1. When a group is loaded on the front end, the plugin detects whether the group has a fetch pending, and then sets up an AJAX routine to fetch feeds just for that group.
2. An hourly cron job runs to check feeds across all groups.

For some reason, the cron job (2) was running on secondary sites where the plugin was erroneously activated, but is not scheduled on site 1. Since it's the cron job that causes problems (it fetches feeds for all groups instead of a single one), and since we haven't gotten reports of problems related to this behavior, I think we can safely leave the cron job unscheduled on the main site.

While looking, I spotted a minor improvement to the plugin, which prevents the AJAX routine (1) when the current group has no feeds to fetch. See https://github.com/cuny-academic-commons/cac/commit/e2b0ae7e9ac0b11c5ed10f5f3da080327c4002fb

Actions

Also available in: Atom PDF