Project

General

Profile

Actions

Bug #10210

closed

Spacing wonky on invite screen

Added by Matt Gold almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Onboarding
Target version:
Start date:
2018-08-22
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Please see the attached screenshot, which shows a bit of wonky spacing on one of the invite modals

I'm on a Mac/Chrome


Files

Actions #1

Updated by Boone Gorges almost 6 years ago

The close spacing between the header and the paragraph is only reproducible at very specific window widths. I've added more spacing for these widths. The alignment between the header and the paragraph is also strange (not sure whether you meant one or the other or both by "spacing wonky"), but it's a result of larger issues related to this markup, and can't be easily fixed without a further design review.

I've put fixes in place that mitigate in most cases. See screenshot.

https://github.com/cuny-academic-commons/cac-onboarding/commit/254e49f3fe3d5137eea64152d07dad762eb53166
https://github.com/cuny-academic-commons/cac/commit/9e21ac65e5f3534d9d469af4d8952602086cf588

Actions #2

Updated by Matt Gold almost 6 years ago

Looks good. thanks, Boone.

Actions #3

Updated by Boone Gorges almost 6 years ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF