Project

General

Profile

Actions
Copy link

Bug #10985

closed

wp-smushit installer does bad things on its 3.0 upgrade routine

Added by Boone Gorges over 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Boone Gorges
Category name:
WordPress Plugins
Target version:
1.15.3
Start date:
2019-01-22
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

The upgrade to version 3.0+ of the wp-smushit plugin runs some settings upgrades, and it does it in a way that causes large amounts of overhead on the site. I've left details for the plugin author here: https://wordpress.org/support/topic/3-0-upgrade-routine-causes-extensive-database-overhead-on-ms-installs/

A temporary fix is in place on the Commons to prevent this upgrade routine from running. I'll leave it in place until the next Commons update, to confirm whether the authors have implemented a proper fix in their plugin.

Actions
Copy link
 #1

Updated by Boone Gorges about 5 years ago

  • Category name set to WordPress Plugins
  • Assignee set to Boone Gorges
  • Target version changed from 1.14.6 to 1.14.9

The wp-smushit plugin has been updated to version 3.1.1 in the last few days, and will not make it to CAC for a couple of releases, due to our major/minor system. Let's review as we get closer to that date. In the meantime, the temp fix remains in place.

Actions
Copy link
 #2

Updated by Boone Gorges about 5 years ago

  • Target version changed from 1.14.9 to 1.14.10

Looks like they did not fix the bug as I suggested, so I'm going to have to monkey patch it again. https://github.com/cuny-academic-commons/cac/commit/f3e7b35d06f1f625f958b57f368a0f4b8161013c

I'll see if I can do something more foolproof in a future release if they continue to refuse to fix the problem.

Actions
Copy link
 #3

Updated by Raymond Hoh about 5 years ago

  • Target version changed from 1.14.10 to 1.14.11
Actions
Copy link
 #4

Updated by Boone Gorges about 5 years ago

  • Target version changed from 1.14.11 to 1.15.1
Actions
Copy link
 #5

Updated by Boone Gorges almost 5 years ago

  • Target version changed from 1.15.1 to 1.15.2
Actions
Copy link
 #6

Updated by Boone Gorges almost 5 years ago

  • Target version changed from 1.15.2 to 1.15.3
Actions
Copy link
 #7

Updated by Boone Gorges almost 5 years ago

  • Status changed from New to Resolved

wp-smushit has still not fixed the underlying problem, but it appears that the upgrader has finished across all relevant sites, so I think there's nothing left to do here.

Actions
Copy link

Also available in: Atom PDF