Project

General

Profile

Actions
Copy link

Bug #11145

closed

Link Broken On RBE via MAC Mail Client

Added by Luke Waltzer about 5 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Raymond Hoh
Category name:
Reply By Email
Target version:
1.16.12
Start date:
2019-02-22
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

On this post -- https://commons.gc.cuny.edu/groups/cac-community-team-project-planning/forum/topic/fall-2018-spring-2019-meeting-schedule/#post-74284 -- sent via Mac Mail client the linked phrase "this one" was broken when email was posted to the forum.

Actions
Copy link
 #1

Updated by Raymond Hoh about 5 years ago

  • Category name set to Reply By Email
  • Assignee set to Raymond Hoh

Thanks Luke.

RBE uses the plain-text version of the email when parsing the email for the reply.

I just took a look at the plain-text version of your reply and this is what is shown:

I was in this one <https://commons.gc.cuny.edu/?p=3D70164> but just got =
booted.=20

The forum post shows this:

I was in this one <https://commons.gc.cuny.edu/?p=70164&gt; but just got booted.

I'll try and take a closer look at the parsing later on, but I'm guessing the triangular brackets or the plain-text line wrap might be the issue. It could be a forum formatting issue as well.

Related: https://core.trac.wordpress.org/ticket/40294

Actions
Copy link
 #2

Updated by Boone Gorges about 5 years ago

  • Target version set to 1.14.8
Actions
Copy link
 #3

Updated by Boone Gorges about 5 years ago

  • Target version changed from 1.14.8 to 1.14.9
Actions
Copy link
 #4

Updated by Boone Gorges about 5 years ago

  • Target version changed from 1.14.9 to 1.14.10
Actions
Copy link
 #5

Updated by Raymond Hoh about 5 years ago

  • Target version changed from 1.14.10 to 1.14.11
Actions
Copy link
 #6

Updated by Boone Gorges almost 5 years ago

  • Target version changed from 1.14.11 to 1.15.1
Actions
Copy link
 #7

Updated by Boone Gorges almost 5 years ago

  • Target version changed from 1.15.1 to 1.15.2
Actions
Copy link
 #8

Updated by Boone Gorges almost 5 years ago

  • Target version changed from 1.15.2 to 1.15.3
Actions
Copy link
 #9

Updated by Boone Gorges almost 5 years ago

  • Target version changed from 1.15.3 to 1.15.4
Actions
Copy link
 #10

Updated by Boone Gorges almost 5 years ago

  • Target version changed from 1.15.4 to 1.15.5
Actions
Copy link
 #11

Updated by Raymond Hoh almost 5 years ago

  • Target version changed from 1.15.5 to 1.15.6
Actions
Copy link
 #12

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.6 to 1.15.7
Actions
Copy link
 #13

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.7 to 1.15.8
Actions
Copy link
 #14

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.8 to 1.15.9
Actions
Copy link
 #15

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.9 to 1.15.10
Actions
Copy link
 #16

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.10 to 1.15.11
Actions
Copy link
 #17

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.11 to 1.15.12
Actions
Copy link
 #18

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.12 to 1.15.13
Actions
Copy link
 #19

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.13 to 1.15.14
Actions
Copy link
 #20

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.15.14 to 1.16.1
Actions
Copy link
 #21

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.16.1 to 1.16.2
Actions
Copy link
 #22

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.16.2 to 1.16.3
Actions
Copy link
 #23

Updated by Boone Gorges over 4 years ago

  • Target version changed from 1.16.3 to 1.16.4
Actions
Copy link
 #24

Updated by Boone Gorges about 4 years ago

  • Target version changed from 1.16.4 to 1.16.5
Actions
Copy link
 #25

Updated by Boone Gorges about 4 years ago

  • Target version changed from 1.16.5 to 1.16.6
Actions
Copy link
 #26

Updated by Boone Gorges about 4 years ago

  • Target version changed from 1.16.6 to 1.16.7
Actions
Copy link
 #27

Updated by Boone Gorges about 4 years ago

  • Target version changed from 1.16.7 to 1.16.8
Actions
Copy link
 #28

Updated by Boone Gorges about 4 years ago

  • Target version changed from 1.16.8 to 1.16.9
Actions
Copy link
 #29

Updated by Boone Gorges about 4 years ago

  • Target version changed from 1.16.9 to 1.16.10
Actions
Copy link
 #30

Updated by Boone Gorges almost 4 years ago

  • Target version changed from 1.16.10 to 1.16.11
Actions
Copy link
 #31

Updated by Boone Gorges almost 4 years ago

  • Target version changed from 1.16.11 to 1.16.12
Actions
Copy link
 #32

Updated by Raymond Hoh almost 4 years ago

  • Status changed from New to Staged for Production Release

Fixed in https://github.com/cuny-academic-commons/cac/commit/9d0764b0fdd9229ddc76a05f70c082cebd4d5849

The issue is when replying by email and adding a link with anchor text, the anchor-linked text is converted to plain-text format:

My link <https://commons.gc.cuny.edu>

When saved into the database, the triangular brackets get converted into HTML entities:

My link &lt;https://commons.gc.cuny.edu&gt;

And on the frontend, bbPress and BuddyPress will render the link as:

My link <https://commons.gc.cuny.edu&gt;

To fix this, I wrote a display filter to convert the triangular bracket HTML entities to circular brackets:

My link (https://commons.gc.cuny.edu)
Actions
Copy link
 #33

Updated by Boone Gorges almost 4 years ago

  • Status changed from Staged for Production Release to Resolved
Actions
Copy link

Also available in: Atom PDF