Project

General

Profile

Feature #11253

Feature #10987: Site/group creation portal

Add metadata fields to group settings

Added by Boone Gorges 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Groups (misc)
Target version:
Start date:
2019-03-21
Due date:
% Done:

0%

Estimated time:

campus-error-msg.png (10.5 KB) campus-error-msg.png Raymond Hoh, 2019-04-08 06:16 PM
purpose-error-msg.png (7.14 KB) purpose-error-msg.png Raymond Hoh, 2019-04-08 06:16 PM

History

#1 Updated by Boone Gorges 2 months ago

  • Status changed from New to In Progress

This is mostly done in https://github.com/cuny-academic-commons/cac/commit/d81ad42ea7e8b23936a743df638888ba437ec11c but I'll leave this open for the time being, in case there are changes.

#2 Updated by Boone Gorges 2 months ago

One remaining task here is that the "required" logic isn't 100% implemented.

#3 Updated by Boone Gorges about 2 months ago

  • Status changed from In Progress to Resolved

"required" is now working fully.

#4 Updated by Raymond Hoh about 1 month ago

Received a report from Scott that the HTML5 error messaging is a little vague.

The default "Please select an item in the list" dialog can be improved:
https://commons.gc.cuny.edu/files/missing-input-error-message.png

I've changed the error message for the Campus field to Please select the campus(es) from the list. If this Commons space is not associated with a campus, select 'Not Applicable'

And the Primary Purpose error message to Please select a primary purpose for this Commons space or select 'Other' if not applicable.

(Code reference - https://github.com/cuny-academic-commons/cac/commit/c44c4b71dabb927e9f0f8c51848fe671984cc9f8)

I've attached screenshots. Let me know if the error message should be changed to something else.

#5 Updated by Sonja Leix about 1 month ago

Raymond Hoh wrote:

Received a report from Scott that the HTML5 error messaging is a little vague.

The default "Please select an item in the list" dialog can be improved:
https://commons.gc.cuny.edu/files/missing-input-error-message.png

I've changed the error message for the Campus field to Please select the campus(es) from the list. If this Commons space is not associated with a campus, select 'Not Applicable'

And the Primary Purpose error message to Please select a primary purpose for this Commons space or select 'Other' if not applicable.

(Code reference - https://github.com/cuny-academic-commons/cac/commit/c44c4b71dabb927e9f0f8c51848fe671984cc9f8)

I've attached screenshots. Let me know if the error message should be changed to something else.

Ray, we have defined all the tooltips in this document, please double check if the correct copy has been implemented:
https://docs.google.com/document/d/160nzBINvCEyeEVvnTeZETpLL7FphfJ5Yr28pptunCvM/edit?usp=sharing

#6 Updated by Raymond Hoh about 1 month ago

Thanks for the link to the Google doc, Sonja.

I couldn't find any copy for error messages. What Scott brought up was the lack of specific error messaging when the Campus or Primary Purpose is blank and when the form is attempting to be submitted. The Google doc only appears to have copy for tooltips.

I'd be glad to change the copy for the error messages to something else.

#7 Updated by Sonja Leix about 1 month ago

Raymond Hoh wrote:

Thanks for the link to the Google doc, Sonja.

I couldn't find any copy for error messages. What Scott brought up was the lack of specific error messaging when the Campus or Primary Purpose is blank and when the form is attempting to be submitted. The Google doc only appears to have copy for tooltips.

I'd be glad to change the copy for the error messges to something else.

Thanks for clarifying. In that case the error messages you're added make sense from my perspective. We should add appropriate error messages for Academic term and Disciplinary cluster too then.

Please also make sure that dropdowns are consistent – some have a downward facing arrow, some don't. The arrow is a common indicator for drowdowns. So I'd opt to have arrows for all dropdowns. Thanks.

#8 Updated by Raymond Hoh about 1 month ago

In that case the error messages you're added make sense from my perspective. We should add appropriate error messages for Academic term and Disciplinary cluster too then

That's a little harder to implement because those fields are conditional and depend on the "Primary Purpose" to be selected as "Teaching" first. If we want to implement this, this will have to be via javascript, which complicates things.

Please also make sure that dropdowns are consistent – some have a downward facing arrow, some don't. The arrow is a common indicator for drowdowns. So I'd opt to have arrows for all dropdowns. Thanks.

I believe the reason why some dropdowns do not have a dropdown arrow is because you cannot select multiple options for them. Those dropdowns that only require a single option will have the dropdown arrow. This is due to the Select2 JS library that we're using to render the dropdowns.

#9 Updated by Sonja Leix about 1 month ago

Raymond Hoh wrote:

I believe the reason why some dropdowns do not have a dropdown arrow is because you cannot select multiple options for them. Those dropdowns that only require a single option will have the dropdown arrow. This is due to the Select2 JS library that we're using to render the dropdowns.

That makes sense. Thanks for clarifying!

Also available in: Atom PDF