Project

General

Profile

Feature #11399

Add beta BPEO feature for attaching ICS files to email notifications

Added by Boone Gorges over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Events
Target version:
Start date:
2019-04-24
Due date:
% Done:

0%

Estimated time:

Description

See https://github.com/cuny-academic-commons/bp-event-organiser/pull/68

Specifically, this could use testing alongside private/hidden events/groups.

History

#1 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.15.1 to 1.15.2

Added in https://github.com/cuny-academic-commons/cac/commit/cf4884c0a5c2dd36c177893e3d89ffc3f71442ac as part of 1.15.1. I'm going to bump to the next version so that we can gather any feedback.

#2 Updated by Boone Gorges over 2 years ago

  • Status changed from New to Testing Required

I've got this running on the Commons. ICS files are being generated and attached - for hidden and private groups, which was one of the concerns. In my tests, Thunderbird recognized it as an event, but Gmail didn't for some reason. Ray, when you've got a minute, would you please give it a test to see if you notice anything obvious? Maybe there's something about the syntax or the filename that Gmail doesn't like.

#3 Updated by Boone Gorges over 2 years ago

  • Target version changed from 1.15.2 to 1.15.3

#4 Updated by Boone Gorges over 2 years ago

  • Assignee changed from Boone Gorges to Raymond Hoh
  • Target version changed from 1.15.3 to 1.15.4

Assigning to Ray to take a peek - no rush.

#5 Updated by Raymond Hoh over 2 years ago

  • Status changed from Testing Required to Resolved

In my tests, Thunderbird recognized it as an event, but Gmail didn't for some reason. Ray, when you've got a minute, would you please give it a test to see if you notice anything obvious? Maybe there's something about the syntax or the filename that Gmail doesn't like.

Just tested in a hidden group. Gmail recognized the iCal attachment and I was able to download it. Gmail also offered to add it to my Google Calendar.

Maybe you had adblocking on? In my case, I had to enable 3rd-party scripts and frames to be loaded in uBlock Origin so the attachment download would work.

A few minor things to point out in the iCal file:
- The X-ORIGINAL-URL header uses an invalid URL - https://commons.gc.cuny.edu/events/event/. I think this should point to the singular group event permalink. This might be tricky if the event is tied to multiple groups. We could even consider removing this header as it doesn't appear to be a widely-used iCalendar header.
- If we change the X-ORIGINAL-URL header to match the group event permalink, the X-WR-CALDESC header should be changed to use the event description or a truncated version of it.
- The UID header uses the Commons IP address as part of the ID. Is this something we might want to change?

I'm going to mark as resolved for now. If we want to tweak parts of the ICS file, we can do so in a separate ticket.

#6 Updated by Boone Gorges over 2 years ago

Thanks, Ray! You're almost certainly correct about the ad-blockers.

Seems fine to handle the iCal changes in a separate ticket. I don't know enough about the standards or how clients handle them to make any recommendations about next steps. If the issues you've outlined above don't actually surface in any client implementation, it doesn't seem pressing to change them.

Also available in: Atom PDF