CUNY Academic Commons

Thanks, Ray. For CAC, this looks like a good solution.

More generally, I'm not sure what to think. Is it a feature or a bug to send email notifications on edit, whether single or bulk edits? Seems like we might consider disabling them altogether. Given that edits also have the 'new_groupblog_post' type, do we have enough information to suppress the notifications at the BPGES level? Would that even be desirable? I'm curious whether you have intuitions (or experience from other sites) on whether these activity items and/or notifications are needed.

More generally, I'm not sure what to think. Is it a feature or a bug to send email notifications on edit, whether single or bulk edits?

It can be jarring when older blog posts are suddenly sent to the group, so I think we shouldn't send email notifications on any blog post edit.

A blog post generally doesn't have any pertinent information like an event change of venue or time so I think we're safe to disable.

The main branch of BP Groupblog doesn't allow email notifications to be disabled while allowing the blog post item to be recorded into group activity stream. But, our specialized "Send to Group" metabox feature for the Commons does allow edits to be recorded into the group activity stream, while disabling email notifications.

Maybe we can merge our "Send to Group" code into the BP Groupblog plugin?

A user-facing toggle like 'Send to Group' seems like a decent feature, though the way it's currently written for the Commons is a bit hacky IIRC.

I'm wondering whether it's possible for us to modify bp-groupblog or even BP for BPGES to detect that a 'new_groupblog_post' activity item is, in fact, an edit, so that it can suppress its email notification (without relying on a user toggle). Some ideas for this:
- Add a new property to `BP_Activity_Activity` items along the lines of `is_new`. It'd be set to `true` when not populated from the DB. BPGES would bail if it sees is_new=false. When bp-groupblog fetches an existing item in bp_groupblog_catch_transition_post_status(), is_new would be false.
- Instead of a new object property, BP should pass an `is_new` value to the `bp_activity_before_save` and `bp_activity_after_save` actions. (This actually seems useful for lots of reasons, and might be more in line with WP hooks like `save_post`.)
- Build BPGES awareness into bp-groupblog. In bp_groupblog_set_group_to_post_activity(), if we know that we're editing an existing activity item, then we remove_action( ... BPGES function ... ) just before $activity->save()

The last is probably the easiest, though it's in some ways the least elegant. What do you think of these ideas?