CUNY Academic Commons

Dom, can you add this? Should just be able to copy from the top of the template.

@boone, after a little digging I believe this is a JS issue. I think a click event is getting attached to this pagination element which could be resulting in a "return false;"

I've attached a screenshot of web inspector's Network tab showing POST requests to wp-load.php being requested each time I click on the members pagination links (number AND forward arrow links) at the bottom of the list of members (the links at the top of the list work fine).

Upon further investigation I believe the offending code to be located in the "pagination click event" on line 568 of global.js:

https://github.com/castiron/cac/blob/master/wp-content/plugins/buddypress/bp-themes/bp-default/_inc/global.js#L568

I do not yet understand the exact job of this click event (although it seems pretty straight forward), it appears to differentiate between non-ajax related content and search related terms in order to gather information for the bp_filter_request() function. I looked at that function as well and it appears to be primarily involved with ajax requests, which means it should not be attached to the pagination links since they are not loading through ajax (as far as I can tell).

I have verified that commenting out the "return false;" on line 600 DOES ENABLE the bottom pagination links, however this is not a fix. My hope is that you are more familiar with this function and can shed some immediate light on a possible update. I think together we can knock this issue out no problem.

My current thinking says to add another condition to one of the outer 'if's', but I am hesitant to push any new code until I hear your feedback. I will continue working through the code tonight, let me know what you think whenever you have a spare second.

Don't try to comment out the 'return false;' on line 600 in your local dev env - it creates some weird loop that starts downloading a file full of links that rapidly grows to multiple GB's (that's right GIGABYTES)!! :-)

I'm not the biggest fan of ajax either. Most of the time it seems like overkill. I prefer ajax that "enhances" a page rather than completely controls it.

Here's the commit fix:

https://github.com/castiron/cac/commit/3c19a54c0b8d16b9d7b3e19034a146c4b92ac751