Project

General

Profile

Bug #12675

Markup coming through on Group Forum Mentions

Added by Luke Waltzer over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Forums
Target version:
Start date:
2020-04-18
Due date:
% Done:

0%

Estimated time:

Description

I've @tted a couple of folks in group forum posts recently, and the some markup has bled through to the post... I've had to go back in to edit by hand to clean up. Here's an example:

<span class=”atwho-inserted” contenteditable=”false” data-atwho-at-query=”@elen”>@elenaaboumrad</span>!!!)

History

#1 Updated by Boone Gorges over 1 year ago

  • Assignee set to Raymond Hoh
  • Target version set to 1.16.10

Luke, when you say "bled through to the post", you mean that it was being rendered on the web? That is, this is not specific to email notifications?

Can you walk through how you created the -mention? Did you type the -sign and then use the autocomplete tool to select the user from the list? If so, did the markup show while you were writing the post, or was it only after you published?

Ray, could you take charge here? You're the lucky soul who usually touches the rich-text editor in bbPress :) Just a hunch, but this could be linked to reordered filtering/escaping in bbPress 2.6.

#2 Updated by Luke Waltzer over 1 year ago

Luke, when you say "bled through to the post", you mean that it was being rendered on the web? That is, this is not specific to email notifications?

Yes, rendered on the web. Markup visible in the preview, and then when published.

Can you walk through how you created the -mention? Did you type the -sign and then use the autocomplete tool to select the user from the list? If so, did the markup show while you were writing the post, or was it only after you published?

Typed @ sign, selected member's name from autocomplete list. The markup showed in the preview immediately. After publishing, I edited the post and was able to manually remove the markup.

#3 Updated by Boone Gorges over 1 year ago

Thanks for the details, Luke.

#4 Updated by Raymond Hoh over 1 year ago

  • Category name set to Group Forums
  • Status changed from New to Staged for Production Release

Fixed in https://github.com/cuny-academic-commons/cac/commit/6d430073c6eb7f09366c83492d5971c475fc7b25.

The problem only exists when using the Visual Editor to write a forum reply and when mentioning someone. The fix took longer than expected because the At.js script BuddyPress uses for mentions is not very flexible as it will always wrap a <span> element around a mentioned user (see https://github.com/ichord/At.js/issues/469).

Related: There is a BuddyPress ticket looking to swap out At.js for Tribute - https://buddypress.trac.wordpress.org/ticket/8001. I'll look to see if I can help out with TinyMCE integration for Tribute.

#5 Updated by Boone Gorges over 1 year ago

  • Status changed from Staged for Production Release to Resolved

Also available in: Atom PDF