Project

General

Profile

Actions

Feature #12969

closed

Improve sizing for Knowmia embeds

Added by Boone Gorges over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Shortcodes and embeds
Target version:
Start date:
2020-06-23
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

From https://redmine.gc.cuny.edu/issues/12962#note-5:

(1) The video frame size seems to be hardcoded to 360 x 291 pixels. I think that must be partly due to the embed code that I sent you. In contrast, the embed code for the Loom.com<http://Loom.com> was set to have a variable (relative) size (“ … width = 100%, height = 100% …”). Is it possible to change the Knowmia embedding to relative size as well?

Actions #1

Updated by Boone Gorges over 4 years ago

  • Status changed from New to Staged for Production Release

The embedding technique I used in #12062, where you simply paste a URL on its own line in the editor, doesn't allow for height and width attributes to be passed. Relative height/weight only work if we can expect a consistent contrast ration on the original content, which I'm assuming is the case with Loom (given the kind of application it is) but which I assume is not the case with Knowmia.

As such, I think this means we have to switch to a shortcode rather than (or in addition to) the simpler embed. In https://github.com/cuny-academic-commons/cac/commit/aef0000113dc93246383d8688dfffbdf2325ef83 I've added a shortcode that can be used like this:

[knowmia key="7j7C" height="582px" width="720px"]

This will be available as part of the next scheduled release, on July 14.

Actions #2

Updated by Boone Gorges over 4 years ago

  • Category name set to Shortcodes and embeds
Actions #3

Updated by Boone Gorges over 4 years ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF