Bug #13101
closed'Topic Type' dropdown looks bad
0%
Description
See screenshot. The 'Topic Type' dropdown shown when creating a group forum item is styled in such a way that the items aren't legible (latest Firefox on Linux - this is probably browser-specific).
Ray, could you have a look please?
Files
Updated by Raymond Hoh over 4 years ago
Hi Boone, I can't duplicate this on Firefox and Chrome (Windows 10 though).
Can you attach your screenshot?
Updated by Boone Gorges over 4 years ago
Whoops, sorry. Attached.
If you can't see it, assign back to me and I'll take a look myself.
Updated by Raymond Hoh over 4 years ago
Ahh, I believe Firefox might style form input buttons differently on Linux. Or it could depend on the Linux desktop you are running like xfce vs. Cinnamon, etc.
I won't be able to debug this without spinning up a Linux box. If you could get to this, that would be great. Otherwise, throw it back to me.
Updated by Boone Gorges over 4 years ago
Thanks for having a look, Ray!
I played with it a bit and found the following:
#bbpress-forums fieldset.bbp-form input[type="text"], #bbpress-forums fieldset.bbp-form select { min-height: 28px; height: 28px; padding: 5px; }
I don't understand why there's a min-height and a height. In my tests, if I set height: auto
and leave min-height, it fixes the problem in FF and doesn't hurt the other browsers. Can you see a reason why not to do this? And why would bbPress have these conflicting declarations? :)
Updated by Raymond Hoh over 4 years ago
To be honest, I think both the min-height
and height
declarations could be removed. padding
already covers giving the select field some spacing, which is what I believe is the intention behind those declarations.
The only thing with the height
is it gives a little, extra vertical real estate for input text fields. I think we can get rid of both height
declarations and we should be fine. Does that work on Firefox for Linux?
Updated by Boone Gorges over 4 years ago
- Status changed from New to Staged for Production Release
Good call, Ray. I've made the change. https://github.com/cuny-academic-commons/cac/commit/9ccd823cc5bc20891b20542498f47d3340f1023f
Updated by Boone Gorges over 4 years ago
- Status changed from Staged for Production Release to Resolved