Project

General

Profile

Actions

Bug #135

closed

Add CSS classes to body tags in bp-nelo

Added by Boone Gorges over 14 years ago. Updated about 14 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Upgrades
Target version:
-
Start date:
2009-12-09
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

Many styling bugs are popping up around the site that cannot be fixed without either adding markup to templates (in the form of additional CSS selectors) or using body tags to make style changes to elements only on specific kinds of pages. The former option is a bad one because it greatly reduces the number of page templates that we can inherit from the parent theme. Thus I think the solution is to implement proper body classes.

To implement the classes is easy (the function is body_class() I think). But it's bound to stir up a lot of CSS that is currently idle on pages other than the home page, so a bit of fishing through the stylesheets to zap unnecessary styling will be necessary. Ideally this work would be combined with a more general optimization of the theme, but the task of fixing the small styling bugs is sufficiently important that I think we should get started on it right away.

Lucas, I know that you and the rest of the team at CIC are very busy. I'm assigning this ticket to you for the time being so that you can give me a sense of how much time you have in the next week or so. If you don't think you'll be able to get to it, let me know and either Chris Stein or I will take a stab at it.

Actions #1

Updated by Boone Gorges over 14 years ago

  • Status changed from New to Assigned
Actions #2

Updated by Lucas Thurston over 14 years ago

Boone,
I agree that body classes need to be turned back on. By the time we realized this during the implementation of the new template, we were already scheduling the push to live.

It's unlikely that any of us will have time to work on this until some point in January. We're absolutely swamped for the rest of the year and the first couple weeks of January.

As you say, a lot of currently dormant CSS is going to be stirred up in a lot of the nooks and crannies of BP. These changes should be made on dev after a stylesheet and template backsync from live.

Lucas

Actions #3

Updated by Boone Gorges over 14 years ago

  • Assignee changed from Lucas Thurston to Boone Gorges

Thanks for the response, Lucas. I definitely empathize with your being swamped. For the moment I'm going to reassign the ticket to myself - hopefully I can get to it before mid-January :)

Actions #4

Updated by Boone Gorges over 14 years ago

I took some time this morning and implemented the body classes. It took a while to find all rogue styles that popped up, but I think I caught most of them. I also took the opportunity to delete the php templates that had been created in bp-nelo merely to introduce new CSS classes (those new classes are now handled by body classes).

I'd like someone else to comb through the site to see whether I've missed anything before I close the ticket.

Actions #5

Updated by Boone Gorges over 14 years ago

  • Status changed from Assigned to 3
Actions #6

Updated by Matt Gold over 14 years ago

I'll check through the site tonight/tomorrow, but for now, I just want to thank you for getting to this. I appreciate it, and I know it wasn't easy.

Actions #7

Updated by Boone Gorges about 14 years ago

  • Status changed from 3 to Resolved

I assume this is fixed (I've seen no real problems) so I'm closing the ticket.

Actions

Also available in: Atom PDF