sent invitations page
"The sent invitations page has a bug that make it very difficult to use.
If you choose a filter, when you go to the next page or any subsequent page, the filter reverts to "all" so there's no way to see more than the first 10 of any specific invitation status."
#1 Updated by Boone Gorges over 1 year ago
- Category name set to Onboarding
- Assignee set to Raymond Hoh
- Target version set to 1.18.0
Thanks for the report and for your patience as I verified it.
Ray, it looks like this is due to the fact that the 'Filter by Status' dropdown (member > Invites > Sent Invitations) triggers an AJAX call to refetch the page contents, but the pagination links don't reflect the status. You could switch the pagination to AJAX, or switch the filtering to a URL param instead of a full AJAX call, or something in between :) Could you please have a look?
#2 Updated by Raymond Hoh over 1 year ago
- Status changed from New to Staged for Production Release
Fixed pagination for both instances :)
AJAX pagination was broken because we use a heavily-customized version of
bp-default. AJAX pagination requires the
<div id="content"> container wrapped somewhere on the page: https://github.com/buddypress/BP-Default/blob/baa3be909bb353e2a20a16a0e6da5219b4a73627/_inc/global.js#L727-L728. Because we use
cac-advanced-profiles, the Commons profile template does not use this container: https://github.com/cuny-academic-commons/cac-advanced-profiles/blob/master/templates/cacap/commons-profile.php. Had to inject the
"content" ID container manually.
URL pagination works now due to the addition on the
status query argument.
Here's the commit for
cac-onboarding - https://github.com/cuny-academic-commons/cac-onboarding/commit/39cb2d8c9f4003fa8c6e3ec54566ff34dc62183d.
And the pin for 1.18.x branch - https://github.com/cuny-academic-commons/cac/commit/300fca37dc81a507384e48c3547eadf9ca549c35.
#6 Updated by Marilyn Weber over 1 year ago
His name is Colin Pitet, and there's his full complaint:
"Thanks for looking into this. However, the filtering bug doesn’t seem to be fixed on my end.
Here’s what I get when filtering for Accepted invites:
Then, here’s what I see after clicking on “2”, to go to what should be the second page of my Accepted invites:"
I've attached those screenshots.
In another ticket he notes " Before grad school I worked in an IT dept for 10 years and I have a degree in information systems "
#7 Updated by Boone Gorges over 1 year ago
Thanks, Marilyn. Could you please let the user know that the fix is not yet deployed to the production site? We release bug fixes ("maintenance releases") twice monthly, on the second and fourth Tuesday of each month. See https://dev.commons.gc.cuny.edu/release-schedule-and-procedures/. The 'Staged for Production Release' ticket status means that a fix has been put into the codebase, and will be part of the next scheduled release.
#8 Updated by Raymond Hoh over 1 year ago
- Target version changed from 1.18.0 to 1.17.7
This ticket was scheduled for the 1.18 release, but I've just moved it up to 1.17.7, so the fix will be deployed next Tuesday.
Boone, I've updated the
ACTION_REQUIRED wiki entry to note the need for
git submodule update.