Project

General

Profile

Feature #13706

Github embed

Added by Laurie Hurson 12 months ago. Updated 11 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
-
Category name:
-
Target version:
Start date:
2020-12-14
Due date:
% Done:

0%

Estimated time:

Description

Hi All,

I know the Commons typically strips embed and iframe codes but sometimes we allow for custom embeds on certain sites.

A professor is requesting a github embed on his commons site, message below --

"I am trying to put together a microsite to showcase my students' work throughout the semester. The site will be built in Javascript and deployed in Github Pages and I was hoping to embed or iFrame it into our commons class page.

The link to embed will be at: https://interactivedatavis.github.io/Adv-Studio-Fall2020/ [interactivedatavis.github.io]
(currently it is just a duplication of last year's site, but it will be updated this weekend).
The commons link we would like to include the site on is: https://datavisstudiof2020.commons.gc.cuny.edu/category/posts/
"

Can we allow this embed on his site? Let me know if anymore information is needed.

Thanks!

History

#1 Updated by Laurie Hurson 12 months ago

I tried the github embed plugin but it did not work.

The "embed" block also did not work with the github link the professor provided but maybe I need a different link.

#2 Updated by Boone Gorges 12 months ago

The existing GitHub embed tools are specifically for embedding code samples. This is different from GitHub Pages rendered apps, as the one being used by the instructor. That's why our existing tools don't work.

The easiest thing is for me to write a custom embed handler. Can you confirm that this is a one-time thing, with a URL that won't change? If so, I can include a shortcode in next Tuesday's release.

#3 Updated by Laurie Hurson 12 months ago

Hi Boone,

Yes, I believe this is a one time thing. The professor would like to embed the student projects (github page) into the commons page (url provided) for this semester only. I can also let her know that we cannot support this embed process every upcoming semester (if that is the case).

#4 Updated by Boone Gorges 12 months ago

  • Target version set to 1.18.1

It's not a problem to do one per semester. I just don't want to create this one shortcode, then have the instructor realize they need three more right away, etc :) But it seems like this is not the case here, so we'll get a shortcode for the 1.18.1 release.

#5 Updated by Laurie Hurson 12 months ago

Ah, makes sense.

Shortcode release as part of 1.18.1 sounds great.

Thanks Boone!

#6 Updated by Laurie Hurson 12 months ago

Hi Boone --- one correction/update

the github page https://interactivedatavis.github.io/Adv-Studio-Fall2020/

should be embedded into this commons page: https://datavisstudiof2020.commons.gc.cuny.edu/showcase/

(previously she has specified a different commons page but changed this request in a more recent email.)

Thanks again.

#7 Updated by Boone Gorges 12 months ago

Sounds good, thanks!

#8 Updated by Boone Gorges 11 months ago

  • Status changed from New to Staged for Production Release

I've built the shortcode https://github.com/cuny-academic-commons/cac/commit/2ae9e74d0cee53861d93ae0e521e9db3d315a0f7. Supports height and width attributes. Eg:

[datavisstudiof2020 height="800" width="100%"]

This will be available for use after today's release.

#9 Updated by Boone Gorges 11 months ago

  • Status changed from Staged for Production Release to Resolved

#10 Updated by Laurie Hurson 11 months ago

Thanks Boone!

Also available in: Atom PDF