Project

General

Profile

Actions
Copy link

Bug #13966

closed

Replying by email to a trashed or spammed forum topic causes a fatal error

Added by Raymond Hoh almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority name:
High
Assignee:
Raymond Hoh
Category name:
Reply By Email
Target version:
1.18.5
Start date:
2021-02-09
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

So on the dev call, I thought that there was a timeout issue when parsing the RBE inbox check.

Turns out the problem was simpler than that! A user was replying to a trashed forum topic and that caused a fatal error due to the way RBE handles replies when a forum topic was trashed or marked as spammed.

Full details here: https://github.com/r-a-y/bp-reply-by-email/issues/125

I initially copied the reply logic from bbPress and they also recently addressed the issue in bbPress 2.6.5: https://bbpress.trac.wordpress.org/ticket/3409

Actions
Copy link
 #1

Updated by Raymond Hoh almost 4 years ago

  • Status changed from New to Resolved

Fixed in https://github.com/cuny-academic-commons/cac/commit/7090e1328837d88a009ffb8a29301ac6d6780b00#diff-20dc6960336c2116a3eec6e82d9ee51b8d2a0fb2563cceeb25a8a540d4266be2.

Also deployed as a hotfix.

One other thing I wanted to note is in bbPress, if a forum topic is trashed or spammed but a user attempts to reply, the reply is still allowed through. However, it is later also marked as trash or spam.

I'm thinking we shouldn't follow bbPress here for RBE. If a forum topic is trashed or marked as spam, I think we should stop parsing the email reply and instead, send back an error email to the sender saying that the replied forum topic has been trashed or marked as spam. Would welcome thoughts from others on this.

Actions
Copy link
 #2

Updated by Matt Gold almost 4 years ago

I agree, Ray

Actions
Copy link

Also available in: Atom PDF